Commit ec460ce8 authored by Monica Basta's avatar Monica Basta Committed by Commit Bot

[SyncSetup]: Add user action when the user navigates to Sync advanced.

This CL records a user action when the user navigates to
chrome://settings/syncSetup/Advanced. This metric is needed for sync
setup friendly settings.

Bug: 1050070
Change-Id: I6206807fd8038385f8cd9d8b9fe1d7e0077c9a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096441Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749189}
parent 1c73f3f4
...@@ -39,7 +39,7 @@ const RadioButtonNames = { ...@@ -39,7 +39,7 @@ const RadioButtonNames = {
Polymer({ Polymer({
is: 'settings-sync-controls', is: 'settings-sync-controls',
behaviors: [WebUIListenerBehavior], behaviors: [WebUIListenerBehavior, settings.RouteObserverBehavior],
properties: { properties: {
hidden: { hidden: {
...@@ -103,6 +103,14 @@ Polymer({ ...@@ -103,6 +103,14 @@ Polymer({
} }
}, },
/** @protected */
currentRouteChanged() {
const router = settings.Router.getInstance();
if (router.getCurrentRoute() === router.getRoutes().SYNC_ADVANCED) {
chrome.metricsPrivate.recordUserAction('Sync_NavigateToSyncAdvancedPage');
}
},
/** /**
* Handler for when the sync preferences are updated. * Handler for when the sync preferences are updated.
* @private * @private
......
...@@ -22560,7 +22560,16 @@ should be able to be added at any place in this file. ...@@ -22560,7 +22560,16 @@ should be able to be added at any place in this file.
<owner>chrome-signin-team@google.com</owner> <owner>chrome-signin-team@google.com</owner>
<description> <description>
The user selected to customize sync from The user selected to customize sync from
|chrome://settings/syncSetup/advanced|. chrome://settings/syncSetup/advanced.
</description>
</action>
<action name="Sync_NavigateToSyncAdvancedPage">
<owner>msalama@chromium.org</owner>
<owner>chrome-signin-team@google.com</owner>
<description>
The user has navigated to the sync advanced settings page
chrome://settings/syncSetup/advanced.
</description> </description>
</action> </action>
...@@ -22568,8 +22577,8 @@ should be able to be added at any place in this file. ...@@ -22568,8 +22577,8 @@ should be able to be added at any place in this file.
<owner>msalama@chromium.org</owner> <owner>msalama@chromium.org</owner>
<owner>chrome-signin-team@google.com</owner> <owner>chrome-signin-team@google.com</owner>
<description> <description>
The user has clicked on the history usage row in The user has clicked on the history usage row in chrome://settings/syncSetup
|chrome://settings/syncSetup| to open Activity controls page. to open Activity controls page.
</description> </description>
</action> </action>
...@@ -22577,8 +22586,7 @@ should be able to be added at any place in this file. ...@@ -22577,8 +22586,7 @@ should be able to be added at any place in this file.
<owner>msalama@chromium.org</owner> <owner>msalama@chromium.org</owner>
<owner>chrome-signin-team@google.com</owner> <owner>chrome-signin-team@google.com</owner>
<description> <description>
The user selected sync everything from The user selected sync everything from chrome://settings/syncSetup/advanced.
|chrome://settings/syncSetup/advanced|.
</description> </description>
</action> </action>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment