Commit ec77774a authored by Ian Kilpatrick's avatar Ian Kilpatrick Committed by Commit Bot

Remove -webkit-center from mediaControls.css for immersive-mode.

"text-align: -webkit-center" is a non-standard css property/value pair
which has undefined behaviour.

This was being used for centering the video controls within the video
player when in the "immersive-mode".

https://chromium-review.googlesource.com/c/chromium/src/+/1977196
...changed how the blink's layout codebase handles margins, removing a
bug for when "-webkit-center" is set on a child.

This patch changes the immersive-mode stylesheet to use:
"align-items: center" for centering the controls in their container.

It was also necessary to specify the width of the "timeline" to ensure
it filled the available space.

This also re-enables the disabled test.

Bug: 1041904
Change-Id: I6ca530a14185fa0bba8900824cef3b369728e90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144777Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759418}
parent 2e1ab2b0
...@@ -24,7 +24,6 @@ import org.junit.runner.RunWith; ...@@ -24,7 +24,6 @@ import org.junit.runner.RunWith;
import org.chromium.base.test.BundleTestRule; import org.chromium.base.test.BundleTestRule;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.browser.flags.ChromeSwitches; import org.chromium.chrome.browser.flags.ChromeSwitches;
...@@ -438,7 +437,6 @@ public class VrBrowserWebInputEditingTest { ...@@ -438,7 +437,6 @@ public class VrBrowserWebInputEditingTest {
@Test @Test
@MediumTest @MediumTest
@Feature({"Browser", "RenderTest"}) @Feature({"Browser", "RenderTest"})
@DisabledTest(message = "https://crbug.com/1041904")
public void testFullscreenVideoControls() public void testFullscreenVideoControls()
throws InterruptedException, TimeoutException, IOException { throws InterruptedException, TimeoutException, IOException {
// There's occasionally slight AA differences along the play button, so tolerate a small // There's occasionally slight AA differences along the play button, so tolerate a small
......
...@@ -1349,6 +1349,7 @@ video::-webkit-media-controls.immersive-mode div[pseudo="-internal-media-control ...@@ -1349,6 +1349,7 @@ video::-webkit-media-controls.immersive-mode div[pseudo="-internal-media-control
/* Timeline sizing does not include padding in max width. */ /* Timeline sizing does not include padding in max width. */
video::-webkit-media-controls.immersive-mode input[pseudo="-webkit-media-controls-timeline" i] { video::-webkit-media-controls.immersive-mode input[pseudo="-webkit-media-controls-timeline" i] {
width: calc(100% - 64px);
max-width: 471px; max-width: 471px;
height: 5px; height: 5px;
margin-bottom: 20px; margin-bottom: 20px;
...@@ -1363,7 +1364,7 @@ video::-webkit-media-controls.immersive-mode div[pseudo="-internal-media-control ...@@ -1363,7 +1364,7 @@ video::-webkit-media-controls.immersive-mode div[pseudo="-internal-media-control
video::-webkit-media-controls.immersive-mode div[pseudo="-webkit-media-controls-panel" i] { video::-webkit-media-controls.immersive-mode div[pseudo="-webkit-media-controls-panel" i] {
/* Centering the button panel and timeline within the controls. */ /* Centering the button panel and timeline within the controls. */
text-align: -webkit-center; align-items: center;
/* Taller scrim. */ /* Taller scrim. */
background: background:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment