[Background Fetch] Respond to service worker database corruption.

This will abort all ongoing fetches, and mark their data for deletion.

Bug: 841385
Change-Id: I19eba7a294dd348c0c0a5324f3b23b438b571c03

Change-Id: I19eba7a294dd348c0c0a5324f3b23b438b571c03
Reviewed-on: https://chromium-review.googlesource.com/1103559
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570830}

content/browser/background_fetch/background_fetch_context.cc

@@ -27,21 +27,21 @@ BackgroundFetchContext::BackgroundFetchContext(
     const scoped_refptr<content::CacheStorageContextImpl>&
         cache_storage_context)
     : browser_context_(browser_context),
-      data_manager_(
-          std::make_unique<BackgroundFetchDataManager>(browser_context,
-                                                       service_worker_context,
-                                                       cache_storage_context)),
       service_worker_context_(service_worker_context),
       event_dispatcher_(service_worker_context),
       registration_notifier_(
           std::make_unique<BackgroundFetchRegistrationNotifier>()),
       delegate_proxy_(browser_context_->GetBackgroundFetchDelegate()),
-      scheduler_(
-          std::make_unique<BackgroundFetchScheduler>(data_manager_.get())),
       weak_factory_(this) {
   // Although this lives only on the IO thread, it is constructed on UI thread.
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK(service_worker_context_);
+  data_manager_ = std::make_unique<BackgroundFetchDataManager>(
+      browser_context, service_worker_context, cache_storage_context,
+      base::BindRepeating(&BackgroundFetchContext::AbandonFetches,
+                          weak_factory_.GetWeakPtr(),
+                          blink::mojom::kInvalidServiceWorkerRegistrationId));
+  scheduler_ = std::make_unique<BackgroundFetchScheduler>(data_manager_.get());
 }
 
 BackgroundFetchContext::~BackgroundFetchContext() {

content/browser/background_fetch/background_fetch_data_manager.cc

@@ -63,13 +63,16 @@ void GetRegistrationFromMetadata(
 BackgroundFetchDataManager::BackgroundFetchDataManager(
     BrowserContext* browser_context,
     scoped_refptr<ServiceWorkerContextWrapper> service_worker_context,
-    scoped_refptr<CacheStorageContextImpl> cache_storage_context)
+    scoped_refptr<CacheStorageContextImpl> cache_storage_context,
+    const base::RepeatingClosure& abandon_fetches_callback)
     : service_worker_context_(std::move(service_worker_context)),
       cache_storage_context_(std::move(cache_storage_context)),
+      abandon_fetches_callback_(abandon_fetches_callback),
       weak_ptr_factory_(this) {
   // Constructed on the UI thread, then used on the IO thread.
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK(browser_context);
+  DCHECK(abandon_fetches_callback_);
 
   // Store the blob storage context for the given |browser_context|.
   blob_storage_context_ =

content/browser/background_fetch/background_fetch_data_manager.h

@@ -72,7 +72,8 @@ class CONTENT_EXPORT BackgroundFetchDataManager
   BackgroundFetchDataManager(
       BrowserContext* browser_context,
       scoped_refptr<ServiceWorkerContextWrapper> service_worker_context,
-      scoped_refptr<CacheStorageContextImpl> cache_storage_context);
+      scoped_refptr<CacheStorageContextImpl> cache_storage_context,
+      const base::RepeatingClosure& abandon_fetches_callback);
 
   ~BackgroundFetchDataManager() override;
 
@@ -148,6 +149,10 @@ class CONTENT_EXPORT BackgroundFetchDataManager
       const BackgroundFetchRegistrationId& registration_id,
       NumRequestsCallback callback);
 
+  const base::RepeatingClosure& abandon_fetches_callback() {
+    return abandon_fetches_callback_;
+  }
+
   // BackgroundFetchScheduler::RequestProvider implementation:
   void PopNextRequest(const BackgroundFetchRegistrationId& registration_id,
                       NextRequestCallback callback) override;
@@ -217,6 +222,11 @@ class CONTENT_EXPORT BackgroundFetchDataManager
   // the browser is shutdown first.
   std::set<std::string> ref_counted_unique_ids_;
 
+  // This is called to abandon all ongoing fetches. It will also mark these
+  // fetches for deletion, which will be cleaned up by the Cleanup task
+  // subsequently.
+  base::RepeatingClosure abandon_fetches_callback_;
+
   base::WeakPtrFactory<BackgroundFetchDataManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BackgroundFetchDataManager);

content/browser/background_fetch/background_fetch_test_data_manager.cc

@@ -42,7 +42,8 @@ BackgroundFetchTestDataManager::BackgroundFetchTestDataManager(
     bool mock_fill_response)
     : BackgroundFetchDataManager(browser_context,
                                  service_worker_context,
-                                 nullptr /* cache_storage_context */),
+                                 nullptr /* cache_storage_context */,
+                                 base::DoNothing()),
       browser_context_(browser_context),
       storage_partition_(storage_partition),
       mock_fill_response_(mock_fill_response) {}

content/browser/background_fetch/storage/delete_registration_task.cc

@@ -8,6 +8,7 @@
 
 #include "base/barrier_closure.h"
 #include "content/browser/background_fetch/background_fetch.pb.h"
+#include "content/browser/background_fetch/background_fetch_data_manager.h"
 #include "content/browser/background_fetch/storage/database_helpers.h"
 #include "content/browser/cache_storage/cache_storage_manager.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
@@ -91,8 +92,10 @@ void DeleteRegistrationTask::DidGetRegistration(
               metadata_proto.registration().developer_id())},
           base::BindOnce(&DCheckRegistrationNotActive, unique_id_));
     } else {
-      NOTREACHED()
-          << "Database is corrupt";  // TODO(crbug.com/780027): Nuke it.
+      // Service worker database has been corrupted. Abandon all fetches.
+      error_ = blink::mojom::BackgroundFetchError::STORAGE_ERROR;
+      data_manager()->abandon_fetches_callback().Run();
+      std::move(done_closure).Run();
     }
   } else {
     // TODO(crbug.com/780025): Log failure to UMA.

content/browser/background_fetch/storage/get_settled_fetches_task.cc

@@ -5,6 +5,7 @@
 #include "content/browser/background_fetch/storage/get_settled_fetches_task.h"
 
 #include "base/barrier_closure.h"
+#include "content/browser/background_fetch/background_fetch_data_manager.h"
 #include "content/browser/background_fetch/storage/database_helpers.h"
 #include "content/browser/cache_storage/cache_storage_manager.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
@@ -78,8 +79,11 @@ void GetSettledFetchesTask::DidGetCompletedRequests(
     completed_requests_.emplace_back();
     if (!completed_requests_.back().ParseFromString(
             serialized_completed_request)) {
-      NOTREACHED()
-          << "Database is corrupt";  // TODO(crbug.com/780027): Nuke it.
+      // Service worker database has been corrupted. Abandon fetches.
+      error_ = blink::mojom::BackgroundFetchError::STORAGE_ERROR;
+      background_fetch_succeeded_ = false;
+      data_manager()->abandon_fetches_callback().Run();
+      break;
     }
     if (!completed_requests_.back().succeeded())
       background_fetch_succeeded_ = false;

content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc

@@ -77,7 +77,11 @@ void MarkRegistrationForDeletionTask::DidGetActiveUniqueId(
         base::BindOnce(&MarkRegistrationForDeletionTask::DidDeactivate,
                        weak_factory_.GetWeakPtr()));
   } else {
-    NOTREACHED() << "Database is corrupt";  // TODO(crbug.com/780027): Nuke it.
+    // Service worker database has been corrupted. Abandon fetches.
+    data_manager()->abandon_fetches_callback().Run();
+    std::move(callback_).Run(blink::mojom::BackgroundFetchError::STORAGE_ERROR);
+    Finished();  // Destroys |this|.
+    return;
   }
 }
 

content/browser/background_fetch/storage/start_next_pending_request_task.cc

@@ -5,6 +5,7 @@
 #include "content/browser/background_fetch/storage/start_next_pending_request_task.h"
 
 #include "base/guid.h"
+#include "content/browser/background_fetch/background_fetch_data_manager.h"
 #include "content/browser/background_fetch/storage/database_helpers.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 
@@ -59,7 +60,11 @@ void StartNextPendingRequestTask::DidGetPendingRequests(
   }
 
   if (!pending_request_.ParseFromString(data.front())) {
-    NOTREACHED() << "Database is corrupt";  // TODO(crbug.com/780027): Nuke it.
+    // Service Worker database has been corrupted. Abandon fetches.
+    data_manager()->abandon_fetches_callback().Run();
+    std::move(callback_).Run(nullptr /* request */);
+    Finished();  // Destroys |this|.
+    return;
   }
 
   // Make sure there isn't already an Active Request.
@@ -87,8 +92,11 @@ void StartNextPendingRequestTask::DidFindActiveRequest(
     case DatabaseStatus::kOk:
       // We already stored the active request.
       if (!active_request_.ParseFromString(data.front())) {
-        NOTREACHED()
-            << "Database is corrupt";  // TODO(crbug.com/780027): Nuke it.
+        // Service worker database has been corrupted. Abandon fetches.
+        data_manager()->abandon_fetches_callback().Run();
+        std::move(callback_).Run(nullptr /* request */);
+        Finished();
+        return;
       }
       StartDownload();
       return;