Skip to content

GitLab

T
tangled
Commit ecb0b699 authored by Caleb Raitto's avatar Caleb Raitto Committed by Commit Bot
Browse files
Options

Disable leaking content_browsertests on LSAN. 

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961029
Change-Id: I189cfe1a129ed7af4f87d256e3ecf1d9d84a392a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638920Reviewed-by: default avatarNektarios Paisios <nektar@chromium.org>
Reviewed-by: default avatarKatie Dektar <katie@chromium.org>
Reviewed-by: default avatarMartin Robinson <mrobinson@igalia.com>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666310}
parent 34374f1b
Show whitespace changes
Inline Side-by-side
Showing with 24 additions and 4 deletions
content/browser/accessibility/accessibility_auralinux_browsertest.cc
View file @ ecb0b699
......@@ -17,6 +17,17 @@
#include "content/test/content_browser_test_utils_internal.h"
#include "ui/accessibility/platform/ax_platform_node_auralinux.h"
// TODO(crbug.com/961029): Fix memory leaks in tests and re-enable on LSAN.
#ifdef LEAK_SANITIZER
#define MAYBE_TestAtkTextListItem DISABLED_TestAtkTextListItem
#define MAYBE_TestSetCaretSetsSequentialFocusNavigationStartingPoint \
DISABLED_TestSetCaretSetsSequentialFocusNavigationStartingPoint
#else
#define MAYBE_TestAtkTextListItem TestAtkTextListItem
#define MAYBE_TestSetCaretSetsSequentialFocusNavigationStartingPoint \
TestSetCaretSetsSequentialFocusNavigationStartingPoint
#endif
namespace content {
namespace {
......@@ -719,7 +730,8 @@ IN_PROC_BROWSER_TEST_F(AccessibilityAuraLinuxBrowserTest, TestSetSelection) {
g_object_unref(atk_text);
}
IN_PROC_BROWSER_TEST_F(AccessibilityAuraLinuxBrowserTest, TestAtkTextListItem) {
IN_PROC_BROWSER_TEST_F(AccessibilityAuraLinuxBrowserTest,
MAYBE_TestAtkTextListItem) {
LoadInitialAccessibilityTreeFromHtml(
R"HTML(<!DOCTYPE html>
<html>
......@@ -760,8 +772,9 @@ IN_PROC_BROWSER_TEST_F(AccessibilityAuraLinuxBrowserTest, TestAtkTextListItem) {
g_object_unref(list_item_1);
}
IN_PROC_BROWSER_TEST_F(AccessibilityAuraLinuxBrowserTest,
TestSetCaretSetsSequentialFocusNavigationStartingPoint) {
IN_PROC_BROWSER_TEST_F(
AccessibilityAuraLinuxBrowserTest,
MAYBE_TestSetCaretSetsSequentialFocusNavigationStartingPoint) {
LoadInitialAccessibilityTreeFromHtml(
R"HTML(<!DOCTYPE html>
<html>
......
content/browser/speech/tts_ssml_browsertest.cc
View file @ ecb0b699
......@@ -6,6 +6,13 @@
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
// TODO(crbug.com/961029): Fix memory leaks in tests and re-enable on LSAN.
#ifdef LEAK_SANITIZER
#define MAYBE_TestStripSSML DISABLED_TestStripSSML
#else
#define MAYBE_TestStripSSML TestStripSSML
#endif
namespace content {
namespace {
......@@ -50,7 +57,7 @@ class TtsSsmlBrowserTest : public ContentBrowserTest {
} // namespace
IN_PROC_BROWSER_TEST_F(TtsSsmlBrowserTest, TestStripSSML) {
IN_PROC_BROWSER_TEST_F(TtsSsmlBrowserTest, MAYBE_TestStripSSML) {
// No SSML should be stripped.
RunNoStripSSMLTest("");
RunNoStripSSMLTest("What if I told you that 5 < 4?");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment