Commit ed08c574 authored by Yoshifumi Inoue's avatar Yoshifumi Inoue Committed by Commit Bot

Revert "Mark BubbleDialogDelegateViewTest.VisibleAnchorChanges flaky"

This reverts commit 0b8e0f13.

Reason for revert: It seems the flakiness caused by bot flakiness.

Original change's description:
> Mark BubbleDialogDelegateViewTest.VisibleAnchorChanges flaky
> 
> This patch marks BubbleDialogDelegateViewTest.VisibleAnchorChanges flaky
> 
> TBR=erikchen@chromium.org
> 
> Bug: 903004
> Change-Id: I03f9d1f227dfdb281b04dc3073dbe803518f94e5
> Reviewed-on: https://chromium-review.googlesource.com/c/1325272
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606325}

TBR=yosin@chromium.org

Change-Id: Ibf71df02f951f45ae43cec1f7428cee98f6da838
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 903004
Reviewed-on: https://chromium-review.googlesource.com/c/1325276Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606335}
parent 569f791a
......@@ -9,7 +9,6 @@
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "ui/base/hit_test.h"
#include "ui/events/event_utils.h"
#include "ui/views/animation/test/ink_drop_host_view_test_api.h"
......@@ -540,15 +539,7 @@ TEST_F(BubbleDialogDelegateViewTest, VisibleWidgetShowsInkDropOnAttaching) {
EXPECT_EQ(InkDropState::DEACTIVATED, ink_drop->GetTargetInkDropState());
}
// TODO(crbug.com/903004): We should make VisibleAnchorChanges test not flaky
// on Mac.
#if defined(OS_MACOSX)
#define MAYBE_VisibleAnchorChanges DISABLED_VisibleAnchorChanges
#else
#define MAYBE_VisibleAnchorChanges VisibleAnchorChanges
#endif
TEST_F(BubbleDialogDelegateViewTest, MAYBE_VisibleAnchorChanges) {
TEST_F(BubbleDialogDelegateViewTest, VisibleAnchorChanges) {
std::unique_ptr<Widget> anchor_widget(CreateTestWidget());
TestBubbleDialogDelegateView* bubble_delegate =
new TestBubbleDialogDelegateView(nullptr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment