Commit edf03f29 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/platform_keys.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=emaxx@chromium.org

Bug: 925652
Change-Id: I1f3436a182d6047e8b2989835df355c1a14880c6
Reviewed-on: https://chromium-review.googlesource.com/c/1437342
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626502}
parent 2a6f467c
...@@ -352,7 +352,7 @@ IN_PROC_BROWSER_TEST_P(UnmanagedPlatformKeysTest, Permissions) { ...@@ -352,7 +352,7 @@ IN_PROC_BROWSER_TEST_P(UnmanagedPlatformKeysTest, Permissions) {
ASSERT_TRUE(RunExtensionTest("permissionTests")) << message_; ASSERT_TRUE(RunExtensionTest("permissionTests")) << message_;
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
Unmanaged, Unmanaged,
UnmanagedPlatformKeysTest, UnmanagedPlatformKeysTest,
::testing::Values(UnmanagedPlatformKeysTestParams( ::testing::Values(UnmanagedPlatformKeysTestParams(
...@@ -402,7 +402,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithoutPermissionPlatformKeysTest, ...@@ -402,7 +402,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithoutPermissionPlatformKeysTest,
<< message_; << message_;
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
ManagedWithoutPermission, ManagedWithoutPermission,
ManagedWithoutPermissionPlatformKeysTest, ManagedWithoutPermissionPlatformKeysTest,
::testing::Values( ::testing::Values(
...@@ -461,7 +461,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithPermissionPlatformKeysTest, ...@@ -461,7 +461,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithPermissionPlatformKeysTest,
<< message_; << message_;
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
ManagedWithPermission, ManagedWithPermission,
ManagedWithPermissionPlatformKeysTest, ManagedWithPermissionPlatformKeysTest,
::testing::Values( ::testing::Values(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment