Commit ef2b8384 authored by James Cook's avatar James Cook Committed by Chromium LUCI CQ

Don't log when the LacrosSupport flag is not enabled

The "Lacros-chrome is not supported" was printing 7 times in each
Chrome OS browser_tests test run. This confused some developers, who
thought their test failures might be caused by lacros. Since the flag
being off is the common case, don't log.

Bug: none
Change-Id: I38b46b0a0390d39fae5ca1f095c9131aa25692f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627714
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: default avatarJenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843636}
parent fbf4cc1a
...@@ -164,7 +164,7 @@ bool IsLacrosEnabled(Channel channel) { ...@@ -164,7 +164,7 @@ bool IsLacrosEnabled(Channel channel) {
return true; return true;
if (!base::FeatureList::IsEnabled(chromeos::features::kLacrosSupport)) { if (!base::FeatureList::IsEnabled(chromeos::features::kLacrosSupport)) {
LOG(WARNING) << "Lacros-chrome is not supported"; // Don't log here. It's too spammy.
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment