Skip to content

GitLab

T
tangled
Commit ef91311b authored by Sahir Vellani's avatar Sahir Vellani Committed by Commit Bot
Browse files
Options

Place new version of ResizeObserver::observe behind runtime flag 

Put new implementation of ResizeObserver::observe behind
ResizeObserverUpdates flag to prevent compat issues until the final
version of Resize Observer is shipped. No JavaScript error shold
be thrown when unsupported second argument is passed to
ResizeObserver::observe(). Issue was introduced in the
following CL: http://crrev.com/c/2004051

Bug: 1056535
Change-Id: I7e6d319d14f9d318e0f68ea3e056cfa27eb7f937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077280
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Reviewed-by: default avatarDaniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#750235}
parent 8881a9a3
Show whitespace changes
Inline Side-by-side
Showing with 29 additions and 1 deletion
third_party/blink/renderer/core/resize_observer/resize_observer.idl
View file @ ef91311b
...@@ -13,7 +13,8 @@ callback ResizeObserverCallback = void (sequence<ResizeObserverEntry> entries, R ...@@ -13,7 +13,8 @@ callback ResizeObserverCallback = void (sequence<ResizeObserverEntry> entries, R
ActiveScriptWrappable ActiveScriptWrappable
] interface ResizeObserver { ] interface ResizeObserver {
[CallWith=Document, MeasureAs=ResizeObserver_Constructor] constructor(ResizeObserverCallback callback); [CallWith=Document, MeasureAs=ResizeObserver_Constructor] constructor(ResizeObserverCallback callback);
void observe(Element target, optional ResizeObserverOptions options); [RuntimeEnabled=ResizeObserverUpdates] void observe(Element target, ResizeObserverOptions options);
void observe(Element target);
void unobserve(Element target); void unobserve(Element target);
void disconnect(); void disconnect();
}; };
third_party/blink/web_tests/VirtualTestSuites
View file @ ef91311b
...@@ -95,6 +95,7 @@ ...@@ -95,6 +95,7 @@
"http/tests/serviceworker/webexposed", "http/tests/serviceworker/webexposed",
"inspector-protocol/dom-snapshot", "inspector-protocol/dom-snapshot",
"media/stable", "media/stable",
"resize-observer",
"webexposed"], "webexposed"],
"args": ["--stable-release-mode"] "args": ["--stable-release-mode"]
}, },
......
third_party/blink/web_tests/virtual/stable/resize-observer/README.txt 0 → 100644
View file @ ef91311b
# This suite runs the test in resize-observer/ with --stable-release-mode, with which
# we run tests with only stable feature (no experiments).
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
third_party/blink/web_tests/virtual/stable/resize-observer/observe_compat.html 0 → 100644
View file @ ef91311b
<!doctype HTML>
<script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script>
<style>
div {
width: 100px;
height: 100px;
}
</style>
<div id="observeme"></div>
<script>
//Ensure no error is thrown, second argument in observe() is ignored
test(() => {
new ResizeObserver(entries => {
}).observe(observeme, "TEST");
observeme.style.height = "110px";
}, "No error is thrown when observe() is called");
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment