Skip to content

GitLab

T
tangled
Commit ef92854a authored by Adithya Srinivasan's avatar Adithya Srinivasan Committed by Chromium LUCI CQ
Browse files
Options

Revert "Portals: Add regression test for console duplication" 

This reverts commit 2a2699ae.

Reason for revert: Reverting https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2159599

Original change's description:
> Portals: Add regression test for console duplication
>
> Fix was landed in https://crrev.com/c/2159599.
>
> Bug: 1069487
> Change-Id: I88088ea07b76014e2cdb8c01ca0385f39470de10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388480
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804997}

TBR=adithyas@chromium.org,szuend@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1069487
Change-Id: I64c27b50153c607925e806540af7f12e1e177f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595249Reviewed-by: default avatarAdithya Srinivasan <adithyas@chromium.org>
Reviewed-by: default avatarSimon Zünd <szuend@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840148}
parent 83fb71af
Show whitespace changes
Inline Side-by-side
Showing with 0 additions and 67 deletions
third_party/blink/web_tests/http/tests/devtools/portals/portals-console-duplication-expected.txt deleted 100644 → 0
View file @ 83fb71af
Tests that console messages aren't duplicated after portal activation
Message count: 3
console-duplication-host.html:4 host
console-duplication-portal-1.html:3 portal-1
console-duplication-portal-2.html:3 portal-2
first activate (without adoption)
console-duplication-host.html:4 host
console-duplication-portal-1.html:3 portal-1
console-duplication-portal-2.html:3 portal-2
second activate (with adoption)
console-duplication-host.html:4 host
console-duplication-portal-1.html:3 portal-1
console-duplication-portal-2.html:3 portal-2
third_party/blink/web_tests/http/tests/devtools/portals/portals-console-duplication.js deleted 100644 → 0
View file @ 83fb71af
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
(async function() {
TestRunner.addResult(`Tests that console messages aren't duplicated after portal activation`);
await TestRunner.loadModule('console_test_runner');
await TestRunner.showPanel('console');
await TestRunner.navigatePromise('resources/console-duplication-host.html');
const targets = SDK.targetManager.targets();
TestRunner.assertEquals(3, targets.length);
await ConsoleTestRunner.waitForConsoleMessagesPromise(3);
await ConsoleTestRunner.dumpConsoleMessages();
function activate() {
TestRunner.evaluateInPage(`setTimeout(() => document.querySelector('portal').activate());`);
}
TestRunner.addResult('\nfirst activate (without adoption)');
activate();
await ConsoleTestRunner.waitUntilNthMessageReceivedPromise(2);
TestRunner.assertEquals(3, ConsoleTestRunner.consoleMessagesCount());
await ConsoleTestRunner.dumpConsoleMessages();
TestRunner.addResult('\nsecond activate (with adoption)');
activate();
await ConsoleTestRunner.waitUntilNthMessageReceivedPromise(2);
TestRunner.assertEquals(3, ConsoleTestRunner.consoleMessagesCount());
await ConsoleTestRunner.dumpConsoleMessages();
TestRunner.completeTest();
})();
third_party/blink/web_tests/http/tests/devtools/portals/resources/console-duplication-host.html deleted 100644 → 0
View file @ 83fb71af
<!DOCTYPE html>
<body>
<script>
console.log('host');
</script>
<portal src="console-duplication-portal-1.html"></portal>
</body>
third_party/blink/web_tests/http/tests/devtools/portals/resources/console-duplication-portal-1.html deleted 100644 → 0
View file @ 83fb71af
<!DOCTYPE html>
<script>
console.log('portal-1');
</script>
<portal src="console-duplication-portal-2.html"></portal>
third_party/blink/web_tests/http/tests/devtools/portals/resources/console-duplication-portal-2.html deleted 100644 → 0
View file @ 83fb71af
<!DOCTYPE html>
<script>
console.log('portal-2');
window.onportalactivate = e => {
document.body.appendChild(e.adoptPredecessor());
}
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment