Commit efe84291 authored by Phillis Tang's avatar Phillis Tang Committed by Chromium LUCI CQ

DPWA: do no show in-product help for fullscreen

When in fullscreen mode, In-Product Help for PWA install icon shouldn't
been seen because the install icon is not visible.

Bug: 1165467
Change-Id: Ia7a680d307b19672afcfad47bb658dc97c7c033e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626028
Commit-Queue: Phillis Tang <phillis@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843349}
parent 698ded3b
...@@ -92,7 +92,12 @@ void PwaInstallView::UpdateImpl() { ...@@ -92,7 +92,12 @@ void PwaInstallView::UpdateImpl() {
else else
ResetSlideAnimation(false); ResetSlideAnimation(false);
if (is_probably_promotable && ShouldShowIph(web_contents, manager)) { SetVisible(is_probably_promotable || PWAConfirmationBubbleView::IsShowing());
// Only try to show IPH when |PwaInstallView.IsDrawn|. This catches the case
// that view is set to visible but not drawn in fullscreen mode.
if (is_probably_promotable && ShouldShowIph(web_contents, manager) &&
IsDrawn()) {
FeaturePromoControllerViews* controller = FeaturePromoControllerViews* controller =
FeaturePromoControllerViews::GetForView(this); FeaturePromoControllerViews::GetForView(this);
if (controller) { if (controller) {
...@@ -109,7 +114,6 @@ void PwaInstallView::UpdateImpl() { ...@@ -109,7 +114,6 @@ void PwaInstallView::UpdateImpl() {
SetHighlighted(true); SetHighlighted(true);
} }
} }
SetVisible(is_probably_promotable || PWAConfirmationBubbleView::IsShowing());
} }
void PwaInstallView::OnIphClosed() { void PwaInstallView::OnIphClosed() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment