Reland "Send GSB before switching to mainthread scrolling in smooth scroll path."
This reverts commit 0a6d8978. Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged. Original change's description: > Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." > > This reverts commit 5d5a062f. > > Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 > > bug: 822386 > > Original change's description: > > Send GSB before switching to mainthread scrolling in smooth scroll path. > > > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > > GSB was handled on the compositor rather than being sent to the main thread. > > > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > > in this cl I've moved the test to a new virtual test suite that has default scroll animation > > value. > > > > I have removed the test expectations since I have changed the test and this might fix the flake. > > > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > > a new test suite. > > > > Bug: 820979, 708499, 757165, 800840 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > > Reviewed-on: https://chromium-review.googlesource.com/961264 > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543425} > > TBR=tdresser@chromium.org,sahel@chromium.org > > Change-Id: I3c5253d96d011c9723063effac91c969ee352305 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/963388 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543467} TBR=tdresser@chromium.org,crouleau@chromium.org Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/964809 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543498}
Showing
Please register or sign in to comment