Vaapi: Activate |decode_using_client_picture_buffers_| for h264

This CL cleans up and activates |decode_using_client_picture_buffers_|
after recent power consumption measurements done by the Intel folks
reveal that there should be no regression, and also because skipping
the Vpp has a huge impact in memory consumption since Va doesn't need
to allocate ~13/14 Buffer Objects inside (see crbug.com/909926).

Bug: 909926, 822346
Change-Id: Ie8d6b41521f5d8ee62568f9674ae071a67c290bf
Reviewed-on: https://chromium-review.googlesource.com/c/1356019Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612498}

media/gpu/vaapi/vaapi_video_decode_accelerator.cc

@@ -92,6 +92,16 @@ bool IsGeminiLakeOrLater() {
       cpuid.model() >= kGeminiLakeModelId;
   return is_geminilake_or_later;
 }
+
+// Decides if the current platform and profile may decode using the client's
+// PictureBuffers, or engage the Vpp to adapt VaApi's and the client's format.
+bool ShouldDecodeOnclientPictureBuffers(bool has_va_surface_ids,
+                                        VideoCodecProfile profile) {
+  return has_va_surface_ids && (IsKabyLakeOrLater() || IsGeminiLakeOrLater()) &&
+         (profile == VP9PROFILE_PROFILE0 ||
+          (profile >= H264PROFILE_BASELINE && profile <= H264PROFILE_HIGH));
+}
+
 }  // namespace
 
 #define RETURN_AND_NOTIFY_ON_FAILURE(result, log, error_code, ret) \
@@ -631,9 +641,7 @@ void VaapiVideoDecodeAccelerator::AssignPictureBuffers(
   }
 
   decode_using_client_picture_buffers_ =
-      !va_surface_ids.empty() &&
-      (IsKabyLakeOrLater() || IsGeminiLakeOrLater()) &&
-      profile_ == VP9PROFILE_PROFILE0;
+      ShouldDecodeOnclientPictureBuffers(!va_surface_ids.empty(), profile_);
 
   // If we have some |va_surface_ids|, use them for decode, otherwise ask
   // |vaapi_wrapper_| to allocate them for us.