Commit f1054dc5 authored by Mark Pearson's avatar Mark Pearson Committed by Commit Bot

Revert "Cookie Store API: Remove flaky test expectations."

This reverts commit c0c5f227.

[Sheriff here:]

Reason for revert:
Failing on Windows bots:
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64
(sometimes in different ways)

One failure example:
https://test-results.appspot.com/data/layout_results/Win7_Tests__1_/93239/webkit_layout_tests/layout-test-results/results.html
---
This is a testharness.js-based test.
PASS document.cookie set/overwrite/delete observed by CookieStore
PASS CookieStore set/overwrite/delete observed by document.cookie
FAIL CookieStore agrees with document.cookie on encoding non-ASCII cookies assert_equals: Empty cookie jar after document.cookie cookie-clearing using max-age=0 expected (undefined) undefined but got (string) "DOCUMENT-🍪=DELETED"
PASS document.cookie agrees with CookieStore on encoding non-ASCII cookies
Harness: the test ran to completion.
---

Different failure example:
https://test-results.appspot.com/data/layout_results/Win10_Tests_x64/38274/webkit_layout_tests/layout-test-results/results.html
---
This is a testharness.js-based test.
FAIL document.cookie set/overwrite/delete observed by CookieStore assert_equals: Empty cookie jar after document.cookie cookie-clearing using max-age=0 expected (undefined) undefined but got (string) "DOCUMENT-cookie=DELETED"
PASS CookieStore set/overwrite/delete observed by document.cookie
PASS CookieStore agrees with document.cookie on encoding non-ASCII cookies
PASS document.cookie agrees with CookieStore on encoding non-ASCII cookies
Harness: the test ran to completion.
---

I'm not positive whether the re-enabling the test was appropriate and then regressed with another change later in the day.  I tried to investigate that theory and it became too much of a pain.  The best thing is to disable the failing test and move on, trusting you fellow engineers to figure out the root cause.




Original change's description:
> Cookie Store API: Remove flaky test expectations.
> 
> We expect https://crrev.com/c/1635430 to have fixed the flakiness and
> manually confirmed that the test now passes across 100 repeated runs.
> 
> Bug: 827231
> Change-Id: I4599671cf6db1192847585ba2789995b377d23aa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696449
> Commit-Queue: Staphany Park <staphany@chromium.org>
> Auto-Submit: Staphany Park <staphany@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#676343}

TBR=pwnall@chromium.org,staphany@chromium.org

Change-Id: I1402728a7df3635f72d29fa3cd86a619888248a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699441Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676631}
parent bb542055
......@@ -5169,6 +5169,10 @@ crbug.com/783800 external/wpt/imagecapture/MediaStreamTrack-applyConstraints-get
crbug.com/783301 external/wpt/imagecapture/MediaStreamTrack-getSettings.html [ Pass Failure ]
crbug.com/783301 external/wpt/imagecapture/MediaStreamTrack-getCapabilities.html [ Pass Failure ]
# Cookie Store API
crbug.com/827231 external/wpt/cookie-store/document_cookie.tentative.html [ Pass Failure ]
crbug.com/827231 external/wpt/cookie-store/document_cookie.tentative.https.html [ Pass Failure ]
# Failing SameSite cookies tests
crbug.com/843945 external/wpt/cookies/samesite/form-get-blank-reload.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/form-post-blank-reload.html [ Failure ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment