Commit f130a849 authored by Chong Zhang's avatar Chong Zhang Committed by Commit Bot

Remoave trace 'Navigation timeToNetworkStack'

The trace is already broken and doesn't seem to be used. See bug for
more details.

Bug: 880129
Change-Id: I822f24c2367a1acb76c1eeddade6b2ceefd1355a
Reviewed-on: https://chromium-review.googlesource.com/1216083Reviewed-by: default avatarCamille Lamy <clamy@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590429}
parent 3b1bbf54
...@@ -1238,12 +1238,6 @@ bool NavigationRequest::ShouldKeepErrorPageInCurrentProcess(int net_error) { ...@@ -1238,12 +1238,6 @@ bool NavigationRequest::ShouldKeepErrorPageInCurrentProcess(int net_error) {
} }
void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) { void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {
if (frame_tree_node_->IsMainFrame()) {
TRACE_EVENT_ASYNC_END_WITH_TIMESTAMP0(
"navigation", "Navigation timeToNetworkStack", navigation_handle_.get(),
timestamp);
}
frame_tree_node_->navigator()->LogResourceRequestTime(timestamp, frame_tree_node_->navigator()->LogResourceRequestTime(timestamp,
common_params_.url); common_params_.url);
} }
......
...@@ -398,19 +398,6 @@ void NavigatorImpl::Navigate(std::unique_ptr<NavigationRequest> request, ...@@ -398,19 +398,6 @@ void NavigatorImpl::Navigate(std::unique_ptr<NavigationRequest> request,
// after this point without null checking it first. // after this point without null checking it first.
} }
if (frame_tree_node->IsMainFrame() && frame_tree_node->navigation_request()) {
// For the trace below we're using the navigation handle as the async
// trace id, |navigation_start| as the timestamp and reporting the
// FrameTreeNode id as a parameter. For navigations where no network
// request is made (data URLs, JavaScript URLs, etc) there is no handle
// and so no tracing is done.
TRACE_EVENT_ASYNC_BEGIN_WITH_TIMESTAMP1(
"navigation", "Navigation timeToNetworkStack",
frame_tree_node->navigation_request()->navigation_handle(),
frame_tree_node->navigation_request()->common_params().navigation_start,
"FrameTreeNode id", frame_tree_node->frame_tree_node_id());
}
// Make sure no code called via RFH::Navigate clears the pending entry. // Make sure no code called via RFH::Navigate clears the pending entry.
if (is_pending_entry) if (is_pending_entry)
CHECK_EQ(nav_entry_id, controller_->GetPendingEntry()->GetUniqueID()); CHECK_EQ(nav_entry_id, controller_->GetPendingEntry()->GetUniqueID());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment