Commit f1709320 authored by Peng Huang's avatar Peng Huang Committed by Commit Bot

ExternalVkImageBacking: fix a leaking of VkSemaphores

Bug: None
Change-Id: I4df510cd17acf64bd45fef658da20c0df6e7aae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321770
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792239}
parent ac2f30d3
...@@ -156,12 +156,12 @@ sk_sp<SkPromiseImageTexture> ExternalVkImageSkiaRepresentation::BeginAccess( ...@@ -156,12 +156,12 @@ sk_sp<SkPromiseImageTexture> ExternalVkImageSkiaRepresentation::BeginAccess(
} }
for (auto& external_semaphore : begin_access_semaphores_) { for (auto& external_semaphore : begin_access_semaphores_) {
DCHECK(external_semaphore.is_valid()); DCHECK(external_semaphore);
VkSemaphore semaphore = external_semaphore.TakeVkSemaphore(); VkSemaphore semaphore = external_semaphore.TakeVkSemaphore();
DCHECK(semaphore != VK_NULL_HANDLE); DCHECK(semaphore != VK_NULL_HANDLE);
// The ownership of semaphore is passed to caller. // The ownership of semaphore is passed to caller.
begin_semaphores->emplace_back(); begin_semaphores->emplace_back();
begin_semaphores->back().initVulkan(external_semaphore.TakeVkSemaphore()); begin_semaphores->back().initVulkan(semaphore);
} }
if (backing_impl()->need_synchronization()) { if (backing_impl()->need_synchronization()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment