Making it (almost) possible to gn check blink/public/*

Mostly it's about marking includes inside INSIDE_BLINK as // nogncheck Also some added dependencies on for instance //media to cover an include of "media/base/video_rotation.h" and on various mojo headers. There are five errors left which look like real layer violations. Bug: 800764 Change-Id: Ie63283def2dadc6c0b5933175551e9addb9da5ec Reviewed-on: https://chromium-review.googlesource.com/c/1299142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603072}

Making it (almost) possible to gn check blink/public/*
Mostly it's about marking includes inside INSIDE_BLINK as // nogncheck Also some added dependencies on for instance //media to cover an include of "media/base/video_rotation.h" and on various mojo headers. There are five errors left which look like real layer violations. Bug: 800764 Change-Id: Ie63283def2dadc6c0b5933175551e9addb9da5ec Reviewed-on: https://chromium-review.googlesource.com/c/1299142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603072}
f2a1d026 · Daniel Bratell · Commit Bot · 2ba0fb79 · f2a1d026 · f2a1d026
Commit f2a1d026 authored Oct 26, 2018 by Daniel Bratell Committed by Commit Bot Oct 26, 2018
30 changed files
--- a/third_party/blink/common/BUILD.gn
+++ b/third_party/blink/common/BUILD.gn
@@ -66,6 +66,10 @@ jumbo_source_set("common") {
  public_deps = [
    "//third_party/blink/public/common:headers",
  ]
+  allow_circular_includes_from = [
+    # It's using common_export.h creating a circular dependency.
+    "//third_party/blink/public/common:headers",
+  ]

  deps = [
    "//base",

--- a/third_party/blink/public/BUILD.gn
+++ b/third_party/blink/public/BUILD.gn
@@ -104,6 +104,7 @@ source_set("test_headers") {
    "platform/scheduler/test/renderer_scheduler_test_support.h",
  ]
  deps = [
+    ":blink_headers",
    "//base:base",
    "//cc:cc",
    "//testing/gmock:gmock",
@@ -540,6 +541,7 @@ source_set("blink_headers") {

  deps = [
    ":generate_mojo_bindings",
+    ":mojo_bindings_blink_headers",
    "//base:base",
    "//cc:cc",
    "//cc/paint:paint",

--- a/third_party/blink/public/common/BUILD.gn
+++ b/third_party/blink/public/common/BUILD.gn
@@ -90,7 +90,9 @@ source_set("headers") {

  deps = [
    "//base",
+    "//mojo/public/cpp/bindings",
    "//mojo/public/cpp/system",
+    "//mojo/public/mojom/base",
    "//net",
  ]


--- a/third_party/blink/public/platform/file_path_conversion.h
+++ b/third_party/blink/public/platform/file_path_conversion.h
@@ -8,7 +8,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/wtf/forward.h"
+#include "third_party/blink/renderer/platform/wtf/forward.h"  // nogncheck
 #endif

 namespace base {

--- a/third_party/blink/public/platform/interface_registry.h
+++ b/third_party/blink/public/platform/interface_registry.h
@@ -14,8 +14,8 @@
 #if INSIDE_BLINK
 #include "mojo/public/cpp/bindings/associated_interface_request.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
-#include "third_party/blink/renderer/platform/cross_thread_functional.h"
-#include "third_party/blink/renderer/platform/wtf/functional.h"
+#include "third_party/blink/renderer/platform/cross_thread_functional.h"  // nogncheck
+#include "third_party/blink/renderer/platform/wtf/functional.h"  // nogncheck
 #endif

 namespace base {

--- a/third_party/blink/public/platform/modules/service_worker/web_service_worker_request.h
+++ b/third_party/blink/public/platform/modules/service_worker/web_service_worker_request.h
@@ -18,10 +18,10 @@
 #if INSIDE_BLINK
 #include <utility>
 #include "third_party/blink/public/mojom/blob/blob.mojom-blink.h"  // nogncheck
-#include "third_party/blink/renderer/platform/network/http_header_map.h"
-#include "third_party/blink/renderer/platform/weborigin/referrer.h"
-#include "third_party/blink/renderer/platform/wtf/forward.h"
-#include "third_party/blink/renderer/platform/wtf/text/string_hash.h"
+#include "third_party/blink/renderer/platform/network/http_header_map.h"  // nogncheck
+#include "third_party/blink/renderer/platform/weborigin/referrer.h"  // nogncheck
+#include "third_party/blink/renderer/platform/wtf/forward.h"  // nogncheck
+#include "third_party/blink/renderer/platform/wtf/text/string_hash.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/modules/service_worker/web_service_worker_response.h
+++ b/third_party/blink/public/platform/modules/service_worker/web_service_worker_response.h
@@ -17,9 +17,9 @@
 #include "third_party/blink/public/platform/web_vector.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/wtf/forward.h"
-#include "third_party/blink/renderer/platform/wtf/hash_map.h"
-#include "third_party/blink/renderer/platform/wtf/text/string_hash.h"
+#include "third_party/blink/renderer/platform/wtf/forward.h"   // nogncheck
+#include "third_party/blink/renderer/platform/wtf/hash_map.h"  // nogncheck
+#include "third_party/blink/renderer/platform/wtf/text/string_hash.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_crypto.h
+++ b/third_party/blink/public/platform/web_crypto.h
@@ -43,7 +43,7 @@

 #if INSIDE_BLINK
 #include "base/memory/scoped_refptr.h"
-#include "third_party/blink/renderer/platform/heap/handle.h"
+#include "third_party/blink/renderer/platform/heap/handle.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_crypto_key_algorithm_params.h
+++ b/third_party/blink/public/platform/web_crypto_key_algorithm_params.h
@@ -36,7 +36,7 @@
 #include "third_party/blink/public/platform/web_vector.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/heap/handle.h"
+#include "third_party/blink/renderer/platform/heap/handle.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_double_point.h
+++ b/third_party/blink/public/platform/web_double_point.h
@@ -34,7 +34,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/double_point.h"
+#include "third_party/blink/renderer/platform/geometry/double_point.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_double_size.h
+++ b/third_party/blink/public/platform/web_double_size.h
@@ -8,7 +8,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/double_size.h"
+#include "third_party/blink/renderer/platform/geometry/double_size.h"  // nogncheck
 #else
 #include <ui/gfx/geometry/size_f.h>
 #include <ui/gfx/geometry/vector2d_f.h>

--- a/third_party/blink/public/platform/web_float_point.h
+++ b/third_party/blink/public/platform/web_float_point.h
@@ -34,7 +34,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/float_point.h"
+#include "third_party/blink/renderer/platform/geometry/float_point.h"  // nogncheck
 #else
 #include <ui/gfx/geometry/point_f.h>
 #endif

--- a/third_party/blink/public/platform/web_float_point_3d.h
+++ b/third_party/blink/public/platform/web_float_point_3d.h
@@ -8,7 +8,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/float_point_3d.h"
+#include "third_party/blink/renderer/platform/geometry/float_point_3d.h"  // nogncheck
 #else
 #include <ui/gfx/geometry/point3_f.h>
 #endif

--- a/third_party/blink/public/platform/web_float_rect.h
+++ b/third_party/blink/public/platform/web_float_rect.h
@@ -34,7 +34,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/float_rect.h"
+#include "third_party/blink/renderer/platform/geometry/float_rect.h"  // nogncheck
 #else
 #include <algorithm>
 #include <cmath>

--- a/third_party/blink/public/platform/web_float_size.h
+++ b/third_party/blink/public/platform/web_float_size.h
@@ -34,7 +34,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/float_size.h"
+#include "third_party/blink/renderer/platform/geometry/float_size.h"  // nogncheck
 #else
 #include <ui/gfx/geometry/size_f.h>
 #include <ui/gfx/geometry/vector2d_f.h>

--- a/third_party/blink/public/platform/web_media_stream_source.h
+++ b/third_party/blink/public/platform/web_media_stream_source.h
@@ -37,7 +37,7 @@

 #include "third_party/blink/public/platform/web_private_ptr.h"
 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/heap/handle.h"
+#include "third_party/blink/renderer/platform/heap/handle.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_point.h
+++ b/third_party/blink/public/platform/web_point.h
@@ -35,7 +35,7 @@
 #include "ui/gfx/geometry/point.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/int_point.h"
+#include "third_party/blink/renderer/platform/geometry/int_point.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_private_ptr.h
+++ b/third_party/blink/public/platform/web_private_ptr.h
@@ -36,9 +36,9 @@

 #if INSIDE_BLINK
 #include "base/memory/scoped_refptr.h"
-#include "third_party/blink/renderer/platform/heap/handle.h"
-#include "third_party/blink/renderer/platform/heap/persistent.h"
-#include "third_party/blink/renderer/platform/wtf/type_traits.h"
+#include "third_party/blink/renderer/platform/heap/handle.h"      // nogncheck
+#include "third_party/blink/renderer/platform/heap/persistent.h"  // nogncheck
+#include "third_party/blink/renderer/platform/wtf/type_traits.h"  // nogncheck
 #endif

 namespace WTF {

--- a/third_party/blink/public/platform/web_rect.h
+++ b/third_party/blink/public/platform/web_rect.h
@@ -35,7 +35,7 @@
 #include "ui/gfx/geometry/rect.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/int_rect.h"
+#include "third_party/blink/renderer/platform/geometry/int_rect.h"  // nogncheck
 #else
 #include <algorithm>
 #include <cmath>

--- a/third_party/blink/public/platform/web_scroll_into_view_params.h
+++ b/third_party/blink/public/platform/web_scroll_into_view_params.h
@@ -9,8 +9,8 @@
 #include "third_party/blink/public/platform/web_float_rect.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/scroll/scroll_alignment.h"
-#include "third_party/blink/renderer/platform/scroll/scroll_types.h"
+#include "third_party/blink/renderer/platform/scroll/scroll_alignment.h"  // nogncheck
+#include "third_party/blink/renderer/platform/scroll/scroll_types.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/platform/web_size.h
+++ b/third_party/blink/public/platform/web_size.h
@@ -36,7 +36,7 @@
 #include "ui/gfx/geometry/vector2d.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/geometry/int_size.h"
+#include "third_party/blink/renderer/platform/geometry/int_size.h"  // nogncheck
 #else
 #include <algorithm>
 #include <cmath>

--- a/third_party/blink/public/platform/web_string.h
+++ b/third_party/blink/public/platform/web_string.h
@@ -40,7 +40,7 @@
 #include "third_party/blink/public/platform/web_common.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/wtf/forward.h"
+#include "third_party/blink/renderer/platform/wtf/forward.h"  // nogncheck
 #endif

 namespace WTF {

--- a/third_party/blink/public/web/web_dom_message_event.h
+++ b/third_party/blink/public/web/web_dom_message_event.h
@@ -38,7 +38,7 @@
 #include "third_party/blink/public/web/web_serialized_script_value.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/core/events/message_event.h"
+#include "third_party/blink/renderer/core/events/message_event.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/web/web_element_collection.h
+++ b/third_party/blink/public/web/web_element_collection.h
@@ -36,7 +36,7 @@
 #include "third_party/blink/public/platform/web_private_ptr.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/heap/handle.h"
+#include "third_party/blink/renderer/platform/heap/handle.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/web/web_frame_owner_properties.h
+++ b/third_party/blink/public/web/web_frame_owner_properties.h
@@ -8,7 +8,7 @@
 #include "third_party/blink/public/platform/web_string.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/scroll/scroll_types.h"
+#include "third_party/blink/renderer/platform/scroll/scroll_types.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/web/web_icon_url.h
+++ b/third_party/blink/public/web/web_icon_url.h
@@ -32,7 +32,7 @@
 #define THIRD_PARTY_BLINK_PUBLIC_WEB_WEB_ICON_URL_H_

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/core/dom/icon_url.h"
+#include "third_party/blink/renderer/core/dom/icon_url.h"  // nogncheck
 #endif
 #include "third_party/blink/public/platform/web_size.h"
 #include "third_party/blink/public/platform/web_url.h"

--- a/third_party/blink/public/web/web_performance.h
+++ b/third_party/blink/public/web/web_performance.h
@@ -36,7 +36,7 @@
 #include "third_party/blink/public/web/web_navigation_type.h"

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/heap/handle.h"
+#include "third_party/blink/renderer/platform/heap/handle.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/web/web_range.h
+++ b/third_party/blink/public/web/web_range.h
@@ -33,7 +33,7 @@

 #include "third_party/blink/public/platform/web_common.h"
 #if INSIDE_BLINK
-#include "third_party/blink/renderer/core/editing/forward.h"
+#include "third_party/blink/renderer/core/editing/forward.h"  // nogncheck
 #endif

 namespace blink {

--- a/third_party/blink/public/web/web_surrounding_text.h
+++ b/third_party/blink/public/web/web_surrounding_text.h
@@ -26,7 +26,7 @@
 #define THIRD_PARTY_BLINK_PUBLIC_WEB_WEB_SURROUNDING_TEXT_H_

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/core/editing/forward.h"
+#include "third_party/blink/renderer/core/editing/forward.h"  // nogncheck
 #endif
 #include "third_party/blink/public/platform/web_string.h"


--- a/third_party/blink/public/web/web_text_direction.h
+++ b/third_party/blink/public/web/web_text_direction.h
@@ -32,7 +32,7 @@
 #define THIRD_PARTY_BLINK_PUBLIC_WEB_WEB_TEXT_DIRECTION_H_

 #if INSIDE_BLINK
-#include "third_party/blink/renderer/platform/text/text_direction.h"
+#include "third_party/blink/renderer/platform/text/text_direction.h"  // nogncheck
 #endif

 namespace blink {