Commit f346c65c authored by Juan Antonio Navarro Perez's avatar Juan Antonio Navarro Perez Committed by Commit Bot

[perf/contrib] Fix option validation in loading_ct benchmarks

Running the command, e.g.:

$ tools/perf/run_benchmark loading.cluster_telemetry --browser stable

Used to fail with an exception. Now instead prints a more user friendly
error message:

    Usage: run_benchmark run benchmark_name [<options>]

    run_benchmark: error: Please specify --user-agent.

Bug: 1009012
Change-Id: Id3b3ba521f3aa10b98a8e7a6aeae52c6f5cd8e5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872103
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: default avatarRavi Mistry <rmistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708181}
parent c6c4cbaf
...@@ -36,6 +36,10 @@ class _LoadingBaseClusterTelemetry(loading._LoadingBase): ...@@ -36,6 +36,10 @@ class _LoadingBaseClusterTelemetry(loading._LoadingBase):
help='Cache temperature (string). Default to "%%default". Can be: %s' % help='Cache temperature (string). Default to "%%default". Can be: %s' %
', '.join(cls._ALL_CACHE_TEMPERATURES)) ', '.join(cls._ALL_CACHE_TEMPERATURES))
@classmethod
def ProcessCommandLineArgs(cls, parser, args):
ct_benchmarks_util.ValidateCommandLineArgs(parser, args)
def CreateStorySet(self, options): def CreateStorySet(self, options):
def Wait(action_runner): def Wait(action_runner):
action_runner.Wait(options.wait_time) action_runner.Wait(options.wait_time)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment