Remove unnecessary ime_list_ in InputMethodManagerImpl unit tests.

Bug: 1134465
Change-Id: I32cb2d5d67e6bd102f17578d824028527d1c9bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551869
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831202}

chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

@@ -138,11 +138,12 @@ class InputMethodManagerImplTest :  public BrowserWithTestWindowTest {
   void SetUp() override {
     ui::InitializeInputMethodForTesting();
 
-    InitImeList();
+    std::vector<ComponentExtensionIME> ime_list;
+    InitImeList(ime_list);
 
     auto mock_delegate =
         std::make_unique<MockComponentExtensionIMEManagerDelegate>();
-    mock_delegate->set_ime_list(ime_list_);
+    mock_delegate->set_ime_list(ime_list);
 
     manager_ = std::make_unique<InputMethodManagerImpl>(
         std::make_unique<FakeInputMethodDelegate>(), std::move(mock_delegate),
@@ -191,8 +192,9 @@ class InputMethodManagerImplTest :  public BrowserWithTestWindowTest {
     manager_.reset();
   }
 
-  void InitImeList() {
-    ime_list_.clear();
+ private:
+  static void InitImeList(std::vector<ComponentExtensionIME>& ime_list) {
+    ime_list.clear();
 
     ComponentExtensionIME ext_xkb;
     ext_xkb.id = extension_ime_util::kXkbExtensionId;
@@ -290,7 +292,7 @@ class InputMethodManagerImplTest :  public BrowserWithTestWindowTest {
     ext_xkb_engine_hu.layouts.emplace_back("hu");
     ext_xkb.engines.push_back(ext_xkb_engine_hu);
 
-    ime_list_.push_back(ext_xkb);
+    ime_list.push_back(ext_xkb);
 
     ComponentExtensionIME ext1;
     ext1.id = extension_ime_util::kMozcExtensionId;
@@ -311,7 +313,7 @@ class InputMethodManagerImplTest :  public BrowserWithTestWindowTest {
     ext1_engine2.layouts.emplace_back("jp");
     ext1.engines.push_back(ext1_engine2);
 
-    ime_list_.push_back(ext1);
+    ime_list.push_back(ext1);
 
     ComponentExtensionIME ext2;
     ext2.id = extension_ime_util::kT13nExtensionId;
@@ -332,7 +334,7 @@ class InputMethodManagerImplTest :  public BrowserWithTestWindowTest {
     ext2_engine2.layouts.emplace_back("us(dvorak)");
     ext2.engines.push_back(ext2_engine2);
 
-    ime_list_.push_back(ext2);
+    ime_list.push_back(ext2);
   }
 
  protected:
@@ -342,7 +344,6 @@ class InputMethodManagerImplTest :  public BrowserWithTestWindowTest {
   MockCandidateWindowController* candidate_window_controller_ = nullptr;
   std::unique_ptr<MockInputMethodEngine> mock_engine_handler_;
   FakeImeKeyboard* keyboard_ = nullptr;
-  std::vector<ComponentExtensionIME> ime_list_;
   ui::ime::InputMethodMenuManager* menu_manager_;
 
  private:
@@ -1181,8 +1182,7 @@ TEST_F(InputMethodManagerImplTest, TestAddExtensionInputThenLockScreen) {
 
 TEST_F(InputMethodManagerImplTest, ChangeInputMethodComponentExtensionOneIME) {
   const std::string ext_id = extension_ime_util::GetComponentInputMethodID(
-      ime_list_[1].id,
-      ime_list_[1].engines[0].engine_id);
+      extension_ime_util::kMozcExtensionId, "nacl_mozc_us");
   std::vector<std::string> ids;
   ids.push_back(ext_id);
   EXPECT_TRUE(manager_->GetActiveIMEState()->ReplaceEnabledInputMethods(ids));
@@ -1193,11 +1193,9 @@ TEST_F(InputMethodManagerImplTest, ChangeInputMethodComponentExtensionOneIME) {
 
 TEST_F(InputMethodManagerImplTest, ChangeInputMethodComponentExtensionTwoIME) {
   const std::string ext_id1 = extension_ime_util::GetComponentInputMethodID(
-      ime_list_[1].id,
-      ime_list_[1].engines[0].engine_id);
+      extension_ime_util::kMozcExtensionId, "nacl_mozc_us");
   const std::string ext_id2 = extension_ime_util::GetComponentInputMethodID(
-      ime_list_[2].id,
-      ime_list_[2].engines[0].engine_id);
+      extension_ime_util::kT13nExtensionId, kExt2Engine1Id);
   std::vector<std::string> ids;
   ids.push_back(ext_id1);
   ids.push_back(ext_id2);