Commit f4420fea authored by Tommy C. Li's avatar Tommy C. Li Committed by Commit Bot

Omnibox UI: Fix a missing Invalidate call for async suggestion favicons

Bug report suggests that we are not refreshing the favicons correctly
when they are delivered asynchronously.

This reproduces sporadically, so this CL is a semi-speculative fix.
That being said - there is indeed a missing Invalidate call, so this CL
has a good chance of fixing the bug.

Bug: 856218
Change-Id: I8a3c83053d765769e4f6a71bffcd947afaa9566e
Reviewed-on: https://chromium-review.googlesource.com/1114154Reviewed-by: default avatarDave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570192}
parent b30c811d
...@@ -183,7 +183,8 @@ OmniboxTint OmniboxResultView::GetTint() const { ...@@ -183,7 +183,8 @@ OmniboxTint OmniboxResultView::GetTint() const {
} }
void OmniboxResultView::OnMatchIconUpdated() { void OmniboxResultView::OnMatchIconUpdated() {
// The new icon will be fetched during repaint. // The new icon will be fetched during Invalidate().
Invalidate();
SchedulePaint(); SchedulePaint();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment