Commit f44f7dc2 authored by Sidney San Martín's avatar Sidney San Martín Committed by Commit Bot

Fix a crash on early releases of macOS 10.10.

So far, all instances of this missing selector crash linked in the bug have
come from 10.10.0, but my copy of 10.10 has it. This change checks
`respondsToSelector:`, instead of OS version, before calling SPI.

Bug: 856211
Change-Id: Ib2aa07e0e24b83f1766a2f6e16e19b2b123970a6
Reviewed-on: https://chromium-review.googlesource.com/1115781Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571123}
parent 74529e7d
......@@ -15,8 +15,10 @@
@interface NSWindow (PrivateAPI)
+ (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
- (void)beginWindowDragWithEvent:(NSEvent*)event
NS_DEPRECATED_MAC(10_10, 10_11, "Use performWindowDragWithEvent: instead.");
// Available in later point releases of 10.10. On 10.11+, use the public
// -performWindowDragWithEvent: instead.
- (void)beginWindowDragWithEvent:(NSEvent*)event;
@end
// Weak lets Chrome launch even if a future macOS doesn't have NSThemeFrame.
......@@ -82,7 +84,8 @@ WEAK_IMPORT_ATTRIBUTE
; // Not needed on 10.12 and up.
else if (@available(macOS 10.11, *))
[self.window performWindowDragWithEvent:event];
else if (@available(macOS 10.10, *))
else if ([self.window
respondsToSelector:@selector(beginWindowDragWithEvent:)])
[self.window beginWindowDragWithEvent:event];
else
NOTREACHED();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment