Commit f471e842 authored by Moe Ahmadi's avatar Moe Ahmadi Committed by Commit Bot

[AF] Unify Autofill settings strings on all platforms (part 1)

Takes Autofill Settings strings related to the new address and credit card
toggles to components/autofill_strings.grpd to share on all platforms.

Bug: 873215
Change-Id: I358455a33734650dceed1196385d5262efa5b90a
Reviewed-on: https://chromium-review.googlesource.com/1171560Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: default avatarMichael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582706}
parent f13747ae
...@@ -631,15 +631,6 @@ ...@@ -631,15 +631,6 @@
<message name="IDS_SETTINGS_AUTOFILL_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether forms should be autofilled with data such as addresses and credit cards, but not passwords."> <message name="IDS_SETTINGS_AUTOFILL_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether forms should be autofilled with data such as addresses and credit cards, but not passwords.">
Autofill forms Autofill forms
</message> </message>
<message name="IDS_SETTINGS_AUTOFILL_ENABLE_PROFILES_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether addresses should be saved and forms should be autofilled with them.">
Save and fill addresses
</message>
<message name="IDS_SETTINGS_AUTOFILL_ENABLE_CREDIT_CARDS_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether credit cards should be saved and forms should be autofilled with it.">
Save and fill payment methods
</message>
<message name="IDS_SETTINGS_AUTOFILL_ADDRESSES_HEADING" desc="Title for the list of addresses that chrome has saved for use in filling in forms.">
Addresses
</message>
<message name="IDS_SETTINGS_AUTOFILL_ADDRESSES_ADD_TITLE" desc="This is the title for the 'Add address' dialog. This dialog allows a user to create a new address."> <message name="IDS_SETTINGS_AUTOFILL_ADDRESSES_ADD_TITLE" desc="This is the title for the 'Add address' dialog. This dialog allows a user to create a new address.">
Add address Add address
</message> </message>
...@@ -663,9 +654,6 @@ ...@@ -663,9 +654,6 @@
<message name="IDS_SETTINGS_AUTOFILL_CREDIT_CARD_DETAIL" desc="Description of what toggling the 'Credit card' setting does. Immediately underneath IDS_SETTINGS_AUTOFILL_CREDIT_CARD_HEADING."> <message name="IDS_SETTINGS_AUTOFILL_CREDIT_CARD_DETAIL" desc="Description of what toggling the 'Credit card' setting does. Immediately underneath IDS_SETTINGS_AUTOFILL_CREDIT_CARD_HEADING.">
Enable credit card Autofill to fill out forms in a single click Enable credit card Autofill to fill out forms in a single click
</message> </message>
<message name="IDS_SETTINGS_AUTOFILL_PAYMENT_METHODS" desc="Title for the list of saved payment methods that can be used to fill in forms.">
Payment methods
</message>
<message name="IDS_SETTINGS_AUTOFILL_CREDIT_CARD_TYPE_COLUMN_LABEL" desc="Label for the column containing the type of credit card that is saved. The type is in the format: `Visa ****1234`."> <message name="IDS_SETTINGS_AUTOFILL_CREDIT_CARD_TYPE_COLUMN_LABEL" desc="Label for the column containing the type of credit card that is saved. The type is in the format: `Visa ****1234`.">
Type Type
</message> </message>
......
...@@ -1384,11 +1384,9 @@ void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) { ...@@ -1384,11 +1384,9 @@ void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) {
{"googlePayments", IDS_SETTINGS_GOOGLE_PAYMENTS}, {"googlePayments", IDS_SETTINGS_GOOGLE_PAYMENTS},
{"googlePaymentsCached", IDS_SETTINGS_GOOGLE_PAYMENTS_CACHED}, {"googlePaymentsCached", IDS_SETTINGS_GOOGLE_PAYMENTS_CACHED},
{"autofillFormsLabel", IDS_SETTINGS_AUTOFILL_TOGGLE_LABEL}, {"autofillFormsLabel", IDS_SETTINGS_AUTOFILL_TOGGLE_LABEL},
{"enableProfilesLabel", {"enableProfilesLabel", IDS_AUTOFILL_ENABLE_PROFILES_TOGGLE_LABEL},
IDS_SETTINGS_AUTOFILL_ENABLE_PROFILES_TOGGLE_LABEL}, {"enableCreditCardsLabel", IDS_AUTOFILL_ENABLE_CREDIT_CARDS_TOGGLE_LABEL},
{"enableCreditCardsLabel", {"addresses", IDS_AUTOFILL_ADDRESSES},
IDS_SETTINGS_AUTOFILL_ENABLE_CREDIT_CARDS_TOGGLE_LABEL},
{"addresses", IDS_SETTINGS_AUTOFILL_ADDRESSES_HEADING},
{"addAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_ADD_TITLE}, {"addAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_ADD_TITLE},
{"editAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_EDIT_TITLE}, {"editAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_EDIT_TITLE},
{"addressCountry", IDS_SETTINGS_AUTOFILL_ADDRESSES_COUNTRY}, {"addressCountry", IDS_SETTINGS_AUTOFILL_ADDRESSES_COUNTRY},
...@@ -1460,7 +1458,7 @@ void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) { ...@@ -1460,7 +1458,7 @@ void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) {
html_source->AddLocalizedString("passwords", html_source->AddLocalizedString("passwords",
IDS_SETTINGS_PASSWORDS_AUTOFILL_HOME); IDS_SETTINGS_PASSWORDS_AUTOFILL_HOME);
html_source->AddLocalizedString("creditCards", html_source->AddLocalizedString("creditCards",
IDS_SETTINGS_AUTOFILL_PAYMENT_METHODS); IDS_AUTOFILL_PAYMENT_METHODS);
html_source->AddLocalizedString("noCreditCardsFound", html_source->AddLocalizedString("noCreditCardsFound",
IDS_SETTINGS_PAYMENT_METHODS_NONE); IDS_SETTINGS_PAYMENT_METHODS_NONE);
} else { } else {
......
...@@ -444,6 +444,35 @@ ...@@ -444,6 +444,35 @@
No saved addresses No saved addresses
</message> </message>
<!-- Autofill settings -->
<message name="IDS_AUTOFILL_ADDRESSES" desc="Title for the list of addresses that chrome has saved for use in filling in forms.">
Addresses
</message>
<if expr="not is_ios">
<then>
<message name="IDS_AUTOFILL_PAYMENT_METHODS" desc="Title for the list of saved payment methods that can be used to fill in forms. Sentence-Cased.">
Payment methods
</message>
<message name="IDS_AUTOFILL_ENABLE_PROFILES_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether addresses should be saved and forms should be autofilled with them. Sentence-Cased.">
Save and fill addresses
</message>
<message name="IDS_AUTOFILL_ENABLE_CREDIT_CARDS_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether credit cards should be saved and forms should be autofilled with it. Sentence-Cased.">
Save and fill payment methods
</message>
</then>
<else>
<message name="IDS_AUTOFILL_PAYMENT_METHODS" desc="Title for the list of saved payment methods that can be used to fill in forms. Title-Cased.">
Payment Methods
</message>
<message name="IDS_AUTOFILL_ENABLE_PROFILES_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether addresses should be saved and forms should be autofilled with them. Title-Cased.">
Save and Fill Addresses
</message>
<message name="IDS_AUTOFILL_ENABLE_CREDIT_CARDS_TOGGLE_LABEL" desc="Label for a toggle that allows users to control whether credit cards should be saved and forms should be autofilled with it. Title-Cased.">
Save and Fill Payment Methods
</message>
</else>
</if>
<!-- Autofill/Wallet integration preferences --> <!-- Autofill/Wallet integration preferences -->
<if expr="not is_ios"> <if expr="not is_ios">
<then> <then>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment