Skip to content

GitLab

T
tangled
Commit f5d6a704 authored by mmenke's avatar mmenke Committed by Commit bot
Browse files
Options

Revert "Prevent chrome://net-internals/#export from flickering" 

This reverts commit b55be9ed.

This broke layout of the filter box in the events tab.

Reverted CL description:

The problem:

1. Initially all the tabs are visible
2. A layout happens
3. index.js is run and it sets all the tabs to display: none
This results in the flickering.

By initially giving div main-tab-contents the style display: none and
removing that in initTabs_() we can prevent the flickering.

BUG=466068
Committed: https://crrev.com/b55be9ede35c10a2623c3c348768db92069d7f10
Cr-Commit-Position: refs/heads/master@{#320264}

TBR=eroman@chromium.org, alexclarke1@chromium.org

Review URL: https://codereview.chromium.org/1019303002

Cr-Commit-Position: refs/heads/master@{#321364}
parent fde4fdf9
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 3 deletions
chrome/browser/resources/net_internals/index.html
View file @ f5d6a704
......@@ -26,7 +26,7 @@ found in the LICENSE file.
<body id=import-view-drop-target>
<include src="top_bar_view.html">
<div id=main-tab-contents style="display:none">
<div id=main-tab-contents>
<include src="proxy_view.html">
<include src="dns_view.html">
<include src="sockets_view.html">
......
chrome/browser/resources/net_internals/main.js
View file @ f5d6a704
......@@ -203,8 +203,6 @@ var MainView = (function() {
addTab(PrerenderView);
addTab(CrosView);
// To prevent flickering, main-tab-contents initially has display = none.
$('main-tab-contents').style.display = '';
this.tabSwitcher_.showMenuItem(CrosView.TAB_ID, cr.isChromeOS);
},
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment