Commit f5fefca2 authored by David Bertoni's avatar David Bertoni Committed by Commit Bot

[Extensions] Re-enable some Geolocation API tests.

These tests were disabled for flakiness many years ago.
They passed 3000 iterations on the bots without failures.

Bug: 68287, 128412
Change-Id: I4196dbd345aebbacbe3d378fd76a21990234b930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404406Reviewed-by: default avatarKelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807605}
parent b92e8e92
...@@ -13,6 +13,7 @@ class GeolocationApiTest : public extensions::ExtensionApiTest { ...@@ -13,6 +13,7 @@ class GeolocationApiTest : public extensions::ExtensionApiTest {
// InProcessBrowserTest // InProcessBrowserTest
void SetUpOnMainThread() override { void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
geolocation_overrider_ = geolocation_overrider_ =
std::make_unique<device::ScopedGeolocationOverrider>(0, 0); std::make_unique<device::ScopedGeolocationOverrider>(0, 0);
} }
...@@ -21,16 +22,12 @@ class GeolocationApiTest : public extensions::ExtensionApiTest { ...@@ -21,16 +22,12 @@ class GeolocationApiTest : public extensions::ExtensionApiTest {
std::unique_ptr<device::ScopedGeolocationOverrider> geolocation_overrider_; std::unique_ptr<device::ScopedGeolocationOverrider> geolocation_overrider_;
}; };
// http://crbug.com/68287 IN_PROC_BROWSER_TEST_F(GeolocationApiTest, ExtensionGeolocationAccessFail) {
IN_PROC_BROWSER_TEST_F(GeolocationApiTest,
DISABLED_ExtensionGeolocationAccessFail) {
// Test that geolocation cannot be accessed from extension without permission. // Test that geolocation cannot be accessed from extension without permission.
ASSERT_TRUE(RunExtensionTest("geolocation/no_permission")) << message_; ASSERT_TRUE(RunExtensionTest("geolocation/no_permission")) << message_;
} }
// Timing out. http://crbug.com/128412 IN_PROC_BROWSER_TEST_F(GeolocationApiTest, ExtensionGeolocationAccessPass) {
IN_PROC_BROWSER_TEST_F(GeolocationApiTest,
DISABLED_ExtensionGeolocationAccessPass) {
// Test that geolocation can be accessed from extension with permission. // Test that geolocation can be accessed from extension with permission.
ASSERT_TRUE(RunExtensionTest("geolocation/has_permission")) << message_; ASSERT_TRUE(RunExtensionTest("geolocation/has_permission")) << message_;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment