Commit f741cf06 authored by Jun Mukai's avatar Jun Mukai Committed by Commit Bot

fix BookmarkBarViewTest12 for SingleProcessMash

BookmarkBarViewTest12.CloseWithModalDialog is in timeout.
That's because DialogWaiter is observing for a wrong aura::Env
instance.

BUG=883523
TEST=interactive_ui_tests --enable-features=SingleProcessMash

Change-Id: Ia2b057763e87458a564dbffa25c6cc92889992a6
Reviewed-on: https://chromium-review.googlesource.com/1244125Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594149}
parent 60bd4b09
......@@ -76,13 +76,9 @@ namespace {
class DialogWaiter : public aura::EnvObserver,
public views::WidgetObserver {
public:
DialogWaiter()
: dialog_created_(false),
dialog_(NULL) {
aura::Env::GetInstance()->AddObserver(this);
}
explicit DialogWaiter(aura::Env* env) : env_(env) { env_->AddObserver(this); }
~DialogWaiter() override { aura::Env::GetInstance()->RemoveObserver(this); }
~DialogWaiter() override { env_->RemoveObserver(this); }
views::Widget* WaitForDialog() {
if (dialog_created_)
......@@ -116,8 +112,9 @@ class DialogWaiter : public aura::EnvObserver,
}
}
bool dialog_created_;
views::Widget* dialog_;
aura::Env* env_;
bool dialog_created_ = false;
views::Widget* dialog_ = nullptr;
base::Closure quit_closure_;
DISALLOW_COPY_AND_ASSIGN(DialogWaiter);
......@@ -1340,7 +1337,8 @@ class BookmarkBarViewTest12 : public BookmarkBarViewEventTestBase {
ASSERT_TRUE(child_menu != NULL);
// Click and wait until the dialog box appears.
std::unique_ptr<DialogWaiter> dialog_waiter(new DialogWaiter());
auto dialog_waiter = std::make_unique<DialogWaiter>(
bb_view_->GetWidget()->GetNativeWindow()->env());
ui_test_utils::MoveMouseToCenterAndPress(
child_menu, ui_controls::LEFT, ui_controls::DOWN | ui_controls::UP,
base::Bind(&BookmarkBarViewTest12::Step4, base::Unretained(this),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment