Commit f7ecb5e7 authored by Kyle Horimoto's avatar Kyle Horimoto Committed by Commit Bot

[CrOS Settings] Move UserActionRecorder to user_action_recorder.mojom.

Previously, it was part of search.mojom, but this was confusing since
it's not fully related to search. Actual search functionality is added
in follow-up CL
https://chromium-review.googlesource.com/c/chromium/src/+/2103523/.

Bug: 1059099
Change-Id: I1bb14f678a56aef6025bb53485f9e72021557b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109236Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Reviewed-by: default avatardpapad <dpapad@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751640}
parent bbd26c17
...@@ -444,7 +444,7 @@ ...@@ -444,7 +444,7 @@
<include name="IDR_ADD_SUPERVISION_MOJOM_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\chromeos\add_supervision\add_supervision.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" /> <include name="IDR_ADD_SUPERVISION_MOJOM_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\chromeos\add_supervision\add_supervision.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" />
</if> </if>
<if expr="chromeos"> <if expr="chromeos">
<include name="IDR_OS_SETTINGS_SEARCH_MOJOM_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\settings\chromeos\search\search.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" /> <include name="IDR_OS_SETTINGS_USER_ACTION_RECORDER_MOJOM_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\settings\chromeos\search\user_action_recorder.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" />
</if> </if>
<if expr="chromeos"> <if expr="chromeos">
<!-- OOBE / Login resources --> <!-- OOBE / Login resources -->
......
...@@ -127,7 +127,7 @@ ...@@ -127,7 +127,7 @@
#include "chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.h" #include "chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.h"
#include "chrome/browser/ui/webui/chromeos/network_ui.h" #include "chrome/browser/ui/webui/chromeos/network_ui.h"
#include "chrome/browser/ui/webui/settings/chromeos/os_settings_ui.h" #include "chrome/browser/ui/webui/settings/chromeos/os_settings_ui.h"
#include "chrome/browser/ui/webui/settings/chromeos/search/search.mojom.h" #include "chrome/browser/ui/webui/settings/chromeos/search/user_action_recorder.mojom.h"
#include "chromeos/components/help_app_ui/help_app_ui.h" #include "chromeos/components/help_app_ui/help_app_ui.h"
#include "chromeos/components/help_app_ui/help_app_ui.mojom.h" #include "chromeos/components/help_app_ui/help_app_ui.mojom.h"
#include "chromeos/components/media_app_ui/media_app_ui.h" #include "chromeos/components/media_app_ui/media_app_ui.h"
......
...@@ -37,7 +37,7 @@ if (optimize_webui) { ...@@ -37,7 +37,7 @@ if (optimize_webui) {
"chrome://os-settings/app-management/image_info.mojom-lite.js", "chrome://os-settings/app-management/image_info.mojom-lite.js",
"chrome://os-settings/app-management/image.mojom-lite.js", "chrome://os-settings/app-management/image.mojom-lite.js",
"chrome://os-settings/app-management/types.mojom-lite.js", "chrome://os-settings/app-management/types.mojom-lite.js",
"chrome://os-settings/search/search.mojom-lite.js", "chrome://os-settings/search/user_action_recorder.mojom-lite.js",
"chrome://resources/mojo/mojo/public/mojom/base/big_buffer.mojom.html", "chrome://resources/mojo/mojo/public/mojom/base/big_buffer.mojom.html",
"chrome://resources/mojo/mojo/public/mojom/base/time.mojom.html", "chrome://resources/mojo/mojo/public/mojom/base/time.mojom.html",
] ]
......
<link rel="import" href="chrome://resources/html/cr.html"> <link rel="import" href="chrome://resources/html/cr.html">
<link rel="import" href="chrome://resources/mojo/mojo/public/js/mojo_bindings_lite.html"> <link rel="import" href="chrome://resources/mojo/mojo/public/js/mojo_bindings_lite.html">
<script src="chrome://os-settings/search/search.mojom-lite.js"></script> <script src="chrome://os-settings/search/user_action_recorder.mojom-lite.js"></script>
<script src="metrics_recorder.js"></script> <script src="metrics_recorder.js"></script>
...@@ -221,8 +221,9 @@ OSSettingsUI::OSSettingsUI(content::WebUI* web_ui) ...@@ -221,8 +221,9 @@ OSSettingsUI::OSSettingsUI(content::WebUI* web_ui)
html_source->AddResourcePath("app-management/image_info.mojom-lite.js", html_source->AddResourcePath("app-management/image_info.mojom-lite.js",
IDR_APP_MANAGEMENT_IMAGE_INFO_MOJO_LITE_JS); IDR_APP_MANAGEMENT_IMAGE_INFO_MOJO_LITE_JS);
html_source->AddResourcePath("search/search.mojom-lite.js", html_source->AddResourcePath(
IDR_OS_SETTINGS_SEARCH_MOJOM_LITE_JS); "search/user_action_recorder.mojom-lite.js",
IDR_OS_SETTINGS_USER_ACTION_RECORDER_MOJOM_LITE_JS);
// AddOsLocalizedStrings must be added after AddBrowserLocalizedStrings // AddOsLocalizedStrings must be added after AddBrowserLocalizedStrings
// as repeated keys used by the OS strings should override the same keys // as repeated keys used by the OS strings should override the same keys
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "base/time/time.h" #include "base/time/time.h"
#include "chrome/browser/ui/webui/app_management/app_management.mojom-forward.h" #include "chrome/browser/ui/webui/app_management/app_management.mojom-forward.h"
#include "chrome/browser/ui/webui/settings/chromeos/app_management/app_management_page_handler_factory.h" #include "chrome/browser/ui/webui/settings/chromeos/app_management/app_management_page_handler_factory.h"
#include "chrome/browser/ui/webui/settings/chromeos/search/search.mojom-forward.h" #include "chrome/browser/ui/webui/settings/chromeos/search/user_action_recorder.mojom-forward.h"
#include "chrome/browser/ui/webui/webui_load_timer.h" #include "chrome/browser/ui/webui/webui_load_timer.h"
#include "chromeos/services/network_config/public/mojom/cros_network_config.mojom-forward.h" #include "chromeos/services/network_config/public/mojom/cros_network_config.mojom-forward.h"
#include "mojo/public/cpp/bindings/pending_receiver.h" #include "mojo/public/cpp/bindings/pending_receiver.h"
......
...@@ -8,7 +8,7 @@ assert(is_chromeos) ...@@ -8,7 +8,7 @@ assert(is_chromeos)
mojom("mojo_bindings") { mojom("mojo_bindings") {
sources = [ sources = [
"search.mojom",
"search_result_icon.mojom", "search_result_icon.mojom",
"user_action_recorder.mojom",
] ]
} }
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_SETTINGS_USER_ACTION_TRACKER_H_ #define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_SETTINGS_USER_ACTION_TRACKER_H_
#include "base/time/time.h" #include "base/time/time.h"
#include "chrome/browser/ui/webui/settings/chromeos/search/search.mojom.h" #include "chrome/browser/ui/webui/settings/chromeos/search/user_action_recorder.mojom.h"
#include "mojo/public/cpp/bindings/pending_receiver.h" #include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/receiver.h" #include "mojo/public/cpp/bindings/receiver.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment