Commit f7ee3ca8 authored by François Beaufort's avatar François Beaufort Committed by Commit Bot

[Picture-in-Picture] Add missing [NewObject] to methods in IDL.

Updated spec says IDL for requestPictureInPicture and
exitPictureInPicture should specify that a new object is returned.

https://github.com/WICG/picture-in-picture/pull/76

Bug: 806249
Change-Id: Iba50455ef30c97d87c3e22b9ac95bc4bc41d546d
Reviewed-on: https://chromium-review.googlesource.com/1122226Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#572257}
parent 0ec30308
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
partial interface Document { partial interface Document {
[Measure] readonly attribute boolean pictureInPictureEnabled; [Measure] readonly attribute boolean pictureInPictureEnabled;
[CallWith=ScriptState, Measure] Promise<void> exitPictureInPicture(); [CallWith=ScriptState, Measure, NewObject] Promise<void> exitPictureInPicture();
// TODO(crbug.com/656517): Define this attribute in DocumentOrShadowRoot. // TODO(crbug.com/656517): Define this attribute in DocumentOrShadowRoot.
[Measure] readonly attribute HTMLVideoElement? pictureInPictureElement; [Measure] readonly attribute HTMLVideoElement? pictureInPictureElement;
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
RuntimeEnabled=PictureInPictureAPI RuntimeEnabled=PictureInPictureAPI
] ]
partial interface HTMLVideoElement { partial interface HTMLVideoElement {
[CallWith=ScriptState, Measure] Promise<PictureInPictureWindow> requestPictureInPicture(); [CallWith=ScriptState, Measure, NewObject] Promise<PictureInPictureWindow> requestPictureInPicture();
attribute EventHandler onenterpictureinpicture; attribute EventHandler onenterpictureinpicture;
attribute EventHandler onleavepictureinpicture; attribute EventHandler onleavepictureinpicture;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment