Commit f81e2e34 authored by Rune Lillesveen's avatar Rune Lillesveen Committed by Commit Bot

Missing RunPendingTasks for parser blocking XML parser.

With BlockHTMLParserOnStyleSheets enabled, these unit tests needed
RunPendingTasks calls to resume and finish the blocked parsing.

Bug: 891767
Change-Id: Ie65a0ec884b70208bbbf2290ab86aa67684819bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014454Reviewed-by: default avatarAnders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735829}
parent 15de0d31
...@@ -118,6 +118,7 @@ TEST_F(DocumentLoadingRenderingTest, ...@@ -118,6 +118,7 @@ TEST_F(DocumentLoadingRenderingTest,
// Sheet finishes loading, but no documentElement yet so don't resume. // Sheet finishes loading, but no documentElement yet so don't resume.
css_resource.Complete("a { color: red; }"); css_resource.Complete("a { color: red; }");
test::RunPendingTasks();
EXPECT_TRUE(Compositor().DeferMainFrameUpdate()); EXPECT_TRUE(Compositor().DeferMainFrameUpdate());
// Root inserted so resume. // Root inserted so resume.
...@@ -155,6 +156,7 @@ TEST_F(DocumentLoadingRenderingTest, ShouldResumeCommitsAfterSheetsLoadForXml) { ...@@ -155,6 +156,7 @@ TEST_F(DocumentLoadingRenderingTest, ShouldResumeCommitsAfterSheetsLoadForXml) {
// Sheet finished, so resume commits. // Sheet finished, so resume commits.
css_resource.Finish(); css_resource.Finish();
test::RunPendingTasks();
EXPECT_FALSE(Compositor().DeferMainFrameUpdate()); EXPECT_FALSE(Compositor().DeferMainFrameUpdate());
} }
......
...@@ -46,6 +46,7 @@ class SVGImageTest : public testing::Test { ...@@ -46,6 +46,7 @@ class SVGImageTest : public testing::Test {
observer_ = MakeGarbageCollected<PauseControlImageObserver>(should_pause); observer_ = MakeGarbageCollected<PauseControlImageObserver>(should_pause);
image_ = SVGImage::Create(observer_); image_ = SVGImage::Create(observer_);
image_->SetData(SharedBuffer::Create(data, strlen(data)), true); image_->SetData(SharedBuffer::Create(data, strlen(data)), true);
test::RunPendingTasks();
} }
void LoadUsingFileName(const String& file_name) { void LoadUsingFileName(const String& file_name) {
...@@ -56,6 +57,7 @@ class SVGImageTest : public testing::Test { ...@@ -56,6 +57,7 @@ class SVGImageTest : public testing::Test {
observer_ = MakeGarbageCollected<PauseControlImageObserver>(true); observer_ = MakeGarbageCollected<PauseControlImageObserver>(true);
image_ = SVGImage::Create(observer_); image_ = SVGImage::Create(observer_);
image_->SetData(image_data, true); image_->SetData(image_data, true);
test::RunPendingTasks();
} }
void PumpFrame() { void PumpFrame() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment