Commit f88ffb95 authored by Chris Sharp's avatar Chris Sharp Committed by Commit Bot

Disable signin e2e tests

Tests are often timing out on the Win7 bots.

TBR=svenzheng

Bug: 1025335
Change-Id: If7b62427b2896d09d31fac39f3932a3786403a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942811
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: default avatarChris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720029}
parent 263e0c2f
...@@ -150,16 +150,21 @@ class LiveSignInTest : public signin::test::LiveTest { ...@@ -150,16 +150,21 @@ class LiveSignInTest : public signin::test::LiveTest {
} }
}; };
// Sings in an account through the settings page and checks that the account is // Often timing out on windows. http://crbug.com/1025335
// added to Chrome. Sync should be disabled because the test doesn't pass
// through the Sync confirmation dialog.
// crbug/1025335 Flaky on Win7 builders.
#if defined(OS_WIN) #if defined(OS_WIN)
#define MAYBE_SimpleSignInFlow DISABLED_SimpleSignInFlow #define MAYBE_SimpleSignInFlow DISABLED_SimpleSignInFlow
#define MAYBE_WebSignOut DISABLED_WebSignOut
#define MAYBE_TurnOffSync DISABLED_TurnOffSync
#else #else
#define MAYBE_SimpleSignInFlow SimpleSignInFlow #define MAYBE_SimpleSignInFlow SimpleSignInFlow
#define MAYBE_WebSignOut WebSignOut
#define MAYBE_TurnOffSync TurnOffSync
#endif #endif
// Sings in an account through the settings page and checks that the account is
// added to Chrome. Sync should be disabled because the test doesn't pass
// through the Sync confirmation dialog.
IN_PROC_BROWSER_TEST_F(LiveSignInTest, MAYBE_SimpleSignInFlow) { IN_PROC_BROWSER_TEST_F(LiveSignInTest, MAYBE_SimpleSignInFlow) {
TestAccount ta; TestAccount ta;
CHECK(GetTestAccountsUtil()->GetAccount("TEST_ACCOUNT_1", ta)); CHECK(GetTestAccountsUtil()->GetAccount("TEST_ACCOUNT_1", ta));
...@@ -181,7 +186,7 @@ IN_PROC_BROWSER_TEST_F(LiveSignInTest, MAYBE_SimpleSignInFlow) { ...@@ -181,7 +186,7 @@ IN_PROC_BROWSER_TEST_F(LiveSignInTest, MAYBE_SimpleSignInFlow) {
// Sync is enabled. // Sync is enabled.
// Then, signs out on the web and checks that the account is removed from // Then, signs out on the web and checks that the account is removed from
// cookies and Sync paused error is displayed. // cookies and Sync paused error is displayed.
IN_PROC_BROWSER_TEST_F(LiveSignInTest, WebSignOut) { IN_PROC_BROWSER_TEST_F(LiveSignInTest, MAYBE_WebSignOut) {
TestAccount test_account; TestAccount test_account;
CHECK(GetTestAccountsUtil()->GetAccount("TEST_ACCOUNT_1", test_account)); CHECK(GetTestAccountsUtil()->GetAccount("TEST_ACCOUNT_1", test_account));
TurnOnSync(test_account); TurnOnSync(test_account);
...@@ -261,7 +266,7 @@ IN_PROC_BROWSER_TEST_F(LiveSignInTest, WebSignInAndSignOut) { ...@@ -261,7 +266,7 @@ IN_PROC_BROWSER_TEST_F(LiveSignInTest, WebSignInAndSignOut) {
// Sync is enabled. Signs in a second account on the web. // Sync is enabled. Signs in a second account on the web.
// Then, turns Sync off from the settings page and checks that both accounts are // Then, turns Sync off from the settings page and checks that both accounts are
// removed from Chrome and from cookies. // removed from Chrome and from cookies.
IN_PROC_BROWSER_TEST_F(LiveSignInTest, TurnOffSync) { IN_PROC_BROWSER_TEST_F(LiveSignInTest, MAYBE_TurnOffSync) {
TestAccount test_account_1; TestAccount test_account_1;
CHECK(GetTestAccountsUtil()->GetAccount("TEST_ACCOUNT_1", test_account_1)); CHECK(GetTestAccountsUtil()->GetAccount("TEST_ACCOUNT_1", test_account_1));
TurnOnSync(test_account_1); TurnOnSync(test_account_1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment