viz: CHECK that ScopedSkiaWriteAccess is defined
On Chrome OS, we're seeing a relatively rare crash on submitting an SkiaOutputDeviceBufferQueue::Submit [1]. The stack trace from the crashes is pretty inconclusive (no real line number). After looking at the code, I suspect it's because ScopedSkiaWriteAccess is null, but I'd like to upgrade the DCHECK to a CHECK here to confirm. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1156158 Bug: 1156158 Change-Id: Ibacc53efed6a2fe899afb408692e87314ef98d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643485Reviewed-by:Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#845866}
Showing
Please register or sign in to comment