Commit f9bf5ca8 authored by skym's avatar skym Committed by Commit bot

[Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters.

This in preparation for USER_EVENTS, which is a commit only type and
some fields like version and not useful. We want to save as much
bandwidth as possible, and switching to optional saves us ~2 bytes each
before compression.

BUG=714828

Review-Url: https://codereview.chromium.org/2837993002
Cr-Commit-Position: refs/heads/master@{#468104}
parent 77b3d04f
...@@ -179,7 +179,9 @@ message SyncEntity { ...@@ -179,7 +179,9 @@ message SyncEntity {
// always positive and indentifies the revision of the item data being sent // always positive and indentifies the revision of the item data being sent
// to the client. // to the client.
// Present in both GetUpdatesResponse and CommitMessage. // Present in both GetUpdatesResponse and CommitMessage.
required int64 version = 4; // WARNING: This field used to be required before M60. Any client before this
// will fail to deserialize if this field is missing.
optional int64 version = 4;
// Last modification time (in java time milliseconds) // Last modification time (in java time milliseconds)
// Present in both GetUpdatesResponse and CommitMessage. // Present in both GetUpdatesResponse and CommitMessage.
...@@ -197,7 +199,9 @@ message SyncEntity { ...@@ -197,7 +199,9 @@ message SyncEntity {
// depended on the uniqueness of the property since November 2009; it was // depended on the uniqueness of the property since November 2009; it was
// removed from Chromium by http://codereview.chromium.org/371029 . // removed from Chromium by http://codereview.chromium.org/371029 .
// Present in both GetUpdatesResponse and CommitMessage. // Present in both GetUpdatesResponse and CommitMessage.
required string name = 7; // WARNING: This field used to be required before M60. Any client before this
// will fail to deserialize if this field is missing.
optional string name = 7;
// The name of this item. Same as |name|. // The name of this item. Same as |name|.
// |non_unique_name| should take precedence over the |name| value if both // |non_unique_name| should take precedence over the |name| value if both
...@@ -965,15 +969,6 @@ message AuthenticateResponse { ...@@ -965,15 +969,6 @@ message AuthenticateResponse {
optional UserIdentification user = 1; optional UserIdentification user = 1;
}; };
message ThrottleParameters {
// Deprecated. Remove this from the server side.
required int32 min_measure_payload_size = 1;
required double target_utilization = 2;
required double measure_interval_max = 3;
required double measure_interval_min = 4;
required double observation_window = 5;
};
message ClientToServerResponse { message ClientToServerResponse {
optional CommitResponse commit = 1; optional CommitResponse commit = 1;
optional GetUpdatesResponse get_updates = 2; optional GetUpdatesResponse get_updates = 2;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment