Commit fbbf6668 authored by Sangwoo Ko's avatar Sangwoo Ko Committed by Commit Bot

Use ui::ImageModel instead of gfx::ImageSkia in AvatarButton

There's no intended behavior changes

ui: :IamgeModel should be prefered to gfx::ImageSkia.
Bug: 1048901, 1100034
Change-Id: I356a160e04f162ca6185efd798f064fb5adac305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315662
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791249}
parent 569aa719
...@@ -96,7 +96,7 @@ void AvatarToolbarButton::UpdateIcon() { ...@@ -96,7 +96,7 @@ void AvatarToolbarButton::UpdateIcon() {
gfx::Image gaia_account_image = delegate_->GetGaiaAccountImage(); gfx::Image gaia_account_image = delegate_->GetGaiaAccountImage();
for (auto state : kButtonStates) for (auto state : kButtonStates)
SetImage(state, GetAvatarIcon(state, gaia_account_image)); SetImageModel(state, GetAvatarIcon(state, gaia_account_image));
delegate_->ShowIdentityAnimation(gaia_account_image); delegate_->ShowIdentityAnimation(gaia_account_image);
SetInsets(); SetInsets();
...@@ -266,7 +266,7 @@ base::string16 AvatarToolbarButton::GetAvatarTooltipText() const { ...@@ -266,7 +266,7 @@ base::string16 AvatarToolbarButton::GetAvatarTooltipText() const {
return base::string16(); return base::string16();
} }
gfx::ImageSkia AvatarToolbarButton::GetAvatarIcon( ui::ImageModel AvatarToolbarButton::GetAvatarIcon(
ButtonState state, ButtonState state,
const gfx::Image& gaia_account_image) const { const gfx::Image& gaia_account_image) const {
const int icon_size = ui::TouchUiController::Get()->touch_ui() const int icon_size = ui::TouchUiController::Get()->touch_ui()
...@@ -276,24 +276,24 @@ gfx::ImageSkia AvatarToolbarButton::GetAvatarIcon( ...@@ -276,24 +276,24 @@ gfx::ImageSkia AvatarToolbarButton::GetAvatarIcon(
switch (delegate_->GetState()) { switch (delegate_->GetState()) {
case State::kIncognitoProfile: case State::kIncognitoProfile:
return gfx::CreateVectorIcon(kIncognitoIcon, icon_size, icon_color); return ui::ImageModel::FromVectorIcon(kIncognitoIcon, icon_color,
icon_size);
case State::kGuestSession: case State::kGuestSession:
return profiles::GetGuestAvatar(icon_size); return ui::ImageModel::FromImageSkia(profiles::GetGuestAvatar(icon_size));
case State::kGenericProfile: case State::kGenericProfile:
return gfx::CreateVectorIcon(kUserAccountAvatarIcon, icon_size, return ui::ImageModel::FromVectorIcon(kUserAccountAvatarIcon, icon_color,
icon_color); icon_size);
case State::kAnimatedUserIdentity: case State::kAnimatedUserIdentity:
case State::kPasswordsOnlySyncError: case State::kPasswordsOnlySyncError:
case State::kSyncError: case State::kSyncError:
case State::kSyncPaused: case State::kSyncPaused:
case State::kNormal: case State::kNormal:
return profiles::GetSizedAvatarIcon( return ui::ImageModel::FromImage(profiles::GetSizedAvatarIcon(
delegate_->GetProfileAvatarImage(gaia_account_image), true, delegate_->GetProfileAvatarImage(gaia_account_image), true, icon_size,
icon_size, icon_size, profiles::SHAPE_CIRCLE) icon_size, profiles::SHAPE_CIRCLE));
.AsImageSkia();
} }
NOTREACHED(); NOTREACHED();
return gfx::ImageSkia(); return ui::ImageModel();
} }
void AvatarToolbarButton::SetInsets() { void AvatarToolbarButton::SetInsets() {
......
...@@ -75,7 +75,7 @@ class AvatarToolbarButton : public ToolbarButton, ...@@ -75,7 +75,7 @@ class AvatarToolbarButton : public ToolbarButton,
HighlightMeetsMinimumContrast); HighlightMeetsMinimumContrast);
base::string16 GetAvatarTooltipText() const; base::string16 GetAvatarTooltipText() const;
gfx::ImageSkia GetAvatarIcon(ButtonState state, ui::ImageModel GetAvatarIcon(ButtonState state,
const gfx::Image& profile_identity_image) const; const gfx::Image& profile_identity_image) const;
void SetInsets(); void SetInsets();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment