Commit fbdd1097 authored by Sven Zheng's avatar Sven Zheng Committed by Commit Bot

Re-add EyeDropperBrowserTests on FYI bot

Can't repro the flaky test locally. Re-adding to FYI bot for further
debugging and remain disabled for CI/CQ bot.

Bug: 1131319
Change-Id: Id0efb7067480d668dd7caad1cbb6763cb0a1ae84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446025Reviewed-by: default avatarStephen Martinis <martiniss@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814349}
parent cc563640
...@@ -67,9 +67,7 @@ class EyeDropperBrowserTest : public UiBrowserTest, ...@@ -67,9 +67,7 @@ class EyeDropperBrowserTest : public UiBrowserTest,
std::unique_ptr<content::EyeDropper> eye_dropper_; std::unique_ptr<content::EyeDropper> eye_dropper_;
}; };
// Invokes the eye dropper. IN_PROC_BROWSER_TEST_P(EyeDropperBrowserTest, InvokeUi_default) {
// Flaky: https://crbug.com/1131319
IN_PROC_BROWSER_TEST_P(EyeDropperBrowserTest, DISABLED_InvokeUi_default) {
ShowAndVerifyUi(); ShowAndVerifyUi();
} }
......
...@@ -1823,7 +1823,8 @@ ...@@ -1823,7 +1823,8 @@
"--browser-ui-tests-verify-pixels", "--browser-ui-tests-verify-pixels",
"--enable-pixel-output-in-tests", "--enable-pixel-output-in-tests",
"--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter", "--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter",
"--git-revision=${got_revision}" "--git-revision=${got_revision}",
"--gtest_filter=-*EyeDropperBrowserTest.*"
], ],
"merge": { "merge": {
"args": [], "args": [],
......
...@@ -2192,6 +2192,12 @@ ...@@ -2192,6 +2192,12 @@
}, },
'pixel_browser_tests': { 'pixel_browser_tests': {
'modifications': { 'modifications': {
# TODO(crbug.com/1131319): Re-enable the tests.
'Win10 Tests x64':{
'args': [
'--gtest_filter=-*EyeDropperBrowserTest.*',
],
},
'win-pixel-tester-rel': { 'win-pixel-tester-rel': {
'non_precommit_args': [ 'non_precommit_args': [
# Do not allow retry or it will break the bulk approval process. # Do not allow retry or it will break the bulk approval process.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment