Commit fbfb38a1 authored by Egor Pasko's avatar Egor Pasko Committed by Commit Bot

crazylinker: Disable on Android N+

This reverts commit 774b2fbf and
describes new evidence in comments.

Bug: 980304
Change-Id: I20f3e7abdcade1cafa2b5d85bad4aa215e6ff1cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695557
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676392}
parent 376aa007
...@@ -140,6 +140,20 @@ public class LibraryLoader { ...@@ -140,6 +140,20 @@ public class LibraryLoader {
* libraries instead. * libraries instead.
*/ */
public static boolean useCrazyLinker() { public static boolean useCrazyLinker() {
// A non-monochrome APK (such as ChromePublic.apk) can be installed on N+ in these
// circumstances:
// * installing APK manually
// * after OTA from M to N
// * side-installing Chrome (possibly from another release channel)
// * Play Store bugs leading to incorrect APK flavor being installed
// * installing other Chromium-based browsers
//
// For Chrome builds regularly shipped to users on N+, the system linker (or the Android
// Framework) provides the necessary functionality to load without crazylinker. The
// crazylinker is risky to auto-enable on newer Android releases, as it may interfere with
// regular library loading. See http://crbug.com/980304 as example.
if (Build.VERSION.SDK_INT >= VERSION_CODES.N) return false;
// The auto-generated NativeLibraries.sUseLinker variable will be true if the // The auto-generated NativeLibraries.sUseLinker variable will be true if the
// build has not explicitly disabled Linker features. // build has not explicitly disabled Linker features.
return NativeLibraries.sUseLinker; return NativeLibraries.sUseLinker;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment