Commit fc092256 authored by rch's avatar rch Committed by Commit bot

Remove use of deprecated DelayedSocketData gcm_unit_test.

Review URL: https://codereview.chromium.org/1141453005

Cr-Commit-Position: refs/heads/master@{#330814}
parent c2f6958c
...@@ -46,7 +46,9 @@ class GCMSocketStreamTest : public testing::Test { ...@@ -46,7 +46,9 @@ class GCMSocketStreamTest : public testing::Test {
void WaitForData(int msg_size); void WaitForData(int msg_size);
base::MessageLoop* message_loop() { return &message_loop_; }; base::MessageLoop* message_loop() { return &message_loop_; };
net::DelayedSocketData* data_provider() { return data_provider_.get(); } net::StaticSocketDataProvider* data_provider() {
return data_provider_.get();
}
SocketInputStream* input_stream() { return socket_input_stream_.get(); } SocketInputStream* input_stream() { return socket_input_stream_.get(); }
SocketOutputStream* output_stream() { return socket_output_stream_.get(); } SocketOutputStream* output_stream() { return socket_output_stream_.get(); }
net::StreamSocket* socket() { return socket_.get(); } net::StreamSocket* socket() { return socket_.get(); }
...@@ -61,7 +63,7 @@ class GCMSocketStreamTest : public testing::Test { ...@@ -61,7 +63,7 @@ class GCMSocketStreamTest : public testing::Test {
// SocketStreams and their data providers. // SocketStreams and their data providers.
ReadList mock_reads_; ReadList mock_reads_;
WriteList mock_writes_; WriteList mock_writes_;
scoped_ptr<net::DelayedSocketData> data_provider_; scoped_ptr<net::StaticSocketDataProvider> data_provider_;
scoped_ptr<SocketInputStream> socket_input_stream_; scoped_ptr<SocketInputStream> socket_input_stream_;
scoped_ptr<SocketOutputStream> socket_output_stream_; scoped_ptr<SocketOutputStream> socket_output_stream_;
...@@ -86,8 +88,7 @@ void GCMSocketStreamTest::BuildSocket(const ReadList& read_list, ...@@ -86,8 +88,7 @@ void GCMSocketStreamTest::BuildSocket(const ReadList& read_list,
mock_reads_ = read_list; mock_reads_ = read_list;
mock_writes_ = write_list; mock_writes_ = write_list;
data_provider_.reset( data_provider_.reset(
new net::DelayedSocketData( new net::StaticSocketDataProvider(
0,
vector_as_array(&mock_reads_), mock_reads_.size(), vector_as_array(&mock_reads_), mock_reads_.size(),
vector_as_array(&mock_writes_), mock_writes_.size())); vector_as_array(&mock_writes_), mock_writes_.size()));
socket_factory_.AddSocketDataProvider(data_provider_.get()); socket_factory_.AddSocketDataProvider(data_provider_.get());
...@@ -230,18 +231,11 @@ TEST_F(GCMSocketStreamTest, ReadAsync) { ...@@ -230,18 +231,11 @@ TEST_F(GCMSocketStreamTest, ReadAsync) {
int first_read_len = kReadDataSize / 2; int first_read_len = kReadDataSize / 2;
int second_read_len = kReadDataSize - first_read_len; int second_read_len = kReadDataSize - first_read_len;
ReadList read_list; ReadList read_list;
read_list.push_back(
net::MockRead(net::SYNCHRONOUS, net::ERR_IO_PENDING));
read_list.push_back( read_list.push_back(
net::MockRead(net::ASYNC, kReadData, first_read_len)); net::MockRead(net::ASYNC, kReadData, first_read_len));
read_list.push_back( read_list.push_back(
net::MockRead(net::ASYNC, &kReadData[first_read_len], second_read_len)); net::MockRead(net::ASYNC, &kReadData[first_read_len], second_read_len));
BuildSocket(read_list, WriteList()); BuildSocket(read_list, WriteList());
base::MessageLoop::current()->PostTask(
FROM_HERE,
base::Bind(&net::DelayedSocketData::ForceNextRead,
base::Unretained(data_provider())));
WaitForData(kReadDataSize); WaitForData(kReadDataSize);
ASSERT_EQ(std::string(kReadData, kReadDataSize), ASSERT_EQ(std::string(kReadData, kReadDataSize),
DoInputStreamRead(kReadDataSize)); DoInputStreamRead(kReadDataSize));
......
...@@ -118,7 +118,9 @@ class GCMConnectionHandlerImplTest : public testing::Test { ...@@ -118,7 +118,9 @@ class GCMConnectionHandlerImplTest : public testing::Test {
return connection_handler_.get(); return connection_handler_.get();
} }
base::MessageLoop* message_loop() { return &message_loop_; }; base::MessageLoop* message_loop() { return &message_loop_; };
net::DelayedSocketData* data_provider() { return data_provider_.get(); } net::StaticSocketDataProvider* data_provider() {
return data_provider_.get();
}
int last_error() const { return last_error_; } int last_error() const { return last_error_; }
// Initialize the connection handler, setting |dst_proto| as the destination // Initialize the connection handler, setting |dst_proto| as the destination
...@@ -136,7 +138,7 @@ class GCMConnectionHandlerImplTest : public testing::Test { ...@@ -136,7 +138,7 @@ class GCMConnectionHandlerImplTest : public testing::Test {
// SocketStreams and their data provider. // SocketStreams and their data provider.
ReadList mock_reads_; ReadList mock_reads_;
WriteList mock_writes_; WriteList mock_writes_;
scoped_ptr<net::DelayedSocketData> data_provider_; scoped_ptr<net::StaticSocketDataProvider> data_provider_;
// The connection handler being tested. // The connection handler being tested.
scoped_ptr<ConnectionHandlerImpl> connection_handler_; scoped_ptr<ConnectionHandlerImpl> connection_handler_;
...@@ -169,7 +171,7 @@ net::StreamSocket* GCMConnectionHandlerImplTest::BuildSocket( ...@@ -169,7 +171,7 @@ net::StreamSocket* GCMConnectionHandlerImplTest::BuildSocket(
mock_reads_ = read_list; mock_reads_ = read_list;
mock_writes_ = write_list; mock_writes_ = write_list;
data_provider_.reset( data_provider_.reset(
new net::DelayedSocketData(0, new net::StaticSocketDataProvider(
&(mock_reads_[0]), mock_reads_.size(), &(mock_reads_[0]), mock_reads_.size(),
&(mock_writes_[0]), mock_writes_.size())); &(mock_writes_[0]), mock_writes_.size()));
socket_factory_.AddSocketDataProvider(data_provider_.get()); socket_factory_.AddSocketDataProvider(data_provider_.get());
...@@ -571,9 +573,6 @@ TEST_F(GCMConnectionHandlerImplTest, ReadTimeout) { ...@@ -571,9 +573,6 @@ TEST_F(GCMConnectionHandlerImplTest, ReadTimeout) {
EXPECT_FALSE(received_message.get()); EXPECT_FALSE(received_message.get());
EXPECT_EQ(net::ERR_TIMED_OUT, last_error()); EXPECT_EQ(net::ERR_TIMED_OUT, last_error());
EXPECT_FALSE(connection_handler()->CanSendMessage()); EXPECT_FALSE(connection_handler()->CanSendMessage());
// Finish the socket read. Should have no effect.
data_provider()->ForceNextRead();
} }
// Receive a message with zero data bytes. // Receive a message with zero data bytes.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment