Commit fc9d822f authored by Xing Liu's avatar Xing Liu Committed by Commit Bot

Bookmark: Fix a legacy DCHECK in bookmark bridge.

Currently bookmark root node has 4 children instead of 5. The DCHECK
is never ran.

The java code calling into this is probably dead code, added a comment.

Bug: 1148498
Change-Id: I20630b20ba8454665a8d1721f62e2baa312263b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535923Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarBrandon Wylie <wylieb@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827192}
parent f5882938
...@@ -299,8 +299,7 @@ void BookmarkBridge::GetTopLevelFolderIDs( ...@@ -299,8 +299,7 @@ void BookmarkBridge::GetTopLevelFolderIDs(
std::size_t special_count = top_level_folders.size(); std::size_t special_count = top_level_folders.size();
if (get_normal) { if (get_normal) {
DCHECK_EQ(5u, bookmark_model_->root_node()->children().size()); DCHECK_EQ(4u, bookmark_model_->root_node()->children().size());
for (const auto& node : bookmark_model_->mobile_node()->children()) { for (const auto& node : bookmark_model_->mobile_node()->children()) {
if (node->is_folder()) if (node->is_folder())
top_level_folders.push_back(node.get()); top_level_folders.push_back(node.get());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment