Commit fcbff223 authored by Antonio Gomes's avatar Antonio Gomes Committed by Commit Bot

[s13n] Replace inheritance of PO2TS::Observer by IdentityManager::Observer in AboutSigninInternals

CL is an incremental step to get away from PO2TS from AboutSigninInternals.

BUG=809539

Change-Id: Id8e8baea53c76eedee1bb3ac83f2ccb347909210
Reviewed-on: https://chromium-review.googlesource.com/c/1426760Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625167}
parent e5ee3862
...@@ -302,7 +302,6 @@ void AboutSigninInternals::Initialize(SigninClient* client) { ...@@ -302,7 +302,6 @@ void AboutSigninInternals::Initialize(SigninClient* client) {
signin_error_controller_->AddObserver(this); signin_error_controller_->AddObserver(this);
identity_manager_->AddObserver(this); identity_manager_->AddObserver(this);
identity_manager_->AddDiagnosticsObserver(this); identity_manager_->AddDiagnosticsObserver(this);
token_service_->AddObserver(this);
token_service_->AddDiagnosticsObserver(this); token_service_->AddDiagnosticsObserver(this);
cookie_manager_service_->AddObserver(this); cookie_manager_service_->AddObserver(this);
} }
...@@ -311,7 +310,6 @@ void AboutSigninInternals::Shutdown() { ...@@ -311,7 +310,6 @@ void AboutSigninInternals::Shutdown() {
signin_error_controller_->RemoveObserver(this); signin_error_controller_->RemoveObserver(this);
identity_manager_->RemoveObserver(this); identity_manager_->RemoveObserver(this);
identity_manager_->RemoveDiagnosticsObserver(this); identity_manager_->RemoveDiagnosticsObserver(this);
token_service_->RemoveObserver(this);
token_service_->RemoveDiagnosticsObserver(this); token_service_->RemoveDiagnosticsObserver(this);
cookie_manager_service_->RemoveObserver(this); cookie_manager_service_->RemoveObserver(this);
} }
...@@ -402,7 +400,7 @@ void AboutSigninInternals::OnRefreshTokensLoaded() { ...@@ -402,7 +400,7 @@ void AboutSigninInternals::OnRefreshTokensLoaded() {
NotifyObservers(); NotifyObservers();
} }
void AboutSigninInternals::OnEndBatchChanges() { void AboutSigninInternals::OnEndBatchOfRefreshTokenStateChanges() {
NotifyObservers(); NotifyObservers();
} }
......
...@@ -37,7 +37,6 @@ using TimedSigninStatusValue = std::pair<std::string, std::string>; ...@@ -37,7 +37,6 @@ using TimedSigninStatusValue = std::pair<std::string, std::string>;
// to propagate to about:signin-internals via SigninInternalsUI. // to propagate to about:signin-internals via SigninInternalsUI.
class AboutSigninInternals class AboutSigninInternals
: public KeyedService, : public KeyedService,
public OAuth2TokenService::Observer,
public OAuth2TokenService::DiagnosticsObserver, public OAuth2TokenService::DiagnosticsObserver,
public GaiaCookieManagerService::Observer, public GaiaCookieManagerService::Observer,
SigninErrorController::Observer, SigninErrorController::Observer,
...@@ -212,11 +211,9 @@ class AboutSigninInternals ...@@ -212,11 +211,9 @@ class AboutSigninInternals
void OnRefreshTokenRevokedFromSource(const std::string& account_id, void OnRefreshTokenRevokedFromSource(const std::string& account_id,
const std::string& source) override; const std::string& source) override;
// OAuth2TokenServiceDelegate::Observer implementations.
void OnRefreshTokensLoaded() override;
void OnEndBatchChanges() override;
// IdentityManager::Observer implementations. // IdentityManager::Observer implementations.
void OnRefreshTokensLoaded() override;
void OnEndBatchOfRefreshTokenStateChanges() override;
void OnPrimaryAccountSigninFailed( void OnPrimaryAccountSigninFailed(
const GoogleServiceAuthError& error) override; const GoogleServiceAuthError& error) override;
void OnPrimaryAccountSet(const AccountInfo& primary_account_info) override; void OnPrimaryAccountSet(const AccountInfo& primary_account_info) override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment