Commit fd1fc48d authored by Dan Sanders's avatar Dan Sanders Committed by Commit Bot

Remove VideoTrackWriter IDL.

This removes the VideoTrackWriter interface so that it will not become
visible when the WebCodecs feature is enabled.

The VideoTrackReader unittest depends on the VideoTrackWriter C++ code,
so that has been left for now.

Bug: 897297
Change-Id: I1c328d7ca995cf9019ca50c65f8cb7257fbb06ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353538
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Dan Sanders <sandersd@chromium.org>
Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797945}
parent 32890eb3
...@@ -756,7 +756,6 @@ static_idl_files_in_modules = get_path_info( ...@@ -756,7 +756,6 @@ static_idl_files_in_modules = get_path_info(
"//third_party/blink/renderer/modules/webcodecs/video_frame_init.idl", "//third_party/blink/renderer/modules/webcodecs/video_frame_init.idl",
"//third_party/blink/renderer/modules/webcodecs/video_frame_output_callback.idl", "//third_party/blink/renderer/modules/webcodecs/video_frame_output_callback.idl",
"//third_party/blink/renderer/modules/webcodecs/video_track_reader.idl", "//third_party/blink/renderer/modules/webcodecs/video_track_reader.idl",
"//third_party/blink/renderer/modules/webcodecs/video_track_writer.idl",
"//third_party/blink/renderer/modules/webcodecs/video_track_writer_parameters.idl", "//third_party/blink/renderer/modules/webcodecs/video_track_writer_parameters.idl",
"//third_party/blink/renderer/modules/webcodecs/web_codecs_error_callback.idl", "//third_party/blink/renderer/modules/webcodecs/web_codecs_error_callback.idl",
"//third_party/blink/renderer/modules/webdatabase/database.idl", "//third_party/blink/renderer/modules/webdatabase/database.idl",
......
...@@ -13,7 +13,6 @@ modules_idl_files = [ ...@@ -13,7 +13,6 @@ modules_idl_files = [
"video_encoder.idl", "video_encoder.idl",
"video_frame.idl", "video_frame.idl",
"video_track_reader.idl", "video_track_reader.idl",
"video_track_writer.idl",
] ]
modules_callback_function_idl_files = [ modules_callback_function_idl_files = [
......
...@@ -187,7 +187,6 @@ MediaStreamTrack* VideoTrackWriter::track() { ...@@ -187,7 +187,6 @@ MediaStreamTrack* VideoTrackWriter::track() {
void VideoTrackWriter::Trace(Visitor* visitor) const { void VideoTrackWriter::Trace(Visitor* visitor) const {
visitor->Trace(track_); visitor->Trace(track_);
visitor->Trace(writable_); visitor->Trace(writable_);
ScriptWrappable::Trace(visitor);
} }
} // namespace blink } // namespace blink
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
#include "third_party/blink/renderer/modules/mediastream/media_stream_track.h" #include "third_party/blink/renderer/modules/mediastream/media_stream_track.h"
#include "third_party/blink/renderer/modules/modules_export.h" #include "third_party/blink/renderer/modules/modules_export.h"
#include "third_party/blink/renderer/platform/bindings/script_wrappable.h" #include "third_party/blink/renderer/platform/heap/heap.h"
namespace blink { namespace blink {
...@@ -15,11 +15,9 @@ class ScriptState; ...@@ -15,11 +15,9 @@ class ScriptState;
class WritableStream; class WritableStream;
class VideoTrackWriterParameters; class VideoTrackWriterParameters;
class MODULES_EXPORT VideoTrackWriter final : public ScriptWrappable { class MODULES_EXPORT VideoTrackWriter final
DEFINE_WRAPPERTYPEINFO(); : public GarbageCollected<VideoTrackWriter> {
public: public:
// video_track_writer.idl implementation
static VideoTrackWriter* Create(ScriptState* script_state, static VideoTrackWriter* Create(ScriptState* script_state,
const VideoTrackWriterParameters* params, const VideoTrackWriterParameters* params,
ExceptionState& exception_state); ExceptionState& exception_state);
...@@ -28,7 +26,7 @@ class MODULES_EXPORT VideoTrackWriter final : public ScriptWrappable { ...@@ -28,7 +26,7 @@ class MODULES_EXPORT VideoTrackWriter final : public ScriptWrappable {
WritableStream* writable(); WritableStream* writable();
// GarbageCollected override // GarbageCollected override
void Trace(Visitor* visitor) const override; virtual void Trace(Visitor* visitor) const;
private: private:
Member<MediaStreamTrack> track_; Member<MediaStreamTrack> track_;
......
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// See spec in developement at https://github.com/WICG/web-codecs/blob/master/index.bs
// and https://github.com/WICG/web-codecs/blob/master/explainer.md.
[
Exposed=Window,
RuntimeEnabled=WebCodecs
] interface VideoTrackWriter {
[CallWith=ScriptState, RaisesException]
constructor(VideoTrackWriterParameters params);
readonly attribute WritableStream writable; // of VideoFrame
readonly attribute MediaStreamTrack track;
};
...@@ -8842,11 +8842,6 @@ interface VideoTrackReader ...@@ -8842,11 +8842,6 @@ interface VideoTrackReader
method constructor method constructor
method start method start
method stop method stop
interface VideoTrackWriter
attribute @@toStringTag
getter track
getter writable
method constructor
interface VirtualKeyboard : EventTarget interface VirtualKeyboard : EventTarget
attribute @@toStringTag attribute @@toStringTag
getter boundingRect getter boundingRect
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment