Commit fdbfd4e1 authored by Timur Iskhodzhanov's avatar Timur Iskhodzhanov

Re-enable sandboxing on the Clang ASan Windows bots +tests

This should work fine now that Chrome and sandbox tests behave in an
ASan-friendly way.

This effectively reverts r313452 and r312495

BUG=382867
TBR=thakis@chromium.org,scottmg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/903553004

Cr-Commit-Position: refs/heads/master@{#314790}
parent 4cb9b8c9
...@@ -743,6 +743,9 @@ ...@@ -743,6 +743,9 @@
"ppapi_unittests", "ppapi_unittests",
"printing_unittests", "printing_unittests",
"remoting_unittests", "remoting_unittests",
"sbox_unittests",
"sbox_integration_tests",
"sbox_validation_tests",
"ipc_tests", "ipc_tests",
"sync_unit_tests", "sync_unit_tests",
"skia_unittests", "skia_unittests",
...@@ -791,6 +794,9 @@ ...@@ -791,6 +794,9 @@
"ppapi_unittests", "ppapi_unittests",
"printing_unittests", "printing_unittests",
"remoting_unittests", "remoting_unittests",
"sbox_unittests",
"sbox_integration_tests",
"sbox_validation_tests",
"ipc_tests", "ipc_tests",
"sync_unit_tests", "sync_unit_tests",
"skia_unittests", "skia_unittests",
......
...@@ -185,8 +185,7 @@ def run_executable(cmd, env): ...@@ -185,8 +185,7 @@ def run_executable(cmd, env):
if asan or lsan or msan or tsan: if asan or lsan or msan or tsan:
extra_env.update(get_sanitizer_env(cmd, asan, lsan, msan, tsan)) extra_env.update(get_sanitizer_env(cmd, asan, lsan, msan, tsan))
if lsan or tsan or (asan and sys.platform == 'win32'): if lsan or tsan:
# ASan is not yet sandbox-friendly on Windows (http://crbug.com/382867).
# LSan and TSan are not sandbox-friendly. # LSan and TSan are not sandbox-friendly.
cmd.append('--no-sandbox') cmd.append('--no-sandbox')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment