Commit fe60fb56 authored by Jérôme Lebel's avatar Jérôme Lebel Committed by Commit Bot

[iOS] UnifiedConsentCoordinator needs to be released after being dismissed

|_unifiedConsentCoordinator| should be removed once the sign-in is done
and the user consent is recorded.
This is to avoid to receive notifications related to the UIScrollView
in UnifiedConsentViewController, like:
-[ChromeSigninViewController unifiedConsentCoordinatorDidReachBottom:]

Bug: 918557
Change-Id: I9d57dbf4d9f37f636fa44105f268d7089e192abf
Reviewed-on: https://chromium-review.googlesource.com/c/1393372Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619615}
parent fec0c35b
...@@ -289,6 +289,8 @@ enum AuthenticationState { ...@@ -289,6 +289,8 @@ enum AuthenticationState {
_didFinishSignIn = YES; _didFinishSignIn = YES;
[_delegate didAcceptSignIn:self showAccountsSettings:showAccountsSettings]; [_delegate didAcceptSignIn:self showAccountsSettings:showAccountsSettings];
} }
_unifiedConsentCoordinator.delegate = nil;
_unifiedConsentCoordinator = nil;
} }
- (void)acceptSignInAndCommitSyncChanges { - (void)acceptSignInAndCommitSyncChanges {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment