Use value changes for reading popup buttons in ChromeVox

Change-Id: I86274af81a2d60223813cdfb91253abca97a766b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465383Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816219}

chrome/browser/resources/chromeos/accessibility/chromevox/background/focus_automation_handler.js

@@ -42,7 +42,7 @@ FocusAutomationHandler = class extends BaseAutomationHandler {
         EventType.ACTIVE_DESCENDANT_CHANGED, this.onActiveDescendantChanged);
     this.addListener_(
         EventType.MENU_LIST_ITEM_SELECTED, this.onEventIfSelected);
-    this.addListener_(EventType.TEXT_CHANGED, this.onTextChanged_);
+    this.addListener_(EventType.VALUE_CHANGED, this.onValueChanged_);
   }
 
   /**
@@ -92,9 +92,7 @@ FocusAutomationHandler = class extends BaseAutomationHandler {
   /**
    * @param {!ChromeVoxEvent} evt
    */
-  onTextChanged_(evt) {
-    // TODO: listen to value changes instead when they are generated.
-    // Here only to handle popup buttons.
+  onValueChanged_(evt) {
     if (evt.target.role != RoleType.POP_UP_BUTTON ||
         evt.target.state.editable) {
       return;

chrome/browser/resources/chromeos/accessibility/chromevox/options/options_test.js

@@ -60,11 +60,7 @@ TEST_F('ChromeVoxOptionsTest', 'NumberReadingStyleSelect', function() {
         .call(press(KeyCode.DOWN))
         .expectSpeech('Digits', 'List item', ' 2 of 2 ')
         .call(press(KeyCode.RETURN))
-
-        // TODO: The underlying select behavior here is unexpected because we
-        // never get a new focus event for the select (moving us away from the
-        // menu item). We simply repeat the menu item.
-        .expectSpeech('Digits', ' 2 of 2 ')
+        .expectSpeech('Digits', 'Collapsed')
         .call(() => {
           assertEquals('asDigits', localStorage['numberReadingStyle']);
         })
@@ -108,11 +104,7 @@ TEST_F_WITH_PREAMBLE(
             .call(press(KeyCode.DOWN))
             .expectSpeech('Some', 'List item', ' 2 of 3 ')
             .call(press(KeyCode.RETURN))
-
-            // TODO(josiahk): The underlying select behavior here is unexpected
-            // because we never get a new focus event for the select (moving us
-            // away from the menu item). We simply repeat the menu item.
-            .expectSpeech('Some', ' 2 of 3 ')
+            .expectSpeech('Some', 'Collapsed')
             .call(() => {
               assertEquals(
                   PUNCTUATION_ECHO_SOME,