GitLab

Reason for the revert was duplicate initialization that happened because a
different fix for the initialization issue had already landed in the master
branch.

Original CL description:

Fixes an issue where VideoTrackRecorder when used in combination with
VEAEncoder and very short recording durations (just 1 frame) would
occasionally hold on to video frames forever, causing frame buffers
from the buffer pool to become permanently blocked, eventually leading
to video capture freezing.

The cause was a circular ownership that would happen if only 1 frame
is recorded.

This CL additionally fixes a crash that could happen on initialization
of VEAEncoder. This issue was revealed during testing of the above fix.
Since it is not 100% if this crash was masked by the other issue, and
would only start occurring with the above fix, I am making a fix for that
part of this CL as well.

The cause for the crash issue was that class VEAEncoder, which uses
RefCountedThreadSafe<>, would post an asynchronous task from its
constructor. If this task would finish executing before the newly
constructed instance was assigned to a scoped_refptr<> by however
called the constructor, the instance would destroy itself, because
of the AddRef() and subsequent Release() done by the posting and
running of the asynchronous task.

The fix for this is to use a new method Initialize() instead of
posting a task from the constructor.

TBR=emircan@chromium.org

Bug: 859610
Change-Id: I77d6865be574bf86afca7d0908ce2339f6ecd91e
Reviewed-on: https://chromium-review.googlesource.com/1173408Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582753}

TBR: hayato@chromium.org
Bug: 873829
Change-Id: I321d85a63971b1f9b01bb42d4b5d93db44125c92
Reviewed-on: https://chromium-review.googlesource.com/1173437
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582752}

https://pdfium.googlesource.com/pdfium.git/+log/0c7cf97859dd..19b70815b4d1


git log 0c7cf97859dd..19b70815b4d1 --date=short --no-merges --format='%ad %ae %s'
2018-08-13 thestig@chromium.org Split CFX_MemoryStream::m_dwFlags into two bools.


Created with:
  gclient setdep -r src/third_party/pdfium@19b70815b4d1

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic175ff09df16a3600963519a833f3f6920643c12
Reviewed-on: https://chromium-review.googlesource.com/1173171Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582751}

At request of PM, disable webstore search.

Bug: 872949
Change-Id: I7d696f5f102c3a5b507fb59a4ff7aa240bdd7d0f
Reviewed-on: https://chromium-review.googlesource.com/1170993Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582750}

Phase 1 of the work to replace url_template with action and params as
per the updated WebShareTarget spec:
https://wicg.github.io/web-share-target/.

Note: the work to add method and enctype will be done at a later date.
This is primarily an effort to deprecate url_template and replace it
with action and params.

To avoid a large CL this work is being done in stages with this CL
just adding the new fields the the manifest without deleting the old
one to avoid breakages.

See the bug for a detailed plan for performing these changes.

Bug: 871788
Change-Id: I68e574ab88a6d9bf48c9adc9c8a13600aafd1761
Reviewed-on: https://chromium-review.googlesource.com/1165483Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582749}

Bug: 873711
Change-Id: I35e6c04cc1d137db35ec1f02a41ce55d2b51b0e4
Reviewed-on: https://chromium-review.googlesource.com/1172068Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582748}

Change-Id: Ib8bbcc6efdd2b0a5cf6875a25d1ca1479b237de7
Reviewed-on: https://chromium-review.googlesource.com/1173403Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582747}

Creates shared unit test helpers for MockMetadata and MockGalleryItem
since these concepts are used in multiple unittest files. This means
updating the corresponding unittest.html files that are not yet auto-
generated.

Bug: 867700
Change-Id: Ia77bac5f9dc14abb1f92bb90a8c545d6998e0160
Reviewed-on: https://chromium-review.googlesource.com/1172170Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582746}

Bug: 868205
Change-Id: I9f4b2c8a47c9ad7d3405a5a5cf614e4d2e225435
Reviewed-on: https://chromium-review.googlesource.com/1166463
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582745}

This patch prints the property tree logging by printing each line
separately.

This prevents truncation of the logging output on Android, where:

  LOG << ...long multiline string...

Will be truncated after some finite number of characters. For long
outputs such as the property trees we hit this quite easily.

Bug: 854200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7e70a5e66d8248b2faa478738db94c980c28e3f7
Reviewed-on: https://chromium-review.googlesource.com/1173156
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582744}

https://chromium.googlesource.com/catapult.git/+log/21cd5a309631..501bed82a534


git log 21cd5a309631..501bed82a534 --date=short --no-merges --format='%ad %ae %s'
2018-08-13 sbalana@google.com Add support for ES modules in third_party/idb.


Created with:
  gclient setdep -r src/third_party/catapult@501bed82a534

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855252
TBR=sullivan@chromium.org

Change-Id: Ib96332d41a3b8187d1fa323a543a987136e113ba
Reviewed-on: https://chromium-review.googlesource.com/1173173Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582743}

According to metrics, this action is only firing a couple times a week.

BUG=482176

Change-Id: I9532cd4db87e5c1a801484eef34c522dfcebf0a7
Reviewed-on: https://chromium-review.googlesource.com/1151087Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582742}

Bug: 870030
Change-Id: If46caf16806b64ed5516b548d3080a0a734ca614
Reviewed-on: https://chromium-review.googlesource.com/1159267Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582741}

This is part 2 of 3 for aligning BubbleDialogDelegateView with its
filename.

BUG=873422
TBR=ellyjones@chromium.org

Change-Id: Ie012caded8d230c81a5e4a0ced86195d679b45f6
Reviewed-on: https://chromium-review.googlesource.com/1173409Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582740}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5f5e6287d3f6aec387ef5d04469c8f625ca884ad
Reviewed-on: https://chromium-review.googlesource.com/1173500Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582739}

This implements step 4.2.3 of the BatchCacheOperations algorithm:

https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm

Bug: 720919
Change-Id: I679f786441b813ed816a183522021c417f4ab7b8
Reviewed-on: https://chromium-review.googlesource.com/1162362
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582738}

Also change the GTK theme background tab color to match the frame color.

BUG=872383
R=pkasting
TBR=sky

Change-Id: I4f1f7e5acf3d989047d565d73964e88306dc97ab
Reviewed-on: https://chromium-review.googlesource.com/1168513
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582737}

Previously, the back button immediately navigated backwards in the
Assistant container's UI state.

Now, the back button will navigate backwards in the WebContents history
stack. Only when there is no more history do we return control to the
Assistant container for handling.

See bug for demo.

Bug: b:112355878
Change-Id: I943407c85497f09a5360f21353301b6bc6823315
Reviewed-on: https://chromium-review.googlesource.com/1167646
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582736}

This should change retries from

15s, 16.5s, ... 10min, 10min ..

to

5 minutes, 10 minutes, 20 minutes, ... 24h, 24h..


Bug: 873282
Change-Id: Ib1e3fdebdf155f171a51c73b29724f4ba4673c73
Reviewed-on: https://chromium-review.googlesource.com/1171512
Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582735}

BindingManager maintains a list of Connections that is separate and in
different order compared to ChildProcessRanking. This is a problem with
OOPIF because BindingManager's order of processes _within_ a tab is
almost certainly the worst possible order: visibility is flipped from
root frame to leaf frame, which means a LRU order would remove root
frame first.

Previous attempt of letting BindingManager use Ranking directly and
manipulating the list of moderate binding connections through priority
updates deemed to confusing and thus abandoned:
https://chromium-review.googlesource.com/c/chromium/src/+/1054642

This is a second attempt: adding connection and removing the number of
connections is kept exactly the same. The only difference is connections
are removed in the order of ChildProcessRanking.

Make ChildProcessRanking an iterable that iterates connections that rank
the lowest to rank the highest. Then change BindingManager to hold a set,
and on removal, use the order of Ranking.

Bug: 868603
Change-Id: I7765d3f6d78369dfec3de928c83b3bec0b2cadfe
Reviewed-on: https://chromium-review.googlesource.com/1159359
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582734}

aura::Env::GetInstance is banned in //ash because it will return the
wrong aura::Env in SingleProcessMash mode. See //ash/README.md.

The code is based on the banned function code in src/PRESUBMIT.py.
I decided a little code duplication was better than trying to support
a mix of whitelist and blacklist directories in the global banned
function list.

Bug: 873773
Change-Id: I646f10dc58cc1ea030652c490547834143023e68
Reviewed-on: https://chromium-review.googlesource.com/1173404Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582733}

This CL introduces a "card saved" animation next to the save credit card icon. The mock can be found here:
  https://docs.google.com/presentation/d/1dLbeUlWKkSQzqbDlktot5ldlcVZu32jcjJvIT27vGb8/edit#slide=id.g35839571aa_0_4 (internal)

bug: 855186
Change-Id: I2b56291d9f18158eca73e2d67f68f3d4efd31b06
Reviewed-on: https://chromium-review.googlesource.com/1162862
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582732}

Remove infra/config/global/*-dev.cfg files.
Reasoning: https://crbug.com/871245#c2

R=dpranke@chromium.org, tandrii@chromium.org

BUG: 871245
Change-Id: I1792a02c52e648b96ba0c186078bd78cdf63dbdc
Reviewed-on: https://chromium-review.googlesource.com/1173430Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582731}

The plan is to keep a close eye on bots, and disable the tests back
if we see flakiness.

This CL will help us understand which of the tests are failing,
and also get a stack trace (which is now lost).

Bug: 866212
Change-Id: I94ff8ffb7278eff1ad3533d7872c1781e1e38b67
Reviewed-on: https://chromium-review.googlesource.com/1173443Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582730}

To simplify the logic of triggering from settings page, we need to refactor the current local_card_migration_manager:

1. Move the isServerCard to the personal_data_manager. To determine a card is whether a server card or has server dup only depends on the personal_data_manager. So later we can use this function directly without create local_card_migration_manager when we create new attribute for each credit card entry for the settings page. Add unittests in the personal_data_manager.

2. Extract the prepare migratable credit cards to a helper function. Later, when we implement checking migration requirements in the settings page, we do not need to check the migration requirement twice after we bridge back. So we can directly call PrepareMigratableCreditCard() and AttemptToOfferLocalCardMigration() for the settings page.

Bug: 852904
Change-Id: I12b90054e96a9cafb6905c39608c7a5c1cbc2f8c
Reviewed-on: https://chromium-review.googlesource.com/1167796Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#582729}

Metrics that are logged in client code must be replicated on the remote
NTP. Moved many of these to appropriate locations in Chromium code, or to
most_visited_single.js, which is iframed by the remote NTP. Items
captured by user interaction cannot be moved, and must be captured by the
remote NTP. Opened up access to the required APIs from the remote NTP.

See go/ntp-metrics-doc for more details.

Bug: 855935
Change-Id: Icb0142e34cac122e6326429f8b1525a708084d09
Reviewed-on: https://chromium-review.googlesource.com/1171824Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582728}

Change-Id: I650d6df01f471f5f896a4fdfd48b6f3db939231e
Reviewed-on: https://chromium-review.googlesource.com/1170314
Commit-Queue: Stephan Stross <stephanstross@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582727}

This is a reland of http://crrev/c/1169597 with @available checks
added to TextSuggestionsTouchBarControllerTest.Offset in browser tests.

When the text surrounding the current selection gets too long, only
part of it is received by TextSuggestionsTouchBarController. The
location of the received text within the total block of text is
denoted by an offset. Previously, TextSuggestionsTouchBarController
did not take this offset into account, causing crashes when the
selection range was past the end of the received text.

The offset is passed along with the text and selection range. The
selection range within the received text is calculated using the
offset and received selection range. The editing word range is stored
both as the range within the received text and the range within the
total text for checking when to ignore text selection updates.

RenderWidgetHostView::GetOffsetForSurroundingText() was added to
retrieve the offset on WebContents update.

Browser tests were modified to account for the new offset parameter. A
new browser test, TextSuggestionsTouchBarController.Offset, was added
to test that the controller properly handles offsets.

Bug: 717553
Change-Id: I83f7b3f381086118212106dff3b0b34ed8be2237
Reviewed-on: https://chromium-review.googlesource.com/1173052
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582726}

This commit fix the text highlighted problem both on cancel/done
button and the custom background dialog title.

Bug: 869086
Change-Id: I6e67f241409ed5498f703ec48966da0105ee5925
Reviewed-on: https://chromium-review.googlesource.com/1171792Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582725}

This CL adds TaskScheduler.NumWorkers histogram to measure number of threads
created in each WorkerPool every hour.

Bug: 847501
Change-Id: I5e69f60320231c6ab60d62adb986eecacb15778e
Reviewed-on: https://chromium-review.googlesource.com/1164242
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582724}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
since this use doesn't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: Ied2b63aaf8256033ada85c7d3367db0c4082b454
Reviewed-on: https://chromium-review.googlesource.com/1161084Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582723}

Change-Id: I723ce59e3c6ee5c05bdf58ebf6d56351848a26d4
Reviewed-on: https://chromium-review.googlesource.com/1171849Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582722}

This reverts commit e5fb6b85, without
removing the histograms from histograms.xml.

These histograms were initially added to get a sense of how frequently
gender was used by TTS and TTS Engine extensions, and are obsolete.

TBR=dtseng@chromium.org,rockot@chromium.org

Bug: 855203,871506,871511
Change-Id: Ic2625a7277d0bf277dd2f85e3460c417a64cea9c
Reviewed-on: https://chromium-review.googlesource.com/1173313Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582721}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8d8a9d7701bd..8405a1536d36


git log 8d8a9d7701bd..8405a1536d36 --date=short --no-merges --format='%ad %ae %s'
2018-08-13 dgarrett@google.com chromeos_config: Leave push_overlays enabled on tryjobs.


Created with:
  gclient setdep -r src/third_party/chromite@8405a1536d36

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I02538ea23f3417ee7929c8dd87ba79c2215d7f6e
Reviewed-on: https://chromium-review.googlesource.com/1173131Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582720}

Change-Id: I6abffaf9c76d1df6cd1075e446c9e739b3c91f27
Reviewed-on: https://chromium-review.googlesource.com/1168991Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582719}

This reverts commit a08572dc.

Reason for revert: the original revert was a mistake. The
test is flaky regardless of this CL.


Original change's description:
> Revert "[animation-worklet] Rename layout tests"
> 
> This reverts commit 46b03fcf.
> 
> Reason for revert:
> 
> Seems to break fast/events/middleClickAutoscroll-nested-divs.html on several platforms. Example here:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34202
> 
> 
> Original change's description:
> > [animation-worklet] Rename layout tests
> > 
> > Remove "animation-worklet-' prefix from layout tests. The tests are inside AW
> > directory so the prefix is just visual clutter. I kept it for tests that check
> > something about the worklet itself.
> > 
> > Note: There was a legacy unused animationworklet/visual-update-expected.html
> > file that this patch replaces now.
> > 
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I67a36d7d5913b1394108b8a1731cc660d74f99ad
> > Reviewed-on: https://chromium-review.googlesource.com/1165271
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Yi Gu <yigu@chromium.org>
> > Commit-Queue: Majid Valipour <majidvp@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581552}
> 
> TBR=majidvp@chromium.org,yigu@chromium.org
> 
> Change-Id: If81712c7089784772b5a106159c70bdd7cbce9c8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1167766
> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581653}

TBR=hubbe@chromium.org,majidvp@chromium.org,yigu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icc031d3f40d537316005f0ba7b79a6d8858c9720
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1173071
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582718}

//ios/web_view will implement sync for autofill and passwords in the
near future. This is one of many CLs needed.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I378520039e2be7b4c5827554bad93322ad0b743d
Bug: 865558
Reviewed-on: https://chromium-review.googlesource.com/1141093
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582717}

IWYU. This fixes the libstdc++ build after commit 11484015 ("[Extensions]
Add a static factory to create VerifiedContents").

Bug: 819294
Change-Id: I5fea2d0b22a0a0b70d0a8e5cd5499cb3c0735385
Reviewed-on: https://chromium-review.googlesource.com/1172786Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#582716}

https://webrtc.googlesource.com/src.git/+log/db7ea8c45f39..b336c2784f5e


git log db7ea8c45f39..b336c2784f5e --date=short --no-merges --format='%ad %ae %s'
2018-08-13 zstein@webrtc.org Implement serialization for ICE candidates with hostname addresses.
2018-08-13 yvesg@webrtc.org Don't depend on X11 when rtc_use_x11=false.
2018-08-13 mbonadei@webrtc.org Remove public_deps from rtc_base:protobuf_utils.


Created with:
  gclient setdep -r src/third_party/webrtc@b336c2784f5e

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1d3f7029332b397c8e553ed8fd1f574378c40f3b
Reviewed-on: https://chromium-review.googlesource.com/1173271Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582715}

HistoryCoordinator owns _browsingHistoryService, which is instantiated on start
but its never niled on stop. Since HistoryCoordinator is long lived and
never gets deallocated, _browsingHistoryService keeps listening for notifications.

When the App is being shutdown _browsingHistoryService gets notified of an
Auth change and HistoryTableVC (of which _browsingHistoryDriver holds a reference
of) tries to react accordingly. Since the user is no longer logged in this causes
a background Crash.

This CL nils both pointers so they stop observing once HistoryCoordinator has
been stopped.

Bug: 867452
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id99b4ab481d90eca3a380d5b090631c263b65ef3
Reviewed-on: https://chromium-review.googlesource.com/1171250Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582714}