- 17 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3fe84b5b33b7..3f4f35661151 2020-06-16 natlee@microsoft.com Fix D3D12 Device Initialize calls NextSerial 2020-06-16 bryan.bernhart@intel.com D3D12: Workaround incorrect debug layer error handling 2020-06-16 rharrison@chromium.org Use Tint public header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1094477 Tbr: cwallez@google.com Change-Id: I5968760e43102f1030e7070ec84894fddf8efbca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246906Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779137}
-
Andrey Shponko authored
When popups are removed not in ther order they were added we need to move them down even in inverse mode. This might happen if popups have different TTL for example if some of them require interaction. Change-Id: Id475e5d3c456af7ab09e885767f3eda2d0638e03 Bug: 1009374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829699 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Auto-Submit: Andrey Shponko <ashponko@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#779136}
-
Hirokazu Honda authored
When VideoEncoderClient creates DecoderBuffer from a bitstream encoded by VideoEncodeAccelerator, it sets the size of DecoderBuffer to the entire size of the underlying buffer. This CL fixes the bug; we must rather set the payload size specified by metadata given in BitstreamBufferReady(). Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: Ie3199357c8524143a662973f1475e7a13494434c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247942 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#779135}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b3483d68abd7..ea4aec9cfcd7 2020-06-16 jophba@chromium.org Apply code review feedback for capture_reccs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0102908f26c9b751f6ad7122a658f88db7ed6a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248897Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592330368-995f9d40f9200b48ea66f14ee9d22a1bdedc987c.profdata to chrome-mac-master-1592351803-853e31be24ca6a2ab7be452c8083d82053228cd8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7fc23cf38a784e0a344fe343d38bf8a42d465a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246910Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates FrameHostMsg_UpdateState to UpdateState in FrameHost interface. Bug: 1093919 TEST=RenderViewImplTest.OnNavStateChanged. Change-Id: Ic0bff0c4b03dc10817a3e5e9c994bb6ff7939362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246005Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#779132}
-
Saho Kobayashi authored
Add content change types to mojom to support CONTENT_CHANGE_TYPE_STATE_DESCRIPTION. Android side CL is ag/11788321 crrev/c/2235584 is reverted, because content change types should be int list property, not int property. AX-Relnotes: n/a. Bug: b/154433831 Change-Id: Ie305a99a443079719fc931863c29064699db9764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245945Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Saho Kobayashi <sahok@chromium.org> Cr-Commit-Position: refs/heads/master@{#779131}
-
Gavin Williams authored
This element will be used in CrOS Print Preview to display a printer icon layered with a colored status badge. This element consist of 3 layers. The first layer is a printer icon. The second layer is the background badge which is a circle whose color matches the current background. The third layer is the status badge which is a circle inside the background badge whose color will indicate the status of a the printer. Bug: 1059607 Change-Id: Iafb9b961514f5408c5999dbd71ac82b0ccf60e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234125 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#779130}
-
Zach Trudo authored
ReportQueues will need to respect policy by only storing events when allowed by policy. Added the ability to provide a callback to ReportQueueConfiguration for denying ReportQueue Add calls. Also - minor cleanup deleting unused classes. Bug: chromium:1078512 Change-Id: I1966a94cc40a19c5be065c5e3ff95d0338db231b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241344 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#779129}
-
Frank Liberato authored
This reverts commit 3a58dbb7. Reason for revert: might be causing failures such as: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877299825241158736/+/steps/unit_tests/0/logs/Deterministic_failure:_PasswordSaveUpdateWithAccountStoreViewTest.OnThemesChangedShouldNotCrashForFederatedCredentials__status_CRASH_/0 Change-Id: I94fc317d821105d0ef1d48a796027f6ad710e4c4 TBR: vasilii,treib,bcwhite,twellington,mamir Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249041Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#779128}
-
Andrew Grieve authored
Makes them easier to rename / add / remove. Bug: 1095654 Change-Id: I1af1211eef4a8b305c7f9ed5bf81441abf0aa756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247092Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#779127}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e94de596ef3..4db954eec112 2020-06-16 hbos@webrtc.org Add RTC_EXPORT to webrtc::Resource so that it can be used in Chrome. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3705e8bb9a6af805399899d3ce1d0463196ec9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248904Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec3508aaef7a..f08a82b52dbf 2020-06-16 johnstiles@google.com Return tuple from GrConvexPolyEffect::Make denoting success or failure. 2020-06-16 brianosman@google.com Support viewing/changing backend shaders in Viewer 2020-06-16 fmalita@chromium.org [skottie] Simplify SkColor conversion 2020-06-16 brianosman@google.com Fix caching of HLSL in D3D backend 2020-06-16 adlai@google.com Elevate the target list of Ganesh tasks to base class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I9586a3977a46c10759f164e742fca00b536362fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248919Reviewed-by:
-
Moe Ahmadi authored
Adds an entry for the WebUI NTP experiment on Desktop replacing the non-WebUI (aka local or instant) NTP. The field trial config entry enables NtpWebUI and DisableSearchSuggestChips features. The CL modifies local NTP specific tests to explicitly navigate to the local NTP (chrome-search://local-ntp/local-ntp.html) rather than chrome://newtab/ which displays the WebUI NTP (chrome://new-tab-page). It also adjusts the expectations in other tests to expect an NTP upon opening a new tab but not necessarily an "instant" NTP. Bug: 1075755 Change-Id: I73e48c058e294a4ce8ca22a0b300c2680fdc8795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242194 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#779124}
-
alex linker authored
BUG=1052947 Change-Id: Ie9bfa90de05239a567b4803a27f53d300d1a1639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060393 Commit-Queue: Alex Linker <ajlinker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#779123}
-
Steven Bennetts authored
This CL moves network_health.mojom to chromeos/services to address two issues: 1. The way that the current network_health_resources.grd provides network_health.mojom.html creates a relative path situation that creates a subtle html parsing error (crbug.com/1093958). 2. We need a shared network-health component for oobe and Settings integration. That is added here in ui/webui/resources/cr_components/ and needs access to network_health.mojom (but is not allowed access to src/chrome). This CL addresses both issues to make that future dependency more visible, even though the "shared" component is currently only used in the debugging UI chrome://network. Bug: 1093958, 1076178 Change-Id: I10b9c25a2bf437d0c264213b617b313d0fc4e933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240903 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#779122}
-
Regan Hsu authored
* Narrow mode search icon spacing aligns with search input icon spacing. * No search results aligns with search input text. Screenshot: https://screenshot.googleplex.com/cMF7bYjHk7g results aligned https://screenshot.googleplex.com/DJuWA95Bmhf no results aligned Fixed: 1090166 Change-Id: I6d4ea54e0f54c1ad2f0ab8b7249947c862a39b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242842Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
Tom Anderson authored
This CL connection/capabilities checks when making requests, getting extensions, or waiting for replies. This reduces the amount of checks clients have to make. In particular, clients don't have to check the connection state when making requests. Instead, the request will just generate an empty reply. This fixes a crash due to missing checks when the connection has gone down. This behavior also applies to getting extensions. If an extension was not available, the extension object was nullptr. Now the object is always valid, but makes no-op requests. extension->present() is used to check if the extension is available. The extension getters now return references instead of pointers. Finally, the connection setup data is default-initialized if the connection was never set up. The setup data getters now return references instead of pointers. BUG=1066670,1092691 R=sky Change-Id: I9fd1e9557936a939a6428e959abdd17d55c18726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243841 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779120}
-
Harald Alvestrand authored
Bug: chromium:840659 Change-Id: Ic59d52e78cd145e21e572d196e30d2fbe60375ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248189Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#779119}
-
Rachel Carpenter authored
Creates a field trial to control the first run experience of the Help App. The trial is client controlled because the first run experience happens before a variations seed is available. The trial group chosen on first run is persisted to local state prefs and reused on subsequent runs. This keeps the behaviour of the help app stable between opens. Local state prefs can be reset via powerwash which will results in re-randomisation, but this also sends the user through the first-run flow again so their experience should be consistent from the end of the OOBE (out-of-box experience) onwards. Tracking bug: b/158540665 Launch bug: https://crbug.com/1042109 Tested: Manually, running through the first run experience a few times to determine that the group was randomly selected and correct experience happened for the given group. Bug: b/138969582 Change-Id: Id843af832c0106fecfd6e4544f5c16fd5cb4933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245158Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779118}
-
Peter Kasting authored
Without this, users have to instantiate an ImageSkia just to see what size of an image they have. Bug: none Change-Id: I78f07cbe04b92a62a3932432b8f73f80b7db6857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248891 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Bug: 1014202 Change-Id: I0c50f0bdd3cabec1274256d34941cf134b636cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248666Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779116}
-
Hazim Mohamed authored
Changed GetSharedHandleState to receive file_system parameter by value instead of by const reference in order to facilitate moving the file_system into the returned SharedHandleState. Bug: 1080811 Change-Id: I7ece64b5f36c5b7695308eef41512d49632a515a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248326Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#779115}
-
Tom Anderson authored
This CL switches to x11::Event for most functions, with the minimal changes necessary to continue building. This introduces many no-op diffs that look like this: - bool XYZ::DispatchXEvent(XEvent* xev) { + bool XYZ::DispatchXEvent(x11::Event* x11_event) { + XEvent* xev = &x11_event->xlib_event(); There are a few substantial changes in test code which involve initializing an XProto event in addition to an Xlib event. For most of these, the strategy is to use an intermediate XCB event (which is the wire format) which gets parsed into the Xlib and XProto events. However, for a couple of XInput events, it's easier to directly initialize the Xlib event and the XProto event separately. BUG=1066670 R=nickdiego,sky CC=msisov Change-Id: I987fa17f621e001c352baf75220f0d4f2d4d98d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240355Reviewed-by: -
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I8a6c442ce71a8de0dd1f0a125f3478b82e0f5ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246909Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I085175894bde227be31d4b02d75beb23c726f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248922Reviewed-by:
-
Jarryd authored
In the current state, persistence (durable storage) is granted only to ImportantSites. A list of origins is populated with the following, in order: 1. Origins with high engagement (installed adds to engagement score) 2. Origins with notification permission 3. Origins that have persistence already 4. Origins that are bookmarked The list is then sorted by a calculated score, and then the list is chopped to a max length of 10. This change splits out installed origins from this logic. Now, DurableStoragePermissionContext::DecidePermission() will query ImportantSitesUtil for a set of installed origins and check if the requesting origin is in that set before querying for ImportantSites. If the origin is found to be installed, we can grant the permission and return early. Bug: 933259 Change-Id: I2636f8eb5d4ecc5e58c343ec0ab7ed15ab0ee6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236727Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779111}
-
Bettina authored
Bug: 1069793 Change-Id: I8ebbee52399d1bfc2bc2ce3b7c9bfe89a27619d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248491 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#779110}
-
Wenyu Fu authored
Bug: 1094925 Change-Id: If72bd5ba7c9d97d113ee86944ae71d3c685a5ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248484Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779109}
-
Yu Han authored
Prior to this CL, image input type will always use a Block layout when the image src can't be loaded. This prevents web developers from changing the layout via CSS display property. This CL fixes the issue by creating a Layout object based on the CSS computed styles. Web developers can change image's fallback text layout via CSS display property. If none is passed in, it defaults to inline-block, which is the default layout of the input image type. Spec: https://html.spec.whatwg.org/multipage/rendering.html#images-3:represents-5 Bug: 948066 Change-Id: I907432485472c472608b9d84d36fa2df29412f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212963Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779108}
-
Sammie Quon authored
This will help identify tablet related bugs. Test: none Bug: 1072049 Change-Id: I2fb86d3a246fccf68c0ddebfc7a75ce81cec97c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248676 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#779107}
-
Charlie Hu authored
This CL splits the parsing logic and semantic logic in |FeaturePolicyParser| so that parsing logic can be easily substituted. This is pre-work to implement permission policy parser which uses structured header format. (https://github.com/w3c/webappsec-feature-policy/issues/376) Change-Id: I116e69a562974d21e0d3a53b15cfbb3276b37d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236726 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#779106}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/38accb0f0337..d49aa6fb8b3a 2020-06-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8f6541f41d69837663409d1a5a3199ef4e1836d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246901Reviewed-by:
-
Brian Sheedy authored
Switches the GPU maps pixel tests back to expected colors instead of using Skia Gold. The test is currently too noisy (~1500 unique images in Gold), and while inexact matching is handling the vast majority of these images, it's causing the triage log to be filled with nothing but results for this one test. Additionally, the large number of images is making the diff server (what is used to calculate the diff shown between a particular image and the next closest) quite slow. So, keep this test as an expected color test until some improvements can be made in Gold to address these issues. TBR=kbr@chromium.org Bug: 1078914 Change-Id: I11e5102e90c8df2e294a1898991443b040422ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248492Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779104}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9b15236686b2..4615971566e1 2020-06-16 sugoi@google.com Cleanup: using the proper Image subregion structure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I06b507dc975db30715fffd3dd824f7f1f3d84c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247096Reviewed-by:
-
Becca Hughes authored
Change the link rel type to media-feed and remove the requirement for the type attribute since the rel type is more specific. BUG=1053599 Change-Id: I5ead97e0ed5979cec79e32b9aea14f6b9cd39d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238500Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#779102}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9d2399ea2761..60f6f4105492 $ git log 9d2399ea2..60f6f4105 --date=short --no-merges --format='%ad %ae %s' 2020-06-03 yhong runtime_probe,hardware_verifier: HW compliance check for USB cameras 2020-05-29 fletcherw lorgnette: convert ListScanners to proto impl 2020-06-15 zuan system_api: Add cryptohome UserDataAuth kill switch to features 2019-08-14 kdgwill system_api: Add DBus service constants for CfM Broker 2020-06-09 ahassani dlcservice: Add is_removable 2020-06-05 briannorris shill: wifi: drop all 802.11w parsing, D-Bus property 2020-05-21 akhouderchah hermes: Parse LPA error codes properly 2020-06-09 cylai system_api: build attestation dbus api into go packages 2020-06-09 cylai system_api: gn-format BUILD.gn Created with: roll-dep src/third_party/cros_system_api Bug: b:157577191 Change-Id: Ifc1dafda0feb14d3c2d2210c630e04afef6ab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248887 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Yu Han authored
Prior to this CL, img with CSS height, width and a title attribute is treated as inline text without the CSS dimensions applied. The reason is that title attribute is treated as a backup for alt text [1]. Thus, this prevents the img to be treated as replaced element with intrinsic dimensions [2]:represents-2, but it's treated as non-replaced text [2]:represents-3 where the CSS dimensions are ignored. The fix is instead of checking the HTMLElement::AltText(), check only the presence of alt attribute when determining if the element should be treated as a replaced element. I had considered making the fix in [1] so that AltText() doesn't fallback to title. However, I decided against it to minimized the impact of this change and only fix it when the img doesn't represent an image and defaults to its fallback behavior. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/html_image_element.cc;l=321 [2] https://html.spec.whatwg.org/multipage/rendering.html#images-3 Bug: 958250 Change-Id: I78b3d84d8237b72505fdc5389702d119d61ae405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239473 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Sunny Sachanandani authored
Bug: 1052991 Change-Id: Id0a7f5a98485564f55f343e5711ef69e960c4d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248490Reviewed-by:
-
Lei Zhang authored
Move all of ChromeComponentExtensionResourceManager's data into an inner Data class that initializes normally. Then create an instance of the Data class on demand, instead of during browser startup. Bug: 1095198 Change-Id: Ifce2f3a2ed32db84d8435ea4c8be095876f5a150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247679Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779098}
-
