GitLab

Previously, Expect-CT would enable hard-fail enforcement of
CT for a domain, even if an Enterprise had disabled such
enforcement (via DisableCertificateTransparencyEnforcementForUrls).

Now, Enterprise Policies can be used to disable Expect-CT
enforcement for domains, which aligns with the priority of
constituencies and helps reduce any friction towards enabling
Expect-CT for split-DNS scenarios.

BUG=827170

Change-Id: I7b5cb3891d5726d3755f6d9e15f87050ebec6c7b
Reviewed-on: https://chromium-review.googlesource.com/986553
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546992}

Remove references to RWHVCocoa's setMarkedRange, setSelectedRange, and
updateCursor from RWHVMac.

In -[RWHVCocoa, updateCursor], RWHVCocoa reaches back into the
WebContents to see if a context menu is present. To avoid this reach-
back, move the content of RHWVMac::SetShowingContextMenu to RHWVCocoa.

Bug: 821651
Change-Id: I6052fbc5baefff0f8556336fa96a413bc8ec1f98
Reviewed-on: https://chromium-review.googlesource.com/982976
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546991}

Add "builder:linux_chromium_rel_ng" as a dimension to the bot, so it can
run on the same machines the original bot runs on.

R=nodir@chromium.org, iannucci@chromium.org

Bug: 643346
Change-Id: Ief4a165d796d2a6d14dfc856858293b370b47afc
Reviewed-on: https://chromium-review.googlesource.com/986993Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546990}

This is necessary for certain behavior like Ctrl-Enter in the Omnibox.

Change-Id: I54709f7393099cdaf6d77c766cd8e576d67c9dca
Reviewed-on: https://chromium-review.googlesource.com/986280Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546989}

Test: Manually
Bug: b/76098420

Change-Id: Id9dca95d907453a1e6e11b8cc23f221a9a101443
Reviewed-on: https://chromium-review.googlesource.com/972572
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546988}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic8b6027e3cd202cf159102330c81b1a24c829f92
Reviewed-on: https://chromium-review.googlesource.com/985990
Commit-Queue: Eric Noyau <noyau@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546987}

This CL introduces a page capping infobar, related strings, and
triggering logic from a page load metrics observer. The flow checks if a
feature is enabled and grabs parameters from a related field trial if
there are any. Once the data usage (of the body bytes for completed
requests) extends beyond a threshold, the infobar is triggerred. The
thresholds vary by whether the page load played media or not. This
does not yet introduce page pausing functionality. Although, the goal is
to pause all future requests from the page by plumbing a mojo message to
each related RenderFrame's scheduler.

Bug: 797980, 797976
Change-Id: Ib6a48400c87f1561b10078f38c2d75d0c78ab912
Reviewed-on: https://chromium-review.googlesource.com/953711
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546986}

https://skia.googlesource.com/skia.git/+log/c3bc425bd4d6..04bea3bf76e2

$ git log c3bc425bd..04bea3bf7 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 11231dcb6..ffeadc2cb (1 commit)
2018-03-29 metzman Add libFuzzer style fuzzer for NullGLCanvas for use on OSS-Fuzz.
2018-03-29 robertphillips Fix up .fp files
2018-03-29 csmartdalton vulkan: Blacklist MSAA path renderer on Qualcomm drivers
2018-03-29 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 193fc66b4..11231dcb6 (3 commits)
2018-03-29 halcanary SkAdvancedTypefaceMetrics:  distinguish between font names
2018-03-29 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 115e2853e..193fc66b4 (1 commit)
2018-03-29 jvanverth Snap non-scaled emoji to pixel borders
2018-03-29 djsollen Dump additional details about the gpu resources.
2018-03-29 halcanary SkPDF: type3: more descriptor values
2018-03-29 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 3f0009288..115e2853e (2 commits)
2018-03-29 bungeman Remove path ranges from gpu.

Created with:
  roll-dep src/third_party/skia
BUG=chromium:827225,chromium:b/74435803


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I1caf7c4622a6f5c99f3a99208095ede0a47610ac
Reviewed-on: https://chromium-review.googlesource.com/986891Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546985}

This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/978396

It extracts text from an Android Toast and shows the text in vr toast.

Bug: 819886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If07e91f2f104f12ca44eb22fb661c0df2bc32bdc
Reviewed-on: https://chromium-review.googlesource.com/985209
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546984}

BUG=825295

Change-Id: I73efd6a66ca648c03b05edf706004b62bff86487
Reviewed-on: https://chromium-review.googlesource.com/984380
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546983}

introduces GPay branding on Androoid upstream prompts.

Screenshot with GPay - https://screenshot.googleplex.com/OYXkmzk7Wis
Testing local -  https://screenshot.googleplex.com/AsXL6nw9fLJ (Working as expected)
Testing server with flag off - https://screenshot.googleplex.com/MD0mC5BoivR.png (Working as expected)

Bug: 823814
Change-Id: I6416d715aad35dd8283fb2dfe28f455fc2b02abf
Reviewed-on: https://chromium-review.googlesource.com/949612Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#546982}

This cl adds the followings to Keyboard Shortcut Viewer (KSV):
1. Adds 21 more shortcuts.
2. Test to check changes of Chrome OS available shortcuts.

Bug: 823946
Test: KeyboardShortcutViewerMetadataTest.ModifyAcceleratorShouldUpdateMetadata
Change-Id: I6ae8ef9cb573828eb77210dfea8d57a32b2d8400
Reviewed-on: https://chromium-review.googlesource.com/981440
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546981}

This reverts commit afe2cfbc.

Reason for revert: compile fail on linux-chromeos-dbg

Original change's description:
> ash: Make power button menu animation faster.
> 
> Bug: 826063
> Change-Id: I1930da3effd7952d2019e480048778075a0bcd58
> Reviewed-on: https://chromium-review.googlesource.com/981686
> Commit-Queue: Min Chen <minch@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Qiang Xu <warx@google.com>
> Cr-Commit-Position: refs/heads/master@{#546960}

TBR=derat@chromium.org,minch@chromium.org,warx@google.com

Change-Id: I1e1e7937ce2ff174c37f96ef50370d464bdfe86a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826063
Reviewed-on: https://chromium-review.googlesource.com/986724Reviewed-by: Peter Mayo <petermayo@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546980}

By updating the list of JS builtins that Blink-side tests don't have to
worry about.
Also including one NeedsManualRebaseline annotation that can be removed
once a V8 version with BigInts enabled has rolled into Chromium.

Bug: v8:6791
Change-Id: I094327d1f21156d41960324bf2b2374963acedbc
Reviewed-on: https://chromium-review.googlesource.com/985627Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546979}

Change of mind. Mostly a revert of
https://chromium-review.googlesource.com/c/chromium/src/+/911849.

Test: ash_unittests WindowSelectorTest.*
Bug: 825637
Change-Id: I37bead0a8b1d80cd0c89c646feb5af2a1f0ffa1a
Reviewed-on: https://chromium-review.googlesource.com/986942Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546978}

Using wpt-import in Chromium 0ae02743.
With Chromium commits locally applied on WPT:
d04a1e52 "Revert "bluetooth: FakeBluetoothChooser impl.""
e28b9a97 "Add wpt test for back/forward mouse buttons."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14873

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hta@chromium.org:
  external/wpt/webrtc
jsbell@chromium.org:
  external/wpt/resources
kpaulhamus@chromium.org:
  external/wpt/webauthn
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry

TBR=markdittmer

No-Export: true
Change-Id: Iabdedfe95a406a66c29fe0b0e309db3218f1f5e8
Reviewed-on: https://chromium-review.googlesource.com/986281
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546977}

This implements the WebauthN spec change that permits returning an immediate
and specific error if the user consented to use a key but it was already
registered with the relying party. Formerly, we had to wait for a timeout
and return the generic "NotAllowedError". This way, RPs can let the user
know the reason that registration failed.

Bug: 814870
Change-Id: Ib6f0c9cdd5ca7e3f545c8ce6f3c8e641d672783b
Reviewed-on: https://chromium-review.googlesource.com/984725Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546976}

Locally verified that this fixes the linked bug.

Bug: 823643
Change-Id: Icb7048ce60e46babdae278c1d2b913e44df8f7a5
Reviewed-on: https://chromium-review.googlesource.com/980964
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546975}

We can now easily exercise all the WebVR entry flows, and actually see
the visuals as they oughto to be seen.

BUG=None

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I82da14de7f463a1398ae75b29fe929ab6b3a2821
Reviewed-on: https://chromium-review.googlesource.com/986950Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546974}

Bug: 827112
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5f92210573a235f67cc919ab4b7e2082c3f9b75e
Reviewed-on: https://chromium-review.googlesource.com/986662Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546973}

This patch gives the inline fragmentation edges to
PaintInsetBoxShadowWithBorderRect().

PaintNormalBoxShadow() was fixed in the same way in CL:902780.

This patch almost fixes following tests, but still images do not
match due to pixel differences in round borders.
  fast/box-shadow/inset-subpixel.html
  fast/box-shadow/inset.html

Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic9a026c33941a2ad493e124c9080e5eee4af25db
Reviewed-on: https://chromium-review.googlesource.com/986772Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546972}

Reverses the expectation for some seemingly broken cases, and documents the oddity.

Bug: 827292
Change-Id: I2dc0c859a2a0d68a21b0d0aeec6a6a71f305553f
Reviewed-on: https://chromium-review.googlesource.com/986751Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546971}

Broken down by patchset for easier review.  I lumped them in a single
CL so as not to burden CQ unnecessarily.

Patchset 1: Do not include next_proto.h in url_request_context_builder.h.
Include it in url_request.cc for kProtoUnknown and in
url_request_http_job_unittest.cc for kProtoHTTP11.

Patchset 2: HttpNetworkTransactionTests are not parametrized on protocol
any more.  Remove obsolete comment in CreateWebSocketHandshakeStream.

Patchset 3: Make InitSocketPoolHelper::using_ssl const.  I find this
helpful, because for example HttpStreamFactoryImpl::Job has a lot of
members (like using_spdy_) that are not const, and indeed change value,
so it helps me to explicitly mark constant variables as such.

Patchset 4: Improve FindAvailableSession flow with some early returns.

Patchset 5: Move SequencedSocketData to stack where possible.

Patchset 6: HttpStreamFactoryImpl::Job::SetStream() is only used in
tests, so move it to HttpStreamFactoryImplJobPeer.

Patchset 7: Remove unused HttpNetworkTransaction::SetStream()
declaration.

Patchset 8: Fix almost all complaints of git cl lint (except for one test
being longer than 800 lines).

Bug:

Change-Id: I486a757369d2479ed6fe0b94d040b670c9969443
Reviewed-on: https://chromium-review.googlesource.com/986275
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546970}

The associated bugs have since been fixed.
This change is essentially a revert of cf470d52, but with some edits:

Instead of reverting to CHECK(!async_in_progress_) it restores to an earlier DCHECK(!async_in_progress_).

Bug: 487732, 656692
Change-Id: Ibde40e63a747bddd180ed680ebd63e0f8c729e97
Reviewed-on: https://chromium-review.googlesource.com/986647Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546969}

NOPRESUBMIT=true
This CL was blocked by the presubmit check "net::URLFetcher".
This CL does not add, remove, nor change existing URLFetcher usage.
It adds usage of an existing URLFetcher::RESPONSE_CODE_INVALID constant.
This is deemed reasonable small enough change to bypass the presubmit.

Bug: 820783
Change-Id: I274aeeadc518b9b6ec2af4f2cd97ed0fbddbecb3
Reviewed-on: https://chromium-review.googlesource.com/980714
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546968}

As a follow up to bug fix in 393f5c2e, this adds a unit test for sending CSS
properties in range.

Bug: 826679
Change-Id: I4081bcafd7909c6ed7768ce6515e3fcaaddfc9c8
Reviewed-on: https://chromium-review.googlesource.com/985896
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546967}

This removes the is_syzyasan build flag and related build configuration.
Everything under the SYZYASAN define is either removed, or moved under
ADDRESS_SANITIZER, as e.g. the previously SyzyASAN-only heap corruption
debug URLs.

The DCHECK debug URL is now enabled and the activity tracker grabs a
stack trace when DCHECK_IS_ON(), instead of only under SYZYASAN.

The metrics system sets the is_asan_build bit in the system profile now
under ADDRESS_SANITIZER, against the day when we ship Clang ASAN builds.

The SyzyProf profiling support is removed.

To support the upcoming official build with configurable DCHECKs, the
channel string visible in chrome://settings/help is adorned with "DCheck".

The DEPS to fetch the Syzygy binary archive is left in place, as the
zap_timestamps.exe utility is still in use. Once LLD replaces the MSVC
linker, that can be removed without penalty, at which time the DEPS will
be scrubbed.

Bug: 821764
Change-Id: I08202da8f032f2350a589cfcda9e9b2edd147b7d
Reviewed-on: https://chromium-review.googlesource.com/980912Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546966}

This is a precusor cleanup extracted from
https://chromium-review.googlesource.com/c/chromium/src/+/957760/7
in the broader effort to restrict usage of MessageLoop::current().

This CL was uploaded by git cl split.

R=msw@chromium.org

Bug: 825327
Change-Id: I7d3d65d961089d61bacc89b5de1d526ea0cf94fc
Reviewed-on: https://chromium-review.googlesource.com/986756
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546965}

This CL adds the sync-account-control row in the sync-subpage when
unified-consent is enabled.

This does not apply to CrOS.

Bug: 800972
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie44c5de4702018b7804a54153f70a556b6c45ee2
Reviewed-on: https://chromium-review.googlesource.com/974646
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546964}

These nibs aren't used in polychrome builds, since they always use secondary
Views UI instead of Cocoa.

Bug: 825610
Change-Id: I745b64938254d1cef9a41045888cc1933e7c11d8
Reviewed-on: https://chromium-review.googlesource.com/986477Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546963}

The issue is that different line ending encodings were not properly
handled (\r\n vs \n) in the fingerprint comparison code.  Due to this,
a connection between different platforms, such as Windows to Linux,
would fail the FingerprintMatch verification check and close the
connection.

Note: There may be a better way to normalize the line endings upstream
but I am not familiar enough with WebRTC to make that change.

Change-Id: I03fee025c81bf3c1b5f54204beed5c8d938cbbc8
Reviewed-on: https://chromium-review.googlesource.com/986657
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546962}

This fixes an issue with the support library where we would sometimes
create an InvocationHandler and look up methods using the wrong
ClassLoader. This ensures we always use the correct ClassLoader.

dupeMethod() is only used here, so it's safe to change the signature.

See the crbug for more information.

Bug: 826988
Test: Manual, did this in my demo CL at http://crrev/c/965883
Change-Id: I7ca7bb90aec81a6a30ce4d6393cf40ee54d40c19
Reviewed-on: https://chromium-review.googlesource.com/985631Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546961}

Bug: 826063
Change-Id: I1930da3effd7952d2019e480048778075a0bcd58
Reviewed-on: https://chromium-review.googlesource.com/981686
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#546960}

This reverts commit 328b9d9e.

Reason for revert: Test ran on bots for half day. Started failing after more changes in base/.
I guess the extract didn't run because input arg was missing.

Original change's description:
> Revert "Reland "Android: Add code to parse the CFI info added to the apk""
>
> This reverts commit a06ad561.
>
> Reason for revert: crbug.com/827116
>
> Original change's description:
> > Reland "Android: Add code to parse the CFI info added to the apk"
> >
> > This reverts commit 88328b68.
> >
> > Reason for revert: Attempt fixing cfi bot by removing unwind tables in cfi
> > builds.
> >
> > Original change's description:
> > > Revert "Android: Add code to parse the CFI info added to the apk"
> > >
> > > This reverts commit 1d8b0c00.
> > >
> > > Reason for revert: https://crbug.com/826718
> > >
> > > CL causes failures on Android CFI builder.
> > >
> > > Original change's description:
> > > > Android: Add code to parse the CFI info added to the apk
> > > >
> > > > The previous CL added support for adding unwind tables in apk:
> > > > https://chromium-review.googlesource.com/c/chromium/src/+/956971
> > > > This CL parses and adds test for unwinding on base_unittests_apk.
> > > > The non-official builds do not contain debug info since all bots set
> > > > strip_debug_info=true. So, make sure base_unittests do not take this
> > > > flag.
> > > >
> > > > BUG=819888
> > > >
> > > > Change-Id: Ib69909e14f9f8623ac07154ef60be248558b08a4
> > > > Reviewed-on: https://chromium-review.googlesource.com/958326
> > > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#546343}
> > >
> > > TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org
> > >
> > > Change-Id: Ib9bcb81ffa30861ea91107c1a1f3ccb8f29a7f7d
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 819888
> > > Reviewed-on: https://chromium-review.googlesource.com/983972
> > > Reviewed-by: François Doray <fdoray@chromium.org>
> > > Commit-Queue: François Doray <fdoray@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#546472}
> >
> > TBR=dcheng@chromium.org,primiano@chromium.org,fdoray@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org
> >
> > Bug: 819888
> > Change-Id: Iadb8825988a311c6576c219b9a67e35b45838d7b
> > Reviewed-on: https://chromium-review.googlesource.com/984452
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#546597}
>
> TBR=dcheng@chromium.org,primiano@chromium.org,fdoray@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org
>
> Change-Id: Ib9dab098899b40b8814fb94c3d239d08eecc714f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819888
> Reviewed-on: https://chromium-review.googlesource.com/986572
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546836}

TBR=dcheng@chromium.org,primiano@chromium.org,fdoray@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org,tobiasjs@chromium.org

Change-Id: Ieef28dee93a9270e8de3e1f9e1ca7212178c2465
No-Presubmit: true
No-Tree-Checks: true
Bug: 819888
Reviewed-on: https://chromium-review.googlesource.com/985960
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546959}

HistoryInserter now used the collectionViewModel super class (ListModel) so it can work with both
CollectionItems and TableViewItems.

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I02f170b00ca4957b834d26498084558e0f13de85
Reviewed-on: https://chromium-review.googlesource.com/985476Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546958}

This CL adds a Factory for:
(1) CryptAuthGCMManagerImpl
(2) CryptAuthDeviceManagerImpl
(3) CryptAuthEnrollmentManagerImpl

This pattern is needed for testing a future CL which introduces these 3
classes to the DeviceSync service.

Bug: 824568, 752273
Change-Id: I62b6336e5552b664eb522b893b4049c41343a6d1
Reviewed-on: https://chromium-review.googlesource.com/985894Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546957}

Previously, when a frame A navigates to B, we set and replicated the
origin and a few other things (such as insecure request policy or CSP
headers) prior to calling DidNavigateFrame().  This turned out to be
problematic because DidNavigateFrame() destroys the A frame's subtree
(as part of CommitPending() -> ResetForNewProcess()), which might
trigger unload handlers in the old frame's subframes.  Those unload
handlers would incorrectly see the new frame's origin (B) in the old
frame's proxy.  To fix this, this CL moves DidNavigateFrame() to
be done prior to the replication of origin and other properties.

Bug: 825283
Change-Id: Iff86ac8cad17cfef5349d9bbbc41d8dadd681bb1
Reviewed-on: https://chromium-review.googlesource.com/984729Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546956}

Change-Id: I52ac4148a483010522f0c4e8b2bc480b34b51d61
Reviewed-on: https://chromium-review.googlesource.com/972196
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546955}

* Removes the delegate interface on native side.
* moves fetch request and clear state to Java side
* Adds method for fetching suggestions with clustered resutls
  to the ContextualContentSuggestionsService (shim)

Bug: 824182, 824183
Change-Id: Ia33b79dd4af1219f93b1b1c913ebabb9e05a7dc1
Reviewed-on: https://chromium-review.googlesource.com/982641
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546954}

A change to the window tree can cause occlusion to be computed. If
a WindowDelegate changes the window tree when it is notified that
the occlusion of its window changed, occlusion has to be computed
again.

The number of times that occlusion can be recomputed before it has to
be stable was previously set to 2. This CL increases it to 3 to support
this case:

  Shos tab's WebContents ->
    Compute occlusion (1) ->
    Show modal dialog's WebContents (WebContentsModalDialogManager) ->
    Compute occlusion (2) ->
    Show modal dialog's RenderWidgetHostViewAura ->
    Compute occlusion (3) !!

Once showing or hiding a WebContents no longer involves calling
Show()/Hide() on the aura::Window of a RenderWidgetHostViewAura,
the value can be changed back to 2.

Bug: 827268
Change-Id: I58131b4c3b3dfa71db3075cad21b7f01ddf1b997
Reviewed-on: https://chromium-review.googlesource.com/986742Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546953}