- 17 Oct, 2018 40 commits
-
-
Noel Gordon authored
No-presubmit: true Bug: 895703 Change-Id: If777a1a20b66411d99a5655b72c9a1b957670201 Reviewed-on: https://chromium-review.googlesource.com/c/1285909 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#600300}
-
Greg Thompson authored
This code has been unused since https://crrev.com/402189. BUG=622314 R=pmonette@chromium.org Change-Id: I375cfc911f0c05753476a58f3f5c9dff72b5f181 Reviewed-on: https://chromium-review.googlesource.com/c/1283070Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#600299}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 743cd25e. With Chromium commits locally applied on WPT: 612705b6 "Only update intrinsic_content_logical_height_ if we don't have an override height" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26345 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I01f7dae7b5730e6da09c8ca4fa921f278db4a279 Reviewed-on: https://chromium-review.googlesource.com/c/1286191 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600298}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e9b1cfbe85ce..190645c34266 git log e9b1cfbe85ce..190645c34266 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 thestig@chromium.org Fix assert failure in CPDF_InteractiveForm::GetControlsForField(). Created with: gclient setdep -r src/third_party/pdfium@190645c34266 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895983 TBR=dsinclair@chromium.org Change-Id: I17b47965b5aebdcd2ff53257e1ffddf9887eaf14 Reviewed-on: https://chromium-review.googlesource.com/c/1286110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600297}
-
Luciano Pacheco authored
Update comments for functions. Update closure markup and binding arguments for |wrap| function because this is used in Video Player app. ES6 styles: - Convert var to const. - Convert most anonymous functions to arrow function. Keeping |wrappedCallback| because it shows a bit better in the stack trace. - Convert implicit arguments to ...args, because arguments doesn't work in arrow functions. - Add 'use strict' with anonymous namespace because grit in-lines all JS files together. Bug: 893430 Change-Id: Icaa6271e91b446efe14abc06fbbb44589fac20b7 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1282683Reviewed-by:
-
Alexey Baskakov authored
Bug: none Change-Id: Ic060487e161ca6281700ec381de6f76f38e7abd0 Reviewed-on: https://chromium-review.googlesource.com/c/1286231Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#600295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b061fd7fb603..02bb0496ed00 Created with: gclient setdep -r src-internal@02bb0496ed00 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9743668b663c4c87aefd0f35adb91a129c5a6bfa Reviewed-on: https://chromium-review.googlesource.com/c/1286109Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600294}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9accc9f12be5..28b6d1d238b8 git log 9accc9f12be5..28b6d1d238b8 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2419220c..d06a979d (600044:600199) Created with: gclient setdep -r src/third_party/webrtc@28b6d1d238b8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba1550addcf57b575e64781a1fc1787aad5acc90 Reviewed-on: https://chromium-review.googlesource.com/c/1285567Reviewed-by:
-
Thomas Guilbert authored
Changes expectations of the following tests for ASAN and MSAN: - webaudio/AudioBuffer/huge-buffer.html - webaudio/dom-exceptions.html Bug: 896068 Change-Id: Ic2edbbed567c0f85e38931096c9cf17cea940943 Reviewed-on: https://chromium-review.googlesource.com/c/1285690Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#600292}
-
Mythri Alle authored
Service workers and AppCaches maintain their own code cache and we should not use the cached code fetched from GeneratedCodeCache. Bug: chromium:894321 Change-Id: I31ba1a7b5249e3295da11c8961e1baa71dd2d1ee Reviewed-on: https://chromium-review.googlesource.com/c/1276946Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#600291}
-
Noel Gordon authored
No-presubmit: true Bug: 895703 Change-Id: Ib7996d7f75e2c7bda08bf7ac01b45288e8fb022a Reviewed-on: https://chromium-review.googlesource.com/c/1285889 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie74997cf8e38c503971951a43447b1fdfaa10ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1285790Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#600289}
-
Noel Gordon authored
No-presubmit: true Bug: 895703 Change-Id: I9c56865d92ecf67292c8adc4d41d72b1d5ae1aec Reviewed-on: https://chromium-review.googlesource.com/c/1285869 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
Bug: 895703 Change-Id: I529f7a310c4323cc5a3d87a978e9cbcfe0049fe2 Reviewed-on: https://chromium-review.googlesource.com/c/1285491 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/198b87e5be20..63bc5891e49e git log 198b87e5be20..63bc5891e49e --date=short --no-merges --format='%ad %ae %s' 2018-10-17 egdaniel@google.com Revert "Remove ancient support for kUnknown_SkColorType in SkBitmapDevice" 2018-10-17 halcanary@google.com SkQP-on-GCE: print exit status in logs 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b7688491526..847fc0b278f8 (1 commits) 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-16 herb@google.com Optimize GPU text regen for full pixel position text 2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6eba3c6104f2..d633b1569a21 (1 commits) 2018-10-16 halcanary@google.com SkPDF: refactor generate_page_tree 2018-10-16 herb@google.com Reland "Have GrAtlasManager use legacy behavior" 2018-10-16 reed@google.com remove unused SK_SUPPORT_LEGACY_TEXT_BLOB 2018-10-16 reed@google.com be consistent about int for incReserve 2018-10-16 brianosman@google.com Remove GrColor4f 2018-10-16 bsalomon@google.com Add GrGLInterface support for sampler objects and GrGLCaps detection. 2018-10-16 scroggo@google.com Fix uninitialized errors in SkPngCodec 2018-10-16 brianosman@google.com Switch gradients from GrColor4f to SkPMColor4f 2018-10-16 brianosman@google.com Remove ancient support for kUnknown_SkColorType in SkBitmapDevice 2018-10-16 brianosman@google.com Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES 2018-10-16 brianosman@google.com Remove all remaining GrColor4f (other than gradients) 2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 518142733c90..9b7688491526 (1 commits) 2018-10-16 caryclark@google.com Revert "remove pathop template" 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 33ca7b4f7334..fa2161cf791f (1 commits) 2018-10-16 caryclark@google.com remove pathop template 2018-10-16 brianosman@google.com Reland "Preserve pixel config in makeColorSpace of GPU backed images" 2018-10-16 caryclark@skia.org fix divides for osfuzz 2018-10-16 caryclark@skia.org streamline web documentation 2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 767b41b1a841..518142733c90 (1 commits) 2018-10-16 egdaniel@google.com Re-enable NVPR on flutter. 2018-10-16 kjlubick@google.com Add Correctness tests for CanvasKit 2018-10-16 kjlubick@google.com Blacklist tests for internal bot 2018-10-16 bsalomon@google.com Allow batching of coverage and non-coverage GrTextureOps. 2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a1ac3fe80647..6eba3c6104f2 (1 commits) 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-16 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-10-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@63bc5891e49e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:883666 TBR=egdaniel@chromium.org Change-Id: Ieb5b69ac80fc668b3890492e9f19db675c916c71 Reviewed-on: https://chromium-review.googlesource.com/c/1285563Reviewed-by:
-
Xiaocheng Hu authored
SelectionController's HitTestResultIsMisspelled() unconditionally searches for spellcheck markers under the hit test position, which can be saved if spellchecking is already disabled there. This is also a workaround attempt for the crashes in crbug.com/886589, since the patch reduces the possibility to reach the crash site. Bug: 886589 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iee1ac5c1e44ea3a3452663cae078d6b7125fed38 Reviewed-on: https://chromium-review.googlesource.com/c/1284349 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600285}
-
Adam Rice authored
Change the experiment group for WebSocketHandshakeReuseConnection from "Enabled" to "Shipped" to keep Finch happy. Intent to ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kEtUcy7W0fU/dTyvzUy0BgAJ BUG=423609 Change-Id: Ic55912d6b25d43c33b438da799158c792e878790 Reviewed-on: https://chromium-review.googlesource.com/c/1283529Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#600284}
-
Sam McNally authored
Change NativeFileUtil to allow moving a directory to an existing directory. Bug: 829696 Change-Id: I6e233fa2a9ad161d1457d06fc6b6eda3ab3955d7 Reviewed-on: https://chromium-review.googlesource.com/c/1278624Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#600283}
-
Luciano Pacheco authored
Make Files app select "My files" when there are no available volumes, this to allow Files app to behave properly when volumes subsequently become available. Change DirectoryModel.onVolumeInfoListUpdated_ method to check for non-null |displayRoot| before trying to change to |displayRoot|. This fixes the error "Cannot read property 'getParent' of null" when Drive volume becomes available before the (default) Downloads volume/root. Change FakeDriveFs to unbind the two mojo bindings if they're bound, so DriveFsTestVolume can re-mount itself. Changes since revert: 1. Add a new function |getVolumesCount| to return the number of volumes available in the background page. 2. Add the new function above to wait for background page to have all volumes before un-mounting and wait it to unmount all volumes. 3. Change some logs from error to warn because errors are expected and handled when initializing volumes that are unmounting/unmounted in the backend. 4. Change selector used to click on Drive to actually wait for "My Drive" to be available. 5. A bit of more info in some logs around volume initialization. Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*" Bug: 893161, 884967, 894799 Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890 Reviewed-on: https://chromium-review.googlesource.com/c/1278619Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#600282}
-
Justin Cohen authored
This only affects the kBrowserContainerContainsNTP feature. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I93b1c0844a5071756ff4d2a23f07afb8ac2e4572 Reviewed-on: https://chromium-review.googlesource.com/c/1283840 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600281}
-
Alexey Baskakov authored
Merge these two enums. Move InstallResultCode enum into web_app_constants.h. kInstallationFailed enumerator entry becomes kFailedUnknownReason. TBR=jlklein@chromium.org Bug: 875698 Change-Id: Ia5c2fb46ae0182edf1c8a3b0215f6905ad70f094 Reviewed-on: https://chromium-review.googlesource.com/c/1285871 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL removes unnecessary flags and descriptions for import.meta and dynamic import. - import.meta was shipped in M64: https://www.chromestatus.com/feature/5637509807603712 - dynamic import was shipped in M63: https://www.chromestatus.com/feature/5684934484164608 Bonus: This change stops running duplicate virtual tests for import.meta. Bug: 711706, 773713 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If4de7343f0c5d6b449e50804de6254eb9cc191d0 Reviewed-on: https://chromium-review.googlesource.com/c/1285493Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#600279}
-
Vikas Soni authored
Added comments and link to a crbug to specify reason of using CHECK instead of DCHECK. Bug: 892354 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iadbdf74b8dc3953db5bea137bf6201eaabb547f2 Reviewed-on: https://chromium-review.googlesource.com/c/1282109Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#600278}
-
Leon Han authored
After Mojofication work, blink::SWRegistration no longer needs to rely on content::WebSWRegistrationImpl to handle IPCs, now it can hold/access blink.mojom.SWRegistrationObject(Host) Mojo connections on its own. This CL: - Removes the public interfaces blink::WebSWRegistration(Proxy), instead, creates a new struct blink::WebSWRegistrationObjectInfo to help carry blink.mojom.SWRegistrationObjectInfo from //content into Blink, which is then put into blink::SWRegistration, so that blink::SWRegistration can get the information of blink.mojom.SWRegistrationObject(Host) Mojo connections and use them on its own there. - Moves the (registration_id, SWRegistration object) mapping from //content into Blink: - for a Document, content::SWProviderStateForClient --> blink::SWContainerClient. - for a SWGlobalScope, only one SWRegistration object , still in blink::SWGlobalScope. - Removes content::WebSWRegistrationImpl completely as it becomes useless now. - Removes the intermediate blink::WebNavigationPreloadState struct as Blink starts to manipulate the Mojo connection directly and no longer needs it to help carry data across the boundary of //content and Blink. BUG=789857,879019 Change-Id: Ie47ac2b4b603a9c8e200676febc92d35826ddba2 Reviewed-on: https://chromium-review.googlesource.com/c/1275300 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:Peter Beverloo <peter@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600277}
-
Ryan Hamilton authored
In QUIC, change constants kInvalidStreamId, kCryptoStreamId and kHeadersStreamId to QuicUtils::GetInvalidStreamId(), QuicUtils::GetCryptoStreamId and QuicUtils::GetHeadersStreamId(), respectively. No functional change expected, not protected. Merge internal change: 216559923 https://chromium-review.googlesource.com/c/1285076 Remove MovePacketsForTlsHandshake from crypto_test_utils::MovePackets This is in preparation for CRYPTO frame support: MovePackets will need to handle both stream frames and crypto frames. Unifying MovePackets and MovePacketsForTlsHandshake will mean there is only one place where support for crypto frames will be needed, and no need to handle TLS vs QUIC crypto separately. Merge internal change: 216691240 https://chromium-review.googlesource.com/c/1285094 Update decoding logic for Settings frame to match draft-ietf-quic-http-15 specifications. n/a -unused code. Merge internal change: 216601845 https://chromium-review.googlesource.com/c/1285093 Add a QUIC_BUG if a static streams are not consecutive. (The crypto and headers stream are the first two client created streams.) Merge internal change: 216591657 https://chromium-review.googlesource.com/c/1285092 Pack fields better in BBR bandwidth sampler, so that the struct fits into the cacheline. No functional change. Not flag-protected. Merge internal change: 216532654 https://chromium-review.googlesource.com/c/1285074 In QUIC, reset dispatcher framer's last_packet_is_ietf_quic_ in OnStatelessRejectorProcessDone. Protected by FLAGS_quic_reloadable_flag_quic_fix_last_packet_is_ietf_quic. Merge internal change: 216521060 https://chromium-review.googlesource.com/c/1285090 Groundwork for integrating GoogCC into QUIC. Creates a congestion control type, kGoogCC, which will be used for the GoogCC SendAlgorithm. Adds a platform/ module for creating a GoogCC sender (following the pattern used for PCC). For now, this module falls back to creating a BBR sender. This will be replaced with GoogCC once the SendAlgorithm is implemented. Makes SetSendAlgorithm public on QuicSentPacketManager so that Quartc can set it to use GoogCC without exposing GoogCC for HTTP users. Adds a getter for a mutable sent packet manager to QuicConnection so that Quartc can set the sent packet manager. No functional change, as no existing endpoints will use GoogCC. Merge internal change: 216451657 https://chromium-review.googlesource.com/c/1285089 Rename http_framer to http_decoder so that the design is consistent with QPACK and http_encoder can be introduced. No bahavior change. n/a unused code. Merge internal change: 216437157 https://chromium-review.googlesource.com/c/1284703 Deprecate --quic_restart_flag_quic_check_stream_nonstatic_on_header_list Merge internal change: 216431000 https://chromium-review.googlesource.com/c/1285073 Ensure that all state is copied by value not reference in ProcessClientHelloAfterGetProof. Protected by existing flag FLAGS_quic_reloadable_flag_quic_use_leto_key_exchange Merge internal change: 216348513 https://chromium-review.googlesource.com/c/1284702 Deprecate FLAGS_quic_reloadable_flag_quic_notify_debug_visitor_on_connectivity_probing_sent. Merge internal change: 216337183 https://chromium-review.googlesource.com/c/1284701 Change QUIC connection to process undecryptable packets when a new decryption key is made available, not just when a packet is received. This fixes a gotcha exposed when attempting to enable leto key exchange. Protected by FLAGS_quic_reloadable_flag_quic_decrypt_packets_on_key_change Merge internal change: 216295230 https://chromium-review.googlesource.com/c/1284700 Surface framer.creation_time(). No functional change. Receive timestamps are currently reported to the server relative to framer.creation_time_, which is private to the framer. Having access to this timestamp allows us to report other client events relative to the same clock. For example, we are interested in answering the question: "what is the time delta between when the client sent packet x and received packet y". Merge internal change: 216248770 https://chromium-review.googlesource.com/c/1285070 Change-Id: I1f26f9bea4fdb05713b634a0701bf0aef1919216 Reviewed-on: https://chromium-review.googlesource.com/c/1284759 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#600276}
-
Peter K. Lee authored
Removes specifics for RateThisApp, but retains "chrome_command" for NTP Promo for future use. Bug: 863559 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2c1b19eefe653201983288ae2f016c3a9e0c019a Reviewed-on: https://chromium-review.googlesource.com/c/1281180 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600275}
-
Koji Ishii authored
Spell check document marker, transform, and images in table cells starts showing 1px positioning difference since 10740. This patch rebaselines them after manual review. TBR=eae@chromium.org, mstensho@chromium.org, yoichio@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I75f3082694d54c212e20515f80d650aa0fb925e2 Reviewed-on: https://chromium-review.googlesource.com/c/1286091 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#600274}
-
Fletcher Woodruff authored
Takes expired UMA metrics Platform.Temperature.Sensor0[0-2] and repurposes them for reporting temperature sensors on newer ChromeOS devices. Data pollution is not a problem because this metric will be sliced per device anyways, and the script that is reporting to these metrics currently only runs on one older device. BUG=chromium:850311 Change-Id: If44479dcfb9eefde1a771769fe7f6b9a63189c60 Reviewed-on: https://chromium-review.googlesource.com/c/1279234Reviewed-by:
Justin TerAvest <teravest@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 10686 10690 10701 10710 10714 10716 10726 10735 10740 0 lines were removed and 2 lines were deflaked by consecutive results since 10667. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I43cbbb215b0b14cf0f7ec7e9e724410c09586da4 Reviewed-on: https://chromium-review.googlesource.com/c/1282764 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 03b12adc. With Chromium commits locally applied on WPT: 612705b6 "Only update intrinsic_content_logical_height_ if we don't have an override height" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26344 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0d8a9be0a467f88b2d9faf2dfeabdefe94ec91cc Reviewed-on: https://chromium-review.googlesource.com/c/1285771 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Justin Cohen authored
This enables us to remove the NTP as quickly as possible, without needing to add a single-use WebStateObserver callback. This only affects the kBrowserContainerContainsNTP feature. This CL also removes the use of -GetPendingItem in the NewTabPageTabHelper. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0895b6109eead0aba3cd0f95bd8c1e97e1c4be28 Reviewed-on: https://chromium-review.googlesource.com/c/1283839 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b0b43f3a9e8f..08faab99d41b git log b0b43f3a9e8f..08faab99d41b --date=short --no-merges --format='%ad %ae %s' 2018-10-17 yyanagisawa@chromium.org Set unique build ID. 2018-10-16 ajp@chromium.org Add instructions to check for metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@08faab99d41b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/77176746 TBR=agable@chromium.org Change-Id: Icdc1f9e819c06f9dd8b9f28057c1267814c21f85 Reviewed-on: https://chromium-review.googlesource.com/c/1285696Reviewed-by:
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I21279eb8f71a4a04dd0134f8efe8fcc7969a3456 Reviewed-on: https://chromium-review.googlesource.com/c/1280068Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#600268}
-
Noel Gordon authored
Setup the "Downloads" directory in a SetUpOnMainThread step, where the required profile() first becomes available. "Downloads" is a required resource for FilesApp so enable the FilesApp component extensions _after_ it has been created. Doing the reverse as in the original code caused a data race accessing "Downloads", and the result was systemic test flakiness (issue 477360). Other code health and clean-up: - remove AddMountPoint() not needed anymore: "Downloads" setup is now handled by the SetUpOnMainThread step. - tune code comments make them precise and up-to-date: 'selection-change-complete' was mentioned, but was removed in later refactoring CLs. - add future TODO need to fix a FilesApp issue with CheckJavascriptErrors. - base::ScopedTempDir tmp_dir_ make it the first member of the helper class, so it's dtor() is called last. Life on the bots is more robust that way. No change in behavior, no new tests: disabled tests will be re-enabled in follow-up changes (so the chrome sheriff has an easier job). Bug: 895703 Change-Id: Ib75ee7163ecc3aec62c474f9834ab839ae879dfd Reviewed-on: https://chromium-review.googlesource.com/c/1285830Reviewed-by: -
Jun Choi authored
For WebAuthN UI, modal for showing transport selection list and modal for showing available BLE devices share common style list views. As so, create a shared HoverListView class that represents list view for both BLE device selection modal and transport selection model. The icon and text in views will be controlled by subclasses of HoverListModel. Bug: 877344 Change-Id: Ibfcddc1e5a85ddea3ef8b097c420892d1814f871 Reviewed-on: https://chromium-review.googlesource.com/c/1259783 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600266}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/320ad1ea5c14..b061fd7fb603 Created with: gclient setdep -r src-internal@b061fd7fb603 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2347ee674a39764cea9d9298f3adcc0fa71e7954 Reviewed-on: https://chromium-review.googlesource.com/c/1285562Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d633b1569a21..1d8a783c9db2 git log d633b1569a21..1d8a783c9db2 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 jiajia.qin@intel.com Re-land: "ES31: Add vector and matrix support in SSBO for D3D" 2018-10-16 jmadill@chromium.org Vulkan: Update Android expectations. Created with: gclient setdep -r src/third_party/angle@1d8a783c9db2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie615ae49a56ae7b57abe006d25938dc024f04512 Reviewed-on: https://chromium-review.googlesource.com/c/1285565Reviewed-by:
-
Hirokazu Honda authored
BUG=None TEST=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic3da9a693f8770e4d81b13177df67f94d934c5fc Reviewed-on: https://chromium-review.googlesource.com/c/1248281Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600263}
-
Eliot Courtney authored
the closest edge. Bug: 883098 Bug: 841886 Bug: b/115291749 Test: Drag PIP window to the middle of the screen - it animates back to Test: Added unittests Change-Id: Ibf19f50c4e4298ea126c1a1986f014076e4592f1 Reviewed-on: https://chromium-review.googlesource.com/c/1221010 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#600262}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I755e5d1cff962941e9a10b3e3c2e067a0158182e Reviewed-on: https://chromium-review.googlesource.com/c/1285613Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600261}
-
