- 17 Jul, 2018 40 commits
-
-
Denis Kuznetsov authored
Also add safeguard checks as policy dump might be requested by log upload job at times when not all services might be available for the profile. Bug: 863075 Change-Id: I45a88711c202800f89282dc0028e079bddb4324e Reviewed-on: https://chromium-review.googlesource.com/1136533Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#575649}
-
Georges Khalil authored
Delay the deletion of cloud_policy_client_ so it has time to clean up and avoid the UAF. Change-Id: I57c3afef17f2e07cb89d9fb1e79641c964415b17 Bug: 863933 Reviewed-on: https://chromium-review.googlesource.com/1138411Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575648}
-
Philip Jägenstedt authored
There haven't been any crashes or timeouts in a long time, only normal failures: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=%2Fworkers%2Fopaque-origin.html See https://github.com/web-platform-tests/wpt/issues/11188. Change-Id: I933124b8c406fd202a7d382350cfe259d6607d79 Reviewed-on: https://chromium-review.googlesource.com/1140053 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#575647}
-
Peter Mayo authored
This test is passing in the virtual/sharedarraybuffer/ suite. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any.worker.html Local experimentation indicates this change fixed the timeout: https://chromium-review.googlesource.com/1108744 Bug: 716320 Change-Id: I4091c71917bc79453442d6bd46fd2194be831a60 Reviewed-on: https://chromium-review.googlesource.com/1139379Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
-
Dan Harrington authored
integrity can appear on <link> and <script>. Since all <script> elements are removed, this CL only affects <link>. If a stylesheet is loaded, the integrity attribute is removed when writing MHTML. If the stylesheet didn't load, the <link> element is removed when writing MHTML. Bug: 826139 Change-Id: I5a80a9d07edd995d736b9b6230a805fed51162a3 Reviewed-on: https://chromium-review.googlesource.com/1110263 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#575645}
-
Xiaocheng Hu authored
When TextIterator is passed with iteration range fulled contained in the leading collapsed whitespaces of ::first-letter, it currently doesn't stop in the first letter part, but advances to remaining text with invalid parameters. This patch fixes it by fixing an existing stop condition: - Old condition: stop if the current text box starts at iteration range end - New condition: stop if the current text box start at or after the iteration range end. The condition is also written in a more intuitive way. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2768d41ec5e792353023ca77749575383020ae18 Reviewed-on: https://chromium-review.googlesource.com/1137697Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575644}
-
Owen Min authored
This reverts commit 0b46e1db. Reason for revert: Causing multiple layout tests failed based on findit. Original change's description: > Forms: Add a UseCounter for opening popups while a file chooser is opening > > We'd like to fix a confusing UI issue, and to know the impact > of a possible fix. > > Bug: 637639 > Change-Id: I7af67ac314f61723c7904cf0fee408ac2b60e774 > Reviewed-on: https://chromium-review.googlesource.com/1139940 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575575} TBR=keishi@chromium.org,tkent@chromium.org Change-Id: I4bd3877c33ea7a70a7a7d0d53b7cbb1411240da3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 637639 Reviewed-on: https://chromium-review.googlesource.com/1140393Reviewed-by:
-
Rohit Rao authored
We do not add a blur effect when Reduce Transparency is enabled, which was causing the incognito toolbar to display with a white background. Instead, fall back to the pre-refresh incognito toolbar color. BUG=862860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I55e4305527c19c90faa00672fc2b80321eca7b4c Reviewed-on: https://chromium-review.googlesource.com/1138344Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575642}
-
Chris Lu authored
Bug: None Change-Id: I52e395ad77ddd0c4f9797828500f0b65b4852337 Reviewed-on: https://chromium-review.googlesource.com/1133580Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#575641}
-
Ulan Degenbaev authored
When the user navigates while the infobar is visible, the infobar should disappear. Bug: 808143 Change-Id: I1265409d7299c6ecd5626e2dae855c7724f7fa48 Reviewed-on: https://chromium-review.googlesource.com/1140303 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575640}
-
Peter Mayo authored
https://chromium-review.googlesource.com/1132541 seems to also have fixed these two: layout_ng/fast/block/float/floats-offset-inline-block-strict-line-height.html layout_ng/fast/block/float/floats-offset-image-strict-line-height.html See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/layout_ng/fast/block/float/floats-offset-image-strict-line-height.html%20virtual/layout_ng/fast/block/float/floats-offset-inline-block-strict-line-height.html Bisected locally on linux. Bug: 635619, 734554 Change-Id: If679447ec77b8bd41bf5ea6f7f10846751ce5cd8 Reviewed-on: https://chromium-review.googlesource.com/1140276Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#575639}
-
Marina Ciocea authored
Tests were previously disabled when they started failing (more context in linked bug). Re-enabling because tests pass locally on win7 machine. Bug: 850936 Change-Id: Ie1ab4e82daf2c0265e932237d3edf6b3399ee803 Reviewed-on: https://chromium-review.googlesource.com/1139066Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#575638}
-
Oscar Johansson authored
Instead of using id as sender type this commit specifies which types that are possible to recieve. Bug: 803406 Change-Id: If5a6cfb0c0788b1e2a9e911ae05e9f7dc5e3840d Reviewed-on: https://chromium-review.googlesource.com/1140166 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575637}
-
Tarun Bansal authored
Send the transport RTT over the mojo channel to the browser process. The transport RTT is sent over an existing mojo message which carrier the other network quality estimates. The mojo message is sent only if there is a significant change in the values of the estimates. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ief33a27239e88b368cf403b4578bfde329bbabbf Bug: 819244 Reviewed-on: https://chromium-review.googlesource.com/1139084Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#575636}
-
Douglas Creager authored
Per https://github.com/WICG/network-error-logging/issues/73, we need to add the request method to NEL reports. Bug: 748549 Change-Id: I306ce389612a8ac794be732a47744b18db8cb4e2 Reviewed-on: https://chromium-review.googlesource.com/1118525Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#575635}
-
Emil A Eklund authored
The layout/latin-complex-text performance micro-benchmark isn't relevant anymore as all text, regardless of script, uses the same text code path. Furthermore by continuously laying out the same test it effectively only tests the efficiency of the word cache in a way that is quite dissimilar from real world use cases. Instead replace it with two tests that each render a rather large e-book split into paragraphs and using text formatting, more closely resembling typical use cases. The first test (latin-ebook) measures layout time for the entire content of the ebook and the second test (latin-ebook-resize) does the same but then also resizes the container to simulate the window being resized or the screen orientation changing triggering text reflow. Change-Id: Ia44b016d8734cadacd8bc9027c590377f342902e Reviewed-on: https://chromium-review.googlesource.com/1139933Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#575634}
-
Michael Lippautz authored
TraceWrappers does not exist anymore. Change-Id: I94479ebf0b995226aa7d4e3ce8495d51128e97b6 Reviewed-on: https://chromium-review.googlesource.com/1140165Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575633}
-
Gaofeng Huang authored
Bug: internal b/110987586 Change-Id: I72260f79c235e37fc37b6a0649b16d3b9783196a Reviewed-on: https://chromium-review.googlesource.com/1127858Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#575632}
-
Igor Eremeev authored
Strings in |MapFileParser| may contain concated thin archive paths like "path/to/lib.a(../../path/to/object.o)". Normpath treats it as a path and resolves second .. by removing the "lib.a(.." part. It breaks thin archives processing, resulting in exceptions up the stack in |archive| on calls to "rindex('(')". Solution: thin archive paths do already get their paths normalized later in |ar.CreateThinObjectPath|. So just skip them at this point. R=huangs@chromium.org,agrieve@chromium.org Change-Id: I83bffca44eba2a56c0ffdbfc8c83cd2785fb8b56 Reviewed-on: https://chromium-review.googlesource.com/1140298Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#575631}
-
Olivier Robin authored
- Create test utils - Move the FormActivityTabHelper from WebStateObserver to Script callback - Remove all the methods from WebState and WebStateObserver. Bug: 823285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0953a91144524018dbff154b2ff5b7bd18e17013 Reviewed-on: https://chromium-review.googlesource.com/1133000 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#575630}
-
Michael Lippautz authored
- Move its naming functionality to NameClient. - Add unit tests for NameTrait Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8da5e7959c3b79492c0babba8d2a0bdc5ca634c5 Reviewed-on: https://chromium-review.googlesource.com/1140160 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Naoki Fukino authored
Although "Play files" root directory is writable in file system level, we prohibit write operations on it in the UI level to avoid confusion. Users can still have write access in sub directories like Play files/Pictures, /Play files/DCIM, etc... Bug: 851345 Test: Manually tested on Kevin Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib5052088aa75a934646081c18c5266fa3fbbac28 Reviewed-on: https://chromium-review.googlesource.com/1140173Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#575628}
-
Colin Blundell authored
Came out of an offline discussion about the ambiguity between placing such code in //components or //third_party/blink/common. Change-Id: Icc4f4d6edc2af78dfc145d2c5cb54caef7d5f04e Reviewed-on: https://chromium-review.googlesource.com/1138155 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Martin Šrámek authored
Bug: 850501 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4dc21e7ef5cc1ca6fcde18445dfe4365febcb449 Reviewed-on: https://chromium-review.googlesource.com/1135537Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#575626}
-
Shakti Sahu authored
Added a feature flag "DownloadHomeV2" to enable or disable the new download home. Bug: 850603 Change-Id: I3e429ab5a6e2afd0ddc36e6052b0ee2baae349d4 Reviewed-on: https://chromium-review.googlesource.com/1137841 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575625}
-
Oscar Johansson authored
When building using jumbo, interfaces and implementations end up in the same scope. The interfaces with the same category name conflicts. This commit solves the issue by renaming the category to something more file specific. Bug: 803406 Change-Id: I21a6645640d40b0ed6cd1324dfc30efa87da23c0 Reviewed-on: https://chromium-review.googlesource.com/1140162Reviewed-by:
-
Naoki Fukino authored
Bug: 864449 Test: Manually tested both Enable/Disable options. Change-Id: I57a768421e3a86e1bae63c72f1467911ddb6096f Reviewed-on: https://chromium-review.googlesource.com/1140110Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 7953 7954 7956 7959 7960 7961 7962 7967 7986 7988 7991 7995 7998 8008 8013 TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia160044568587e39dcf25d2a40618ae86a4dbdb4 Reviewed-on: https://chromium-review.googlesource.com/1137801 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9c98576bceff..94fee93c9b23 git log 9c98576bceff..94fee93c9b23 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 robertphillips@google.com Reduce arbitrary opList splitting when sorting Created with: gclient setdep -r src/third_party/skia@94fee93c9b23 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I8ed1316abb15379572c0d2d88f2bff1adf587b23 Reviewed-on: https://chromium-review.googlesource.com/1139918Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575621}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4d831cea60c7..0b69a335b882 git log 4d831cea60c7..0b69a335b882 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 michaschwab@google.com Merge "Handle Resize" 2018-07-16 michaschwab@google.com Handle Resize Created with: gclient setdep -r src/third_party/perfetto@0b69a335b882 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0ae10fdbb340d13a6003648690246e48f24a00b9 Reviewed-on: https://chromium-review.googlesource.com/1139917 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575620}
-
Kush Sinha authored
Add an 'Add account' button in Chrome OS Account Manager's account list page in Settings. Bug: 833797 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id1626114bcfda15c6c1b2a549cde152045dfac84 Reviewed-on: https://chromium-review.googlesource.com/1105773 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#575619}
-
Gauthier Ambard authored
This CL don't trigger the new animation for OpenInNewTab when the TabStrip is present as the TabStrip already have an animation. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2cb7a5e67695b2249373a519e6521523dfa0354d Reviewed-on: https://chromium-review.googlesource.com/1140159Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a new animation for the location bar when the omnibox is focused and defocused. Bug: 821809 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1eeeccc99322bb2ad67e7bd75d24578066451c8f Reviewed-on: https://chromium-review.googlesource.com/1131749Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 4c7b65f6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 575597 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjN2I2NWY2MzA3YTI3ODA4NDhkMzFjYjgxZWRlODg1NjQzNzcyMTAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6868 Sample Failed Step: browser_tests Original change's description: > Fill username field with prefilled values by server hints. > > This CL is implementation of overriding of prefilled values in username > fields if the server believes that these values are placeholders. > > The life of server prediction for filling prefilled values is the > following (it's called may_use_prefilled_placeholder in code): > 1. The server sends it and it's propagated as part of FormStructure to > FormParser (it's implemented before this CL). > 2. It's parsed in password_field_prediction.cc to PasswordFieldPrediction > 3. FormParser puts it to PasswordForm. > 4. In password_form_fill_data.cc it's propagated to PasswordFormFillData > 5. It's sent to the renderer over MOJO > 6. PasswordAutofillAgent uses it to override prefilled values if any. > > The reason of putting processing may_use_prefilled_placeholder in > FormParser not in NewPasswordFormManager is that NewPasswordFormManager > should know nothing about form structure, it's FormParser responsibility > to process it. > > Small deletion of dead code is done: parameter |set_selection| from > FillUserNameAndPassword, since it's never set to true. > > Bug: 847793, 831123 > Change-Id: Id86d0992428e520718a6ab6e9f50e8064444d030 > Reviewed-on: https://chromium-review.googlesource.com/1124474 > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575597} Change-Id: Ibcea367414987035718f8010320921bc851dc406 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847793, 831123 Reviewed-on: https://chromium-review.googlesource.com/1140213 Cr-Commit-Position: refs/heads/master@{#575616}
-
Henrik Boström authored
Make hbos@... 1. per-file web_rtc_* OWNER of third_party/blink/renderer/platform/exported hbos@ is already per-file web_rtc_* OWNER of third_party/blink/public/platform. This is where the header files of interfaces are placed, but often times the .cc files which are placed in "exported" need to be modified too for things like out-of-line constructor and destructor. 2. per-file testing_platform_support_with_web_rtc.* OWNER of third_party/blink/renderer/platform/testing/. Any substantial changes in WebRTC requires updating some "platform" interface and then these files have to be updated to update the mocks. We frequently have to bring in non-webrtc reviewers for the sake of stamping some minor webrtc interface being updated. The webrtc reviewers already do a good job of reviewing these things, better to make a webrtc owner OWN these few files too. NOTRY=True Bug: 777617 Change-Id: Ie0e5dbd43d93df89524c50bed3683f681d47778d Reviewed-on: https://chromium-review.googlesource.com/1140063Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#575615}
-
Brian Osman authored
This enum is going away, and is always assumed to be kIgnore within Skia. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1d330478aab486864395ef36762f12f3df76c4d2 Reviewed-on: https://chromium-review.googlesource.com/1135551Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#575614}
-
Ramin Halavati authored
The default storage for OverlayUserPrefStore which is used for incognito preferences is the persistent storage in the regular profile, and preference types that should not be stored there must be enumerated in CreateIncognitoPrefServiceSyncable. This is changed so that the default storage is in memory, and preferences that need a persistent storage would need enumeration. Bug: 861722 Change-Id: Ia4c8f655752a07f81fb6d35685876cd252118999 Reviewed-on: https://chromium-review.googlesource.com/1128753 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#575613}
-
Greg Kraynov authored
Long live base::TestMockTimeTaskRunner. Bug: 863350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id3df59c1fb1588e95e0135c7c6a90cfad47d29f1 Reviewed-on: https://chromium-review.googlesource.com/1140062 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#575612}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f1b3e80f..dcf3638e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a8194643473bf816ddc6aa84c362e4a747cb058 Reviewed-on: https://chromium-review.googlesource.com/1139909Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575611}
-
Greg Kraynov authored
Bug: 863350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74b5ab9428ec1b5452c374f4c9dccea7e26612ab Reviewed-on: https://chromium-review.googlesource.com/1138313 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
-
