Commits · 07ee2dfbb1ed09b2be2a01f79a50b7e4a7403c4e · eriksson monteiro / tangled

14 Apr, 2014 29 commits

Use document's contentSize when the HTML element is selected. · 07ee2dfb

mlamouri@chromium.org authored Apr 14, 2014

HTMLHtmlElement's size might not be the size of the document, such as
HTMLBodyElement's size, so when the selection root in the html element,
the best thing we can do is get the size of the content because <html>
and <body> might have a different size.

BUG=361927

Review URL: https://codereview.chromium.org/236083003

git-svn-id: svn://svn.chromium.org/blink/trunk@171441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

07ee2dfb

Avoid using cross RenderView selection rendering · 3c7b2431

yosin@chromium.org authored Apr 14, 2014

This patch makes sure we pass |RenderObject| belong to RenderView in
|RenderView::setSelection|, which takes two |RenderObject|s for start and end of
selection, in |FrameSeleciton::updateAppearance|.

The bug is caused by |VisibleSelection::base| and |VisibleSelection::start|
are in different document, |base| points to IFRAME and |start| points |TextNode|
in IFRAME. This causes |RenderView|, which holds |RenderObject|s of selection
start points and end points, have dangling |RenderObject|'s. Because,
|RenderView| doesn't know destructed |RenderObject| belongs to another
|RenderView|.

BUG=356690
TEST=LayoutTests/undo/execCommand/crash-redo-with-iframes.html

Review URL: https://codereview.chromium.org/234463003

git-svn-id: svn://svn.chromium.org/blink/trunk@171440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3c7b2431

Web Animations: Fix effect change calculation when player is cancelled but not held · 339b6e09

dstockwell@chromium.org authored Apr 14, 2014

Review URL: https://codereview.chromium.org/235503010

git-svn-id: svn://svn.chromium.org/blink/trunk@171439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

339b6e09

Simplify CRC2D winding rule handling · a551cb3d

fs@opera.com authored Apr 14, 2014

Since the bindings already check the enumeration, there's no need to
check that the value passed is valid. Make the parseWinding helper function
just return the translated value instead of a status boolean.

Review URL: https://codereview.chromium.org/226733004

git-svn-id: svn://svn.chromium.org/blink/trunk@171438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a551cb3d

Mark virtual/gpu/fast/canvas/canvas-composite-stroke-alpha.html as flaky in... · 42f32869

hayato@chromium.org authored Apr 14, 2014

Mark virtual/gpu/fast/canvas/canvas-composite-stroke-alpha.html as flaky in WebKit Win Oilpan (dbg), WebKit Win7 (dbg)

This test looks flaky for a long time in [WebKit Win Oilpan (dbg), WebKit Win7 (dbg)].

I can't tell the exact possible revision from the dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-composite-stroke-alpha.html

TBR=leviw@chromium.org
BUG=363029

Review URL: https://codereview.chromium.org/236633005

git-svn-id: svn://svn.chromium.org/blink/trunk@171437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

42f32869

Replace Selection.collapse() with Selection.removeAllRanges() in layout tests. · c0ce2ed0

yoichio@chromium.org authored Apr 14, 2014

There are some tests calling Selection.collapse(null).
Selection.collapse(null) clears the current selection and its behavior is essentially same as Selection.removeAllRanges().
However, the Selection.collapse method is intended to create a range forming a caret:
https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-collapse
Calling Selection.collapse(null) to clear the selection is non-standard and I'm going to change Selection.idl to restrict such a usage.

BUG=361941

Review URL: https://codereview.chromium.org/236693002

git-svn-id: svn://svn.chromium.org/blink/trunk@171436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c0ce2ed0

Check isUserActionElement() instead of separate hover/active/focus checks in supportsStyleSharing() · 4e7eb2f4

esprehn@chromium.org authored Apr 14, 2014

Since we check all the different states of being a user action element we
should just check the primary bit instead. This function is super hot so
avoiding some branches helps.

This will make us not share for elements in the "active chain", but in the
common case that's the same as the regular :active elements unless you mutate
the elements in the :active state inside an action (ex. click)

Review URL: https://codereview.chromium.org/236153005

git-svn-id: svn://svn.chromium.org/blink/trunk@171435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4e7eb2f4

Fix lint error in TimelinePanel.js due to 'energy' variable. · e434aca2

jbroman@chromium.org authored Apr 14, 2014

This error was introduced in: https://codereview.chromium.org/220963002

BUG=

Review URL: https://codereview.chromium.org/236083009

git-svn-id: svn://svn.chromium.org/blink/trunk@171434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e434aca2

DevTools: support importing layer tree from trace snapshots. · 190ba677

caseq@chromium.org authored Apr 14, 2014

BUG=

Review URL: https://codereview.chromium.org/224843014

git-svn-id: svn://svn.chromium.org/blink/trunk@171433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

190ba677

Remove unused WebScreenInfoFactory. · 5fdfa102

mlamouri@chromium.org authored Apr 14, 2014

BUG=90115

Review URL: https://codereview.chromium.org/235503008

git-svn-id: svn://svn.chromium.org/blink/trunk@171432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5fdfa102

Remove dead code from HTMLElement::parseAttribute · c1913b02

esprehn@chromium.org authored Apr 14, 2014

Element::parseAttribute does nothing so there's no reason to have a
special case to call it for id, class and style attributes.

Review URL: https://codereview.chromium.org/236363005

git-svn-id: svn://svn.chromium.org/blink/trunk@171431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c1913b02

DevTools: remove references to fields absent in protocol.json's CSSStyle · 896b0ee9

caseq@chromium.org authored Apr 14, 2014

TBR=apavlov,pfeldman

Review URL: https://codereview.chromium.org/236613003

git-svn-id: svn://svn.chromium.org/blink/trunk@171430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

896b0ee9

Mark http/tests/images/webp-partial-load.html as flaky in all platforms. · 55a4ee5d

hayato@chromium.org authored Apr 14, 2014

This test looks flaky also in linux.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fimages%2Fwebp-partial-load.html

TBR=leviw@chromium.org
BUG=313846

Review URL: https://codereview.chromium.org/236793002

git-svn-id: svn://svn.chromium.org/blink/trunk@171429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

55a4ee5d

Revert of Gardening: fast/workers/worker-multi-startup.html is crashing on... · 2c295c24

jochen@chromium.org authored Apr 14, 2014

Revert of Gardening: fast/workers/worker-multi-startup.html is crashing on Linux (https://codereview.chromium.org/226653003/)

Reason for revert:
passes again

Original issue's description:
> Gardening: fast/workers/worker-multi-startup.html is crashing on Linux
> 
> Appears to be from a v8 roll.
> 
> TBR=dcarney@chromium.org
> BUG=362146
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171291

TBR=dcarney@chromium.org,leviw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=362146

Review URL: https://codereview.chromium.org/236773002

git-svn-id: svn://svn.chromium.org/blink/trunk@171428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2c295c24

Avoid hash table lookup for every attribute · dfaecc1e

esprehn@chromium.org authored Apr 14, 2014

We should avoid looking at the hash table of event handler attributes
for all attributes which don't start with "on", which is most attributes.

Review URL: https://codereview.chromium.org/228943008

git-svn-id: svn://svn.chromium.org/blink/trunk@171427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dfaecc1e

Assert that Length::blend is called with specified values · 6422bf23

timloh@chromium.org authored Apr 14, 2014

The checks in Length::blend for non-specified values were for the old
CSS animations/transitions code paths which have now been removed. We
should no longer get into Length::blend with non-specified values.

BUG=

Review URL: https://codereview.chromium.org/234413004

git-svn-id: svn://svn.chromium.org/blink/trunk@171426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6422bf23

IDBFactoryBackend -> IndexedDBClient, remove indexeddb/chromium · b950382e

jsbell@chromium.org authored Apr 14, 2014

Tidy up some naming and layering split from the WebKit days.

Review URL: https://codereview.chromium.org/225023020

git-svn-id: svn://svn.chromium.org/blink/trunk@171425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b950382e

Web Animations: Time to effect change should be infinity when player is held · 20c01b1c

dstockwell@chromium.org authored Apr 14, 2014

This was causing frames to be requested continuously when animations were paused.

Review URL: https://codereview.chromium.org/230503002

git-svn-id: svn://svn.chromium.org/blink/trunk@171424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

20c01b1c

Webfont CORS-enabled fetching with fallback · d9041775

bashi@chromium.org authored Apr 14, 2014

Use CORS-enabled fetch method for webfonts. If the CORS-enabled fetch
fails, make a second CORS-disabled request so that we won't break
existing webpages which don't honor the css3 font spec.

We also collect CORS failure counts.

BUG=286681
R=ksakamoto@chromium.org, japhet@chromium.org

Review URL: https://codereview.chromium.org/230383003

git-svn-id: svn://svn.chromium.org/blink/trunk@171423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d9041775

Simplify whitespace handling in build/ Jinja templates · 9e4a049c

nbarth@chromium.org authored Apr 14, 2014

No change to generated code, just cleanup.

This adds the flags:
lstrip_blocks=True
trim_blocks=True
...to the Jinja environment setup

This means we don't need {%- everywhere, and also allows us to indent control blocks.

(Other than that, a few consistency fixes of {{ foo() }} => {{foo()}} and " => ')

This CL does not change generated code, to simplify testing and review.
This turned up lots of minor whitespace errors or warts, which I've marked
with FIXME and will fix in a followup.

R=abarth

Review URL: https://codereview.chromium.org/236673002

git-svn-id: svn://svn.chromium.org/blink/trunk@171422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9e4a049c

Fix deps problems in Jinja template use in build/scripts · 41f59a89

nbarth@chromium.org authored Apr 14, 2014

Three targets are missing correct Jinja template dependencies:
* MediaFeatureNames
* MediaFeatures
* MediaTypeNames
This fixes them, so they rebuild properly.

Also minor style/order fixes.

R=abarth

Review URL: https://codereview.chromium.org/235673007

git-svn-id: svn://svn.chromium.org/blink/trunk@171421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

41f59a89

[FastTextAutosizer] Do not pre-inflate nested tables · 15346c01

pdr@chromium.org authored Apr 14, 2014

Instead of pre-inflating all children in inflateTable(), this patch only
pre-inflates non-table children. This fixes a bug where nested tables
had their cell widths inflated with their parent table's multiplier but
ended up not being inflated at all--leading to extra wide cells.

This fixes a bug on codereview.chromium.org where people's names would
have extra space around them (http://pr.gg/tablewidth.png).

There is the potential for regressions with this change if a table has
enough text to autosize but where the width ends up being less than
100% of the containing <td>. The real world impact script showed no
changes on the top 100 websites and hackernews (the canonical nested-
table mess) renders fine after this change.

BUG=362930

Review URL: https://codereview.chromium.org/235943003

git-svn-id: svn://svn.chromium.org/blink/trunk@171420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

15346c01

Oilpan: Enable Oilpan in modules/encoding · 0842b924

haraken@chromium.org authored Apr 14, 2014

BUG=340522

Review URL: https://codereview.chromium.org/234863002

git-svn-id: svn://svn.chromium.org/blink/trunk@171419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0842b924

Use ScriptPromiseResolverWithContext. · eb787c95

yhirano@chromium.org authored Apr 14, 2014

Use ScriptPromiseResolverWithContext instead of a pair of
ScriptPromiseResolver and NewScriptState.
This CL doen't change the behavior in many cases: The only exception
is when the resolution / rejection happens on the suspended or stopped
ExecutionContext. In such a case, ScriptPromiseResolver suspends or stops
resolution or rejection.

R=ksakamoto@chromium.org
BUG=352552

Review URL: https://codereview.chromium.org/236123007

git-svn-id: svn://svn.chromium.org/blink/trunk@171418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

eb787c95

Avoid looking at invalidation sets in a SubtreeStyleChange subtree · 76e0f464

esprehn@chromium.org authored Apr 14, 2014

We were matching all the rulesets in a subtree even after finding a ruleset
that would invalidate the whole subtree which is wasted work. We were also
storing all the invalidation sets for an element even after one of them
would have invalidated the entire subtree.

This patch makes us only ever store one invalidation set for an element once
one of them would invalidate the whole subtree. It also removes the
foundInvalidationSet() bit since that's identical to just checking if the
Vector of invalidation sets is non-empty.

I also removed an ASSERT(renderer->style()), all renderers have a style, so
there's no reason to check this.

Review URL: https://codereview.chromium.org/233243003

git-svn-id: svn://svn.chromium.org/blink/trunk@171417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

76e0f464

Oilpan: Enable Oilpan in modules/notifications · 7abff637

haraken@chromium.org authored Apr 14, 2014

BUG=340522

Review URL: https://codereview.chromium.org/234823003

git-svn-id: svn://svn.chromium.org/blink/trunk@171416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7abff637

Element::focus() should acquire the reference of LocalFrame. · 1ddf408f

yutak@chromium.org authored Apr 14, 2014

FrameSelection::setSelection() may cause some DOM events to happen synchro-
nously, which could free the frame and produce a dangling pointer to the frame.

This patch extends the lifetime of the frame object and fixes this use-after-
free.

BUG=357669

Review URL: https://codereview.chromium.org/225163004

git-svn-id: svn://svn.chromium.org/blink/trunk@171415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1ddf408f

Pass script state to Web API object->script wrappable converter. · c150a472

dominicc@chromium.org authored Apr 14, 2014

This is required to create script wrappable objects which depend on
their execution context, such as EventTargets and ActiveDOMObjects.

BUG=349919
TBR=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/236133002

git-svn-id: svn://svn.chromium.org/blink/trunk@171413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c150a472

Remove EditableLinkBehavior, which is always set to NeverLive by Chromium. · e4d436b4

jbroman@chromium.org authored Apr 14, 2014

On the Chromium side, there's a comment that this is unlikely to ever change.
And indeed it has never changed since the initial commit of webkit/ in 2008.

Thus this code is dead in Blink and should be removed.

Chromium CL: https://codereview.chromium.org/236163005/

BUG=362961
TEST=ManualTests/contenteditable-link.html

Review URL: https://codereview.chromium.org/236203005

git-svn-id: svn://svn.chromium.org/blink/trunk@171412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e4d436b4

13 Apr, 2014 6 commits

Revert "Modify supercluster multiplier logic" (http://crrev.com/231663006 ). · 4d412f79

skobes@chromium.org authored Apr 13, 2014

Appears to be causing crashes on Android perf bots.

BUG=362975
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/235993003

git-svn-id: svn://svn.chromium.org/blink/trunk@171409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4d412f79

Canvas element that use the alpha attribute don't display correctly. · e9df6e54

jinho.bang@samsung.com authored Apr 13, 2014

Current blink is delaying the creation of the backing store until drawing something.
When alpha is false, the backing store must be initialized to opaque black instead of transparent black.

BUG=352018

Review URL: https://codereview.chromium.org/200003002

git-svn-id: svn://svn.chromium.org/blink/trunk@171408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e9df6e54

Remove Mac char code from PlatformKeyboardEvent. · aa28ac46

jbroman@chromium.org authored Apr 13, 2014

This field is never read.

BUG=362927

Review URL: https://codereview.chromium.org/236403002

git-svn-id: svn://svn.chromium.org/blink/trunk@171407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

aa28ac46

[FastTextAutosizer] Do not inflate table parts that do not need layout · 076465d5

pdr@chromium.org authored Apr 13, 2014

FastTextAutosizer::inflateTable pre-inflates table cells so that
the table layout algorithm has an upper bound for table cell sizes.
After inflateTable pre-inflates cells, the layout pass will come
around and correctly size cells through beginLayout(). This patch
fixes a bug where cells were pre-inflated without later being laid out.

The bug that affected codereview.chromium.org and amazon.com both
involved nested tables with images. When images load, they can
force a layout up their parent chain because their size can change.
During layout, we would then call inflateTable and pre-inflate the
entire table but only the image's cell would actually get laid out.

BUG=357299

Review URL: https://codereview.chromium.org/236033005

git-svn-id: svn://svn.chromium.org/blink/trunk@171406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

076465d5

Screen Orientation API: cleanup, simplify and fix implementation. · bb0ae355

mlamouri@chromium.org authored Apr 13, 2014

This CL creates new types to better reflect screen orientation types. It
also simplify ScreenOrientation.cpp, following spec simplifications.
Finally, there are some changes related to |m_lockedOrientations| that
was a bit buggy by nature, assuming that only the current fram could
change the locking.

BUG=162827

Review URL: https://codereview.chromium.org/219463003

git-svn-id: svn://svn.chromium.org/blink/trunk@171405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bb0ae355

Set track_start on solid color layers to the margin. · 5f9b6826

aelias@chromium.org authored Apr 13, 2014

The scrollbar margin on the overlay scrollbar theme is used to distance
the thumb from the edge of the screen on all sides, not just the
widthwise side.  This was already computed properly in the theme's
TrackRect, but it wasn't communicated to the WebScrollbarLayer.

Also, shrink the margin to 3 DIPs on Android, which on closer inspection
better matches the system theme.

Chromium-side change at https://codereview.chromium.org/234603002/
NOTRY=true
BUG=361923

Review URL: https://codereview.chromium.org/234613002

git-svn-id: svn://svn.chromium.org/blink/trunk@171404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5f9b6826

12 Apr, 2014 5 commits

Mark Supplement instead of RefCountedSupplement in NavigatorContentUtils · e953d055

gyuyoung.kim@samsung.com authored Apr 12, 2014

There is no big reason that NavigatorContentUtils should use RefCountedSupplement. This CL marks the NavigatorContentUtils to use Supplement instead of RefCountedSupplement. Additionally this cl adds a tracing method for supplement.

BUG=none

Review URL: https://codereview.chromium.org/235023003

git-svn-id: svn://svn.chromium.org/blink/trunk@171403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e953d055

Make sure resource client is called asynchronously · 53dc1287

hclam@chromium.org authored Apr 12, 2014

Certain type of resources must have their clients notified
asynchronously.

BUG=352043

Review URL: https://codereview.chromium.org/231873006

git-svn-id: svn://svn.chromium.org/blink/trunk@171402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

53dc1287

Remove unnecessary codes in FileInputType.cpp. · 643e03e2

jincheol.jo@navercorp.com authored Apr 12, 2014

It seems not to needed. 
The variable "paths" is not used.

Review URL: https://codereview.chromium.org/235933005

git-svn-id: svn://svn.chromium.org/blink/trunk@171401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

643e03e2

Support sideloaded fonts for DirectWrite · d161d86e

scottmg@chromium.org authored Apr 12, 2014

Chrome side is: https://codereview.chromium.org/231763003/

This isn't perfect (using the family name directly rather than
doing a name/style/etc. fallback based lookup), but it's simple
and works sufficiently for layout tests and local developer use
of custom fonts. If we want to in the future, the same interface
could be used in conjunction with some skia changes to support
custom font collections, which would get the full style matching
support.

TBR=dglazkov@chromium.org
R=eae@chromium.org
BUG=333029

Review URL: https://codereview.chromium.org/235553003

git-svn-id: svn://svn.chromium.org/blink/trunk@171400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d161d86e

Don't use default GDI SkFontMgr in getFontFamilyForScript · 509d79fd

scottmg@chromium.org authored Apr 12, 2014

Instead of using SkTypeface directly which goes through the
default Skia FontMgr, pass ours through so that when enabling
DirectWrite we don't use the GDI one.

R=eae@chromium.org
BUG=362694

Review URL: https://codereview.chromium.org/235753003

git-svn-id: svn://svn.chromium.org/blink/trunk@171399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

509d79fd