- 13 Apr, 2018 40 commits
-
-
John Rummell authored
Permission check no longer requires the origin, so no need to pass the WebSecurityOrigin to SelectConfig(). BUG=349201 TEST=media_unittests pass Change-Id: I8d5242338b4a93577920e0211112c3ee8eb23790 Reviewed-on: https://chromium-review.googlesource.com/1011456Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550470}
-
Giovanni Ortuño Urquidi authored
Moves out-of-scope initial navigations, which are popups from one of the app's windows, into regular popups without the parent's theme and icon. Bug: 806654 Change-Id: If679a6ecee79068e94975ae317126ac3c05f9ba5 Reviewed-on: https://chromium-review.googlesource.com/1011463Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#550469}
-
Raymond Toy authored
When the context is closing, the nodes that were processing their tails need to be stopped. This disables the output of the node, which might cause other nodes to disable their outputs, and these nodes are placed on |finished_tail_processing_handlers_|. These also need to be handled when finishing tail processing. So loop around processing |finished_tail_processing_handlers_| and |tail_processing_handlers_| until disabling of outputs no longer adds anything to either of these. Bug: 832043, 828826 Test: run-webkit-tests --enable-leak-detection no longer detects leaks Change-Id: I6ca195352b240d343095c208c9b70b0c5553c925 Reviewed-on: https://chromium-review.googlesource.com/1010833 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550468}
-
Steven Holte authored
This will help with migrating off of UkmEntryBuilder, which relies on whitelisted access for recording metrics. TBR=charleszhao Change-Id: If8bc2becedb7bdabd9216e0b03427bb69483f9db Reviewed-on: https://chromium-review.googlesource.com/999264 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#550467}
-
Lutz Justen authored
Enables variable expansion for the NativePrinters policy on Active Directory managed devices. The expansion exchanges ${machine_name} by the Active Directory computer name for all JSON fields. Also supports substrings, e.g. ${machine_name,6,4} = 4 chars from pos 6. Cloud managed devices usually don't have a human-readable device name, so expansion isn't supported yet (although there's a machine_name field in PolicyData that one might use). More variables and policies can be easily added in the future. BUG=chromium:829279 TEST=chromeos_unittests --gtest_filter=VariableExpanderTest.* Set NativePrinters (aka 'Native Printing') policy in Active Directory GPO with display_name = '${machine_name}' for some printer. On AD managed device, get policy from the AD server and print a page. Select printers. A printer with the name of the Chromebook should appear. Also check device name shows up on chrome://policy under NativePrinters. Change-Id: I5fe6185b6bb48bf5d28a7ab4f53be1553fca18b5 Reviewed-on: https://chromium-review.googlesource.com/1001576 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Dan Erat <derat@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#550466}
-
Becky Zhou authored
Add an item in settings to turn on/off contextual suggestions. Bug: 822953 Change-Id: I9533b6afcc21c23ee580e8d7008b6dc3ca1e74d3 Reviewed-on: https://chromium-review.googlesource.com/1006232 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550465}
-
Kenneth Russell authored
If two different test expectations for the same test apply on the current browser configuration, fail hard. This has happened a couple of times already in the pixel test expectations and it has led to confusion. Added verify_all_expectations_unittest which checks for collisions in all of the GPU test expectations subclasses in this directory, taking into account configurations on the waterfall. This is automatically run during presubmit, along with all of the other GPU unittests, to make life easier on developers. Removed expectations for Pixel_CSS3DBlueBox, which should be passing on macOS reliably now. Bug: 533690, 706016, 796558, 830228 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I64a604d38a4b21729cf0e5b969328d2b051bddbb Reviewed-on: https://chromium-review.googlesource.com/1002032 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#550464}
-
Ian Clelland authored
Currently, policy-controlled features do not work as expected in frames with opaque origins, such as isolated sandboxes and data: URLs, because the eventual opaque origin of the frame is not known when the HTMLFrameOwnerElement builds the container policy, and so has no way to tell the browser that a particular origin should be allowed. This CL adds a new member to the ParsedFeaturePolicyDeclaration, which indicates that the iframe policy is expected to apply to the origin of the frame, and is used when that frame has an opaque origin. This can be triggered with an iframe of the form <iframe sandbox allow="feature"> or <iframe sandbox allow="feature src"> This flag is checked when building the feature policy in the new frame, and ensures that the new feature policy will allow the feature in that origin. This is the first part of the eventual solution -- currently this has the effect of allowing the feature even if a sandboxed frame navigates to a new page (causing a new opaque origin to be created for it). Subsequent CLs will add a unique identified to each such origin, and ensure that the generated policies are properly tied to the specific origin of the frame. Bug: 690520 Change-Id: Ie18b9bc3c36be6550baf5a03e355871b9589fd40 Reviewed-on: https://chromium-review.googlesource.com/963382Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550463}
-
Amirhossein Simjour authored
VR supports html select element, so the corresponding page popup doesn't need to be suppressed. Bug: 819876 Change-Id: Iac3cf7fbd7437cce27f3a265e95e3f0eb76c3e2c Reviewed-on: https://chromium-review.googlesource.com/1010782Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#550462}
-
Rouslan Solomakhin authored
This patch adds the ability for implementers of PaymentInstrument interface to determine whether skipping the payment sheet into this instrument should require a user gesture. By default, the user gesture is required for the skip UI flow. Bug: 828427 Change-Id: Id6878c7d0d9bef71da7734d2efec3fd6002fe282 Reviewed-on: https://chromium-review.googlesource.com/1010975Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550461}
-
Yoshifumi Inoue authored
This patch changes "innerText-inline-table.html" to utilize w3c test harness for ease of maintenance. Since pixel differences are not significant of this test, this patch removes entry from LayoutNG test expectation. Change-Id: I958bd07b05bcea49b502261dc7db0fb3e0caed03 Reviewed-on: https://chromium-review.googlesource.com/1009510Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550460}
-
Patrick Noland authored
Add ReportFetchMetricsCallback Plumb a ReportFetchMetricsCallback from proxy through to fetch Add metrics reporting logic in fetch Bug: 830639 Change-Id: Ic278bb7955101b02c3e01d7657339810d9ba9d3f Reviewed-on: https://chromium-review.googlesource.com/1011259Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550459}
-
Jacob Dufault authored
Also rename UserSelectionScreenProxy to UserBoardViewMojo. The backend is a mojo client; the browser-side code should not know that the implementation is in views. Bug: 784495 Change-Id: I1f3933e7191a9be8f1d73720a27c747391763737 Reviewed-on: https://chromium-review.googlesource.com/1008843 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#550458}
-
Steven Bennetts authored
This CL: * Moves pref names used by DisplayPrefs to ash_pref_names.cc * Moves DisplayPrefs to src/ash * Moves ownership of DisplayPrefs to ash::Shell. NOTE: This change causes DisplayConfigurator::SetInitialDisplayPower to be called asynchronously when OnLocalStatePrefServiceInitialized is called. Support for this was added in crrev.com/c/994282. NOTE: This does not move display_prefs_unittest.cc because of a dependency on DisplayConfigurationObserver which needs to be moved separately because it breaks a number of ash_unittests expectations. See crbug.com/831379 for details. For trivial code removal from browser_prefs: TBR=bauerb@chromium.org Bug: 678949 Change-Id: I078a0f52a38f493d592c92b291c53d6815ccf336 Reviewed-on: https://chromium-review.googlesource.com/1003379Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550457}
-
Emircan Uysaler authored
This CL seperates real time video use case from regular video for GpuMemoryBufferVideoFramePool usage. Additionally, it enables the usage on Windows for real time video because the tests showed that GMBVFP is much faster than CreateForSoftwarePlanes() resulting in a reduced latency. Bug: 829524 Change-Id: Icf387eecb3c7240e3ed52b22bff45a6da1f6ac01 Reviewed-on: https://chromium-review.googlesource.com/1003230 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#550456}
-
Bailey Forrest authored
BUG=internal b/77925032 TEST=cast_bluetooth_unittests Change-Id: Ie6e0eff3d3656b4e12905dcf93df114271383c2b Reviewed-on: https://chromium-review.googlesource.com/1009167Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#550455}
-
Daniel Murphy authored
Bug: 716490 Change-Id: If2b0672af149abf44dd475a2196e7b727cb450a7 Reviewed-on: https://chromium-review.googlesource.com/986880Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#550454}
-
Jacob Dufault authored
Previously, not all screen share sessions would stop and the shelf UI would not indicate that there was a screen share session. Bug: 826041 Change-Id: Ia32bf38e6a0dc158037d9d482e5b2bba6edf17f5 Reviewed-on: https://chromium-review.googlesource.com/993761Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#550453}
-
Matt Mueller authored
Change-Id: Id2e52e91a95fc56424cd67383e4851d4718e2bfd Reviewed-on: https://chromium-review.googlesource.com/1011414Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#550452}
-
Matt Wolenetz authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/5af686b3cfa2..c6aed052aba9 $ git log 5af686b3c..c6aed052a --date=short --no-merges --format='%ad %ae %s' 2018-04-12 wolenetz lavf/mov and lavc/h264_slice cherry-picks Created with: roll-dep src/third_party/ffmpeg BUG=823145,822705 TBR=xhwang@chromium.org Change-Id: I05c5b0c781157a67454e8d624f68ad8adcc00136 Reviewed-on: https://chromium-review.googlesource.com/1011397Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550451}
-
https://chromium.googlesource.com/angle/angle.git/+log/14f4817c4dad..56c8577b4dbf $ git log 14f4817c4..56c8577b4 --date=short --no-merges --format='%ad %ae %s' 2018-04-06 cwallez TextureD3D_2D::CopyImage clear using initializeContents 2018-04-12 lucferron Vulkan: Suppress flaky test in GLSLTest on Windows 2018-04-10 brandon1.jones Autogenerate ANGLE extension entry points 2018-04-11 lucferron Vulkan: drawArrays followed by drawElements bugfix 2018-04-11 jmadill VertexArray: Use switch macro for faster iteration. 2018-04-09 lucferron Vulkan: Enable GLSLTest tests for Vulkan Created with: roll-dep src/third_party/angle BUG=chromium:827667 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org No-try: True Change-Id: Ib121297476e16cae32b5198cdf8d54861a048841 Reviewed-on: https://chromium-review.googlesource.com/1011228Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550450}
-
Tommy C. Li authored
When Steady State Elisions is on, when the user clicks the mouse once, it should focus and select all in the text field. When the user places the caret inside the text by clicking on the text a second time, it should unelide on mouseup only. This adds a test for that. It also places the View inside a Widget to make the focus behave correctly. It also adds a fake clock to the Steady State Elisions test, so we can control the click being not interpreted as a double-click. Bug: 797354 Change-Id: If72235dd88b6918f9071fffea800723a24c555f7 Reviewed-on: https://chromium-review.googlesource.com/1007492 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550449}
-
Wenzhao Zang authored
1) Changed all the observers in //chrome to use the mojo interface. 2) Since views-based login may still take some time to be fully ready, prefer to remove the dependency in signin_screen_handler now. Since app list and login screen are two main observers of wallpaper events we'll be able to clean up some mojo interface after both are moved to //ash. Bug: 827062 Test: --enable-features=Mash Change-Id: I81a26faa8ccb29c472ed4dc2257604d67f56e897 Reviewed-on: https://chromium-review.googlesource.com/998814Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550448}
-
Kim Paulhamus authored
Bug: 828958 Change-Id: Ie24fb55ddf5b8180036e830cd73ae58b0fb2ccd5 Reviewed-on: https://chromium-review.googlesource.com/994177 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550447}
-
Kevin Marshall authored
This reverts commit 9213e261. Reason for revert: Very flaky on Win7 Tests (x64) Example run: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/37006 Original change's description: > Added export policy session to Linux > > This feature allow users to export the policies in a JSON file. > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I708abc3465ecf2a469979fb7d13b22ed947ed392 > Reviewed-on: https://chromium-review.googlesource.com/966590 > Commit-Queue: Martin Rodriguez <rodmartin@google.com> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550246} TBR=pastarmovj@chromium.org,georgesak@chromium.org,dschuyler@chromium.org,zmin@chromium.org,rodmartin@google.com Change-Id: Ibbaa930b23638ec9abc10dc3bdce234e11a7cbcf No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1011625Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550446}
-
https://chromium.googlesource.com/catapult.git/+log/19b3dfed02a8..67d01a21077f $ git log 19b3dfed0..67d01a210 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 sullivan Pinpoint: only update bug status if bug is open and unassigned. 2018-04-12 simonhatch Dashboard - Use same names as chromium.perf for annotations Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I12b500d2e34f6eede77b5480b393c531252f4656 Reviewed-on: https://chromium-review.googlesource.com/1011233Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550445}
-
Shridhar Sundarraj authored
In Viz, PageHandler will no longer know that a CompositorFrame has been submitted. This CL makes use of FrameSinkVideoCapturerImpl for screencasting, so that PageHandler doesn't need to rely on knowing about CompositorFrame submissions. Some information from CompositorFrameMetadata is required for screencasting. This is sent to PageHandler by FrameSinkVideoCapturerImpl along with each frame. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie7a191944579bb7f6dda0e5384e5955764c24850 Reviewed-on: https://chromium-review.googlesource.com/969711 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550444}
-
Mitsuru Oshima authored
This is reland of crrebu.com/c/990203 with ASH_EXPORT This will be used for ARC++ windows. This a) is always placed at the topof the display and covered full width. b) supports immersive mode c) is resized when the display metrics changes. TBR=mukai@chromium.org BUG=b/33693796 TEST=covered by unittest Reviewed-on: https://chromium-review.googlesource.com/990203Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550278} Change-Id: Ib60a03017c724c62d5912a472fa6e32dd9a02e99 Reviewed-on: https://chromium-review.googlesource.com/1011323Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550443}
-
Hector Carmona authored
Bug: 832012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c1b7499de7085f1ca109748b28b5067754b5aaa Reviewed-on: https://chromium-review.googlesource.com/1010481Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#550442}
-
Xiaoqian Dai authored
Previously it was OverviewWindowDragController who is responsible to remove the window from overview before trying to snap it. It should be SplitViewController's responsibility to do this work. Bug: None Change-Id: I157d8cff294fd43ecbefeff01fc20cd61cb95361 Reviewed-on: https://chromium-review.googlesource.com/1008966 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550441}
-
Yuwei Huang authored
Previously we report connection failure both before and after CONNECTED as CONNECTION_FAILED, which makes it harder to calculate durability. This CL makes sure connection failures after CONNECTED are reported as CONNECTION_DROPPED. Bug: 828210 Change-Id: I8689718a5741aec6b1ea49172838b44857ca4108 Reviewed-on: https://chromium-review.googlesource.com/1011354Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550440}
-
Kent Tamura authored
This CL is a preparation to change references to them in build bots. This CL has no behavior changes. Bug: 829697 Change-Id: I3d69dbae6520e3b2c6ca95a7b3c05a7322eeaa0a Reviewed-on: https://chromium-review.googlesource.com/1009543Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550439}
-
Yuwei Huang authored
_session is only valid when the session is connected. This CL adds tests before using _session in RemotingClient. Bug: 831954 Change-Id: I0f12221f2c80b55d0a784dc8771fbec573fd1deb Reviewed-on: https://chromium-review.googlesource.com/1010917Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550438}
-
Ryan Hansberry authored
Bug: 819279 Change-Id: Iae36309deae890bfa84ac251eb6bfb4dca94d8f9 Reviewed-on: https://chromium-review.googlesource.com/1009066 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#550437}
-
Eugene But authored
iOS 11.4 introduced "Policy requirements not met." error which is used in varios sutuations. This error is mapped to CERT_STATUS_INVALID and CERT_STATUS_AUTHORITY_INVALID. cert_verify_proc_ios_unittest was changed to be Objective-C source file to use @available keyword (the only clean way to test for OS version). PlatformTest is needed for every Objective-C test to drain autorelease pool. Bug: 830127, 830125 Change-Id: I99d4d3e6a580c16fdbb8e47359418a0a68b0fb48 Reviewed-on: https://chromium-review.googlesource.com/1008128Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550436}
-
Jungshik Shin authored
There are two changes: https://chromium.googlesource.com/chromium/deps/icu.git/+log/d888fd2..aff99f5 $ git log d888fd2..aff99f5 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 jshin@chromium.org Cherry pick 3 patches from the upstream 2018-04-10 jshin@chromium.org Update IANA tzdb to 2018d and apply a fix for long word selection TBR=mark@chromium.org,inferno@chromium.org Bug: chromium:799850, chromium:796807, chromium:796752 Bug: chromium:829144, chromium:473288 Test: See the two ICU cls above. Change-Id: I0adf27e01c0349bd00d4916567bdc0bc70483439 Reviewed-on: https://chromium-review.googlesource.com/1011238Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550435}
-
Michael Thiessen authored
Reverts some code I thought wasn't necessary anymore in https://chromium-review.googlesource.com/c/chromium/src/+/951926 Bug: 831332 Change-Id: Ib26d8c6e10971241905eda776d55be7407e91885 Reviewed-on: https://chromium-review.googlesource.com/1011406Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#550434}
-
Xiangjun Zhang authored
The accidentally starting Media Remoting on Android caused the crash since it is currently not supported on Android. Bug: 827990 Change-Id: I1416993a2e3c03084e694c342d67becc44ec0fce Reviewed-on: https://chromium-review.googlesource.com/1008847Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550433}
-
Fergal Daly authored
The original doc was mistaken about MatchScopedRules and actually described the V0 process. Update it to describe the V1 process. This includes removing the reference to TreeBoundaryCrossingScopes as these are only part of V0. Also a few small updates: - splitting the classes up into 2 groups - more detail on :host - a bit more detail on the compiling phase - some random fixes Change-Id: Ifc2b26ccf82c1b9a24f52afb7ce74e0fea768fb7 Reviewed-on: https://chromium-review.googlesource.com/1006743Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550432}
-
Biao She authored
Note that it depends on https://chromium-review.googlesource.com/c/chromium/src/+/1010479 This CL replaces the support library's AlertDialog with a VrAlertDialog IFF we are in VR. Bug: 831233 Change-Id: I4ef0586625e3ae447f55b1e6045f2fb2dfef09ff Reviewed-on: https://chromium-review.googlesource.com/1010916Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550431}
-