- 29 Apr, 2018 12 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51556bb7. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16442 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=qyearsley No-Export: true Change-Id: I6bb2420dc1b1ce974115c24450c9a65cb506b2aa Reviewed-on: https://chromium-review.googlesource.com/1034082 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554671}
-
Vaclav Brozek authored
This CL addresses comments raised on https://crrev.com/c/1013580 after it landed: * Changing name and the declaration comment of a FormFieldData method to reflect its effect on textarea fields. * Adding some std::vector::reserve calls to avoid extra heap allocations when calling push_back in a loop with known maximal iteration count. Bug: 807623 Change-Id: Ibc9fefbf29676563bbc317e1fd8a0386d245bdd2 Reviewed-on: https://chromium-review.googlesource.com/1032791 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#554670}
-
tzik authored
https://chromium.googlesource.com/chromium/deps/mesa.git/+log/803b11320967..9d9b0710470f $ git log 803b11320..9d9b07104 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 tzik Regenerate chromium_gensrc with newer flex and bison Created with: roll-dep src/third_party/mesa/src BUG=752720 Change-Id: I29ff738aab99fb36f8a89ea0b3732ad5cba29ec0 Reviewed-on: https://chromium-review.googlesource.com/1032132 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554669}
-
https://skia.googlesource.com/skia.git/+log/cccafe8cfd23..efb4d08dd43c $ git log cccafe8cf..efb4d08dd --date=short --no-merges --format='%ad %ae %s' 2018-04-29 skia-recreate-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ib82fbaf0670bc304b9440805d71ad47cac79a063 Reviewed-on: https://chromium-review.googlesource.com/1034280Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554668}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic833a4571a1a43df0ca24a32c3bbaaa0f1560f59 Reviewed-on: https://chromium-review.googlesource.com/1034278 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554667}
-
Xiaohan Wang authored
Previously this was only partially done due to issue 634270. Now that issue has been fixed and we can mark more EME APIs with SecureContext. In the current EME spec, there are 9 APIs marked with SecureContext. This CL makes sure all of them are marked with SecureContext in Blink IDL. Also mark getStatusForPolicy() (not in EME spec yet) with SecureContext. Bug: 692289 Test: Manually tested and verified no MediaKey* exposed in http:// Change-Id: If976d30b3371c4be2bcd33ab61268f21145232a1 Reviewed-on: https://chromium-review.googlesource.com/1030760Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#554666}
-
Kirtika Ruchandani authored
crosreview.com/950683 introduces this enum. BUG=b:35648315 Change-Id: I4f9a7ac56270d20ca60eb08d27a9ae30ff75cf2f Reviewed-on: https://chromium-review.googlesource.com/1027127 Commit-Queue: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#554665}
-
Samuel Huang authored
CL https://chromium-review.googlesource.com/1028836 adds patch validation to ensure equivalence blocks for element pairs would not span outside the regions for respective elements. The check assumes that equivalences use absolute offsets for entire "old" or "new" archives. This was mistaken (and missed in review), since equivalences in fact use "local" offsets relative to the start of each element. As a result, ensemble patching for Zucchini-apply would mistakenly trigger the check, leading to patch failure. This CL fixes the check. This removes the need for RangeIsInRegion() (now removed), since RangeIsBounded() suffices. Bug: 837096 TBR=grt@chromium.org Change-Id: I2b1e575c4a44f112adebaf1487a41f12cf23f570 Reviewed-on: https://chromium-review.googlesource.com/1034274Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#554664}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Id5ae0d575523bc1deaca09d20088aceefbed3a39 Reviewed-on: https://chromium-review.googlesource.com/1034218Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554663}
-
Nicolas Pena authored
Bug: 599609, 832680 Change-Id: Ib8db17ca291203b6b676a6c74e16db20c14bf3d6 Reviewed-on: https://chromium-review.googlesource.com/1012934 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#554662}
-
David Bokan authored
This bug occurs because of Clank's "resize main frame after layout" behavior. In a nutshell: we want users to be able to zoom out to that the entire width of the content fits on screen. Because we can't zoom out further than the layout viewport (i.e. the main FrameView), after a layout occurs we resize the main FrameView to match the content width. This leaves us in an interesting situation - the viewport scroller is actually larger than the initial containing block (i.e. the LayoutView size). This situation cannot occur on desktop and generally doesn't occur on well-behaved mobile sites (sites that don't allow zoom out). The bug was occuring because the intersection observer used the LayoutView/ICB size for the root element. This is incorrect in the situation described above. We should really use the ViewRect which is the scroller bounds. Bug: 836408 Change-Id: I96029cdb11a6a16353d5b8b628b0182c13926a8d Reviewed-on: https://chromium-review.googlesource.com/1031118Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554661}
-
crystallambert@chromium.org authored
Link to embedded options was missing "#". This adds it in. Bug: none Change-Id: I357816ddc23bc977655d5990483f7302ecbfa8c1 Reviewed-on: https://chromium-review.googlesource.com/1033825Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#554660}
-
- 28 Apr, 2018 28 commits
-
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae26814f310e..f578e9249f18 $ git log ae26814f3..f578e9249 --date=short --no-merges --format='%ad %ae %s' 2018-04-28 dgarrett Revert "cbuildbot: Use previous build state for chroot reuse" Created with: roll-dep src/third_party/chromite BUG=chromium:1014949,chromium:829665 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I969623ebc1f77fd01e3f65def944d980d6831199 Reviewed-on: https://chromium-review.googlesource.com/1034293 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554659}
-
https://skia.googlesource.com/skia.git/+log/5b6d4a354670..cccafe8cfd23 $ git log 5b6d4a354..cccafe8cf --date=short --no-merges --format='%ad %ae %s' 2018-04-28 bsalomon Rewrite SkVertices specified with triangle fans as indexed triangles Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ie92f92ddedc72c7083c3fd04187016a09eec2e3c Reviewed-on: https://chromium-review.googlesource.com/1034211Reviewed-by:
-
David Tseng authored
TBR=dmazzoni@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f9cc5a5cacd43ce8ddc1913b721e0a1c80c0d4b Reviewed-on: https://chromium-review.googlesource.com/1025216 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554657}
-
Nicolas Pena authored
This CL merges the WorkerPerformance and Performance IDLs. The Exposed=Window addition to |navigation| and |timing| cause the paths to no longer exist when the frame is removed (as opposed to exist with trivial 0 values). Bug: 707392 Change-Id: I1b8bcfc0731a2075254a727df3f38f5ce3aa5df9 Reviewed-on: https://chromium-review.googlesource.com/1026451 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#554656}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/117b08a5550a..ae26814f310e $ git log 117b08a55..ae26814f3 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 manojgupta cros_setup_toolchain: Fix clang++ invocation. Created with: roll-dep src/third_party/chromite BUG=chromium:837889 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia57694a643aa8feeae0f67b4dc009cb61c072729 Reviewed-on: https://chromium-review.googlesource.com/1034209 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4eec0e90. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16365 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I523cccff8e8f48c2482ff75415fede62e964abdc Reviewed-on: https://chromium-review.googlesource.com/1034079 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 70fc0b01. Reason for revert: Caused bugs found by clusterfuzz Original change's description: > [CI] Make paint property nodes non-ref-counted > > Now all paint property nodes are owned by ObjectPaintProperties > (and LocalFrameView temporarily before removing non-RLS mode). > Others just use raw pointers or references. > > Bug: 833496 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae > Reviewed-on: https://chromium-review.googlesource.com/1031101 > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554626} TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833496,837932,837943 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1034292Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554653}
-
Sammie Quon authored
Test: Manual Bug: 837818 Change-Id: If9ac2878e9d3e302ece873ef32a81dd6a52214ca Reviewed-on: https://chromium-review.googlesource.com/1033963Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554652}
-
Sammie Quon authored
Adds ability to drag the overview item up or fling the item up to close the window. A later cl will add the fling animation. The feature is hidden behind a newly added flag. Test: added test coverage Bug: 828646 Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee Reviewed-on: https://chromium-review.googlesource.com/1014490Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554651}
-
https://skia.googlesource.com/skia.git/+log/0f97bac4a53f..5b6d4a354670 $ git log 0f97bac4a..5b6d4a354 --date=short --no-merges --format='%ad %ae %s' 2018-04-28 liyuqian Call SkMatrix::getType to make it thread safe Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ibf9c83baa174a78a6f7eeb49fc2dcebf19d4e2a0 Reviewed-on: https://chromium-review.googlesource.com/1034204 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Most callers have already been fixed to accept a unique_ptr. Guest views and headless are notable exceptions - this CL leaves TODOs to fix them up afterwards. This CL also fixes a layering issue in ViewsDelegate, which was incorrectly and unnecessarily referencing contents/. Bug: 832879 Change-Id: Ie00387ca6c182390b1d720a60deaebe8d770aa17 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1031314 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#554649}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a5935950. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16328 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure TBR=qyearsley No-Export: true Change-Id: If662cf86e2c637a850d089d88513f539e58706b1 Reviewed-on: https://chromium-review.googlesource.com/1034213 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Noel Gordon authored
base::RunLoop::QuitCurrentWhenIdle() can spin the run loop a few times before it exits, sufficient to allow any chrome.test.SendMessage calls arriving _after the test PASS or FAIL messages_ to be queued. Such messages will not be processed once the message processing sees a PASS or FAIL message, causing a CHECK in the extensions system code at exit to remind us that unprocessed test.SendMessage's need a reply. Fix: use modern base::RunLoop/Closure methods. Add |test_complete_| to record when test PASS or FAIL messages arrive. Add a CHECK stop to the test.SendMessage reader code to verify they are never received after a PASS or FAIL message. Tbr: mtomasz, slangley Bug: 668680 Change-Id: I09cae80870d0471b214253beb2f05e8914fee0aa Reviewed-on: https://chromium-review.googlesource.com/1034174Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554647}
-
David Roger authored
This CL adds two histograms: * Signin.RefreshTokenRevocationRequestProgress tracks the progress of revocation requests, and can be used to check how many requests do not complete and why. * Signin.RefreshTokenRevocationStatus reports the status (including error details) of token revocation requests after they complete. TBR=atwilson, ellyjones Bug: 834720 Change-Id: I9a78bdae4377047e71bd6c27fc0814d8f4a57383 Reviewed-on: https://chromium-review.googlesource.com/1025753Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#554646}
-
Koji Ishii authored
This patch fixes ShapeResult::CopyRange to compute more accurate glyph bounding box. There were 2 problems before this patch: 1. It always truncated the right edge. This is problematic when Copying (0, 1) of ". " in RTL, which resulted in an empty result. 2. It assumed no glyph overflow at the edge. This resulted in common glyph overflows such as "t" or "m" were cut off. This patch extracts the logic to compute glyph bounding box from ComputeGlyphPositions to a new helper class. CopyRange uses the class to compute the line-left/right most glyph bounding box. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7d2068566308081727c996e3ac0fe23aae6558d1 Reviewed-on: https://chromium-review.googlesource.com/1023536Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#554645}
-
Renee Wright authored
And use it to clean up registered apps before uninstalling Crostini. Change-Id: I4331d3ca30f136f0880e9e886cad12e8fe9802ad Reviewed-on: https://chromium-review.googlesource.com/1032672Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#554644}
-
Takashi Toyoshima authored
Current code does not finalize preflight requests correctly when the preflight request failed without receiving HTTP response headers. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1c91e3ecf76fdb368e3d55256885f52edf6fcbb3 Reviewed-on: https://chromium-review.googlesource.com/1027556 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554643}
-
Takashi Toyoshima authored
Current implementation does not store rejected method or header information to CORSErrorStatus on CORS-preflight checks, and results in missing hint parameter on CreateErrorString() in Blink. This patch provides required information to generate right error messages, and fixes some crashed layout tests. Bug: 803766, 836741 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If4de6b916a77d204812a7b010e39080bf059bc9e Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1030670 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Timothy Loh authored
This patch adds the pin/unpin entry to the context menu for Crostini apps on the shelf. Crostini windows which are not associated with a desktop file do not get this context menu item. Bug: 824549 Change-Id: I91ec27dc909804e44a3b98b4f38a281b8243d262 Reviewed-on: https://chromium-review.googlesource.com/1032192Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554641}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fad57b13..e9f80dac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If2644b1ed33966d20ab96a848f4339152e1539a6 Reviewed-on: https://chromium-review.googlesource.com/1033910Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554640}
-
https://skia.googlesource.com/skia.git/+log/7df62b559a65..0f97bac4a53f $ git log 7df62b559..0f97bac4a --date=short --no-merges --format='%ad %ae %s' 2018-04-28 liyuqian Copy SkBitmap to make it thread safe Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I833567eee92f2cf05bc4c601b0c9c40136de882c Reviewed-on: https://chromium-review.googlesource.com/1034192Reviewed-by:
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. Test LayerTreeFrameSink is one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I17eea36d81726e50a1f5f46fadd3daa624f692c3 Reviewed-on: https://chromium-review.googlesource.com/1029538Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#554638}
-
Ian Kilpatrick authored
I want to see how much shape-outside: content-box, and shape-outside: padding-box are used relative to the others. There two values seem like a mis-feature, and if not used will try and get punted from the spec. (There is non-trivial additional complexity for LayoutNG eventually). Change-Id: I13a5d59397bc6e010892c74f452e5cd33a77ee2f Reviewed-on: https://chromium-review.googlesource.com/1029171 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#554637}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cbdbd28b508..5148f0652738 $ git log 0cbdbd28b..5148f0652 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:822826 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I23e6fe0831080cbf78d39e06c48a3f989665dd4f Reviewed-on: https://chromium-review.googlesource.com/1034121Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554636}
-
Siddhartha authored
1. Reading elf for the current binary could lead to seg fault if the full library is not loaded in memory. So, the util only takes mapped address and works on it. The caller must ensure the library is mapped. 2. Add function to read soname from the .dynamic section in elf file. 3. The Linux executable does not contain so name. So, use malloc_wrapper library to test. BUG=734705 Change-Id: I1327f4786726143daba57a2aaa1eddd608143c04 Reviewed-on: https://chromium-review.googlesource.com/1031854 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554635}
-
Xiaohan Wang authored
EmeCodec is for a single codec (in one or more container), while SupportedCodecs is a bit mask representing one or more EmeCodecs. Previously common bit masks are also part of EmeCodec enum, causing some confusings. This CL separates them. This CL also updates how the EmeCodecs list is build. Previously there are too many if/defs which makes the code really hard to read and work with. This CL use constexpr functions to build them at compile time. Bug: 773863 Test: No functionality change. Change-Id: I0f844735699baa5faa4bf1b93905b045e9fcb8e3 Reviewed-on: https://chromium-review.googlesource.com/1034004 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#554634}
-
https://webrtc.googlesource.com/src.git/+log/de2ed7dc18d5..9546f37c0366 $ git log de2ed7dc1..9546f37c0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9e4b90cf30030da1ad0a3b52928089e98ace399a Reviewed-on: https://chromium-review.googlesource.com/1034129Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554633}
-
Abhishek Arya authored
This reverts commit 58eabf0b. Reason for revert: Broke ChromeOS ASan builder Original change's description: > Build 32- and 64-bit Android mojo_core for Chrome OS distribution > > Causes Chrome builds for Chrome OS to emit additional 32-bit and > 64-bit copies of the mojo_core shared library built against the > Android toolchain, for use from within the ARC++ container. > > In order to support building these library targets, this also > modifies DEPS to include a minimal set of required Android support > tools and libraries in chromeos checkouts. > > Bug: 822034 > Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0 > Reviewed-on: https://chromium-review.googlesource.com/1026203 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554617} TBR=rockot@chromium.org,dpranke@chromium.org Change-Id: I2e2b0d3500aa948f15ec7cf0ff024f7a82fd719d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822034 Reviewed-on: https://chromium-review.googlesource.com/1033369Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#554632}
-
