- 10 Sep, 2018 40 commits
-
-
Paul Meyer authored
This patch implements crash reporting, as detailed in the reporting spec: https://w3c.github.io/reporting/#crash-report Change-Id: I209880150193910a0947608e6b08a6eeea29206c Reviewed-on: https://chromium-review.googlesource.com/1174965 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589941}
-
Ivan Sandrk authored
Continuation of work from crrev.com/c/1202147, fixing up how delegates are set and persisted (using the base::NoDestructor pattern). Bug: 865947 Change-Id: Ib8768fe71e91c5f1bad400ec047b2c941a939608 Reviewed-on: https://chromium-review.googlesource.com/1210502Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589940}
-
David Tseng authored
This reverts commit b9c37a4d. Reason for revert: <INSERT REASONING HERE> Likey change that causes many tests to flake (in chromevox_tests target). Bug: 881845 Original change's description: > Defer AX events to avoid problems with transient focus events. > > Some dialog boxes, like the accelerator confirmation dialog that appears > when you press Search+Control+M, focus the dialog and then immediately > after focus one of the buttons. This was causing ChromeVox to suppress > information about the context of the dialog. > > Fix this by using PostTask to defer all events from Views. This doesn't > even add any delay, it just pushes the event firing to after the current > call stack so that transient changes get suppressed. > > Manually confirmed that the experience with this particular dialog is > improved, other dialogs and views seem to continue to work fine. > > Bug: 729449 > Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373 > Reviewed-on: https://chromium-review.googlesource.com/1176207 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589201} TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,yawano@chromium.org,sarakato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 729449 Change-Id: I3275d959e96d05fdcfeac3c6b7839f7f36f75735 Reviewed-on: https://chromium-review.googlesource.com/1216664Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589939}
-
Etienne Pierre-doray authored
Fix compile error with -Wshorten-64-to-32. Image size is new stored as an offset_t to avoid implicit conversion. Bug: 881008 Change-Id: I82b12ce17d8368f05d6a5537fd1734ee32b37dbe Reviewed-on: https://chromium-review.googlesource.com/1213549Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#589938}
-
Christian Dullweber authored
MediaLicenses are deleted together with Cookies in Clear Browsing Data (basic tab) now. We should also delete them from SiteDetails. Bug: 877999 Change-Id: Id4c751ca797ef6b3d123870cceb9eb1eef62e5f8 Reviewed-on: https://chromium-review.googlesource.com/1213242Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#589937}
-
Bailey Berro authored
This change updates the remount flow so that hosts on the network are rediscovered, so if the hostname is the same but the ip has changed since the share was originally mounted, the share will be able to be mounted. Bug: chromium:757625 Change-Id: I5038882fa44be15b725e1ccc0b377b244b62f787 Reviewed-on: https://chromium-review.googlesource.com/1199939 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#589936}
-
Kevin Bailey authored
The suggestion providers HistoryQuick, Search and Shortcuts call AutocompleteMatch::EnsureUWYTIsAllowedToBeDefault() to promote suggestions to have |allowed_to_be_default_match| set if the stripped URL matches the input. This was done to promote some higher scoring suggestions to become the default match. This is now done during sort-and-dedup by having an |allowed| suggestion inherit the best score that it matches. This CL removes the calls and therefore doesn't set |allowed| in these matches. Bug: 879796 Change-Id: I9529e3bea015e6e04f44ed5b401344d73556665b Reviewed-on: https://chromium-review.googlesource.com/1213281 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589935}
-
Maks Orlovich authored
Hoping to fix 881941 Bug: 881941 Change-Id: I7ba5b34b3e3f0c6eec8747a0079a95a1f44aa732 Reviewed-on: https://chromium-review.googlesource.com/1214302Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589934}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/76dac9ac2f26..abd4273e43da git log 76dac9ac2f26..abd4273e43da --date=short --no-merges --format='%ad %ae %s' 2018-09-10 danilchap@webrtc.org Cleanup test::FrameGeneratorCapturer::InsertFrameTask 2018-09-10 ilnik@webrtc.org Revert "Reenable simulcast video full stack test on MAC" 2018-09-10 danilchap@webrtc.org Move RtcpTransceiver deletion of copy and assign methods to public section 2018-09-10 danilchap@webrtc.org Disallow assign by deleting correct assign signature 2018-09-10 yuriy@appear.in Use default RTCConfiguration on iOS 2018-09-10 ssilkin@webrtc.org Revert "Enable VP9 KSVC perf tests." 2018-09-10 phoglund@webrtc.org Bump iOS bots to iOS 11. 2018-09-10 aleloi@webrtc.org Store RuntimeSetting in Aec Dumps. 2018-09-10 ssilkin@webrtc.org Revert "Frame rate controller per spatial layer." 2018-09-10 sprang@webrtc.org libvpx vp8 encoder: get frame drop setting from temporal layer 2018-09-10 philipel@webrtc.org Removed unused member |last_unwrap_| from RtpFrameReferenceFinder. 2018-09-10 ivoc@webrtc.org Add more useful information to NetEqState and implement action_times_ms 2018-09-10 sprang@webrtc.org For simulcast screenshare, make 2 tl default for high stream. Created with: gclient setdep -r src/third_party/webrtc@abd4273e43da The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:881453,chromium:881453,chromium:882358,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic79aad33d5a5265556677e68241874e128335f8e Reviewed-on: https://chromium-review.googlesource.com/1216107Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589933}
-
W. James MacLean authored
Temporarily disable this test while we resolve the flakiness issue. Bug: 882458 Change-Id: I03dcfd61ec172fc8206414428427d8439f503bff TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1216704Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#589932}
-
Rayan Kanso authored
TBR=peter@chromium.org Change-Id: I57ea9fbf394491f31a5c319b82d6eccf7f0cf4e2 Reviewed-on: https://chromium-review.googlesource.com/1216344Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#589931}
-
Aldo Culquicondor authored
Bug: 881970 Change-Id: I23d7c563929d0c95459050669b3303eba3785128 Reviewed-on: https://chromium-review.googlesource.com/1216464Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589930}
-
Peter K. Lee authored
This CL is intended to be cherrypicked to M70 branch, so changes is kept to be a minimum. Bug: 882424 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibad7c24e5d080471f16ece252648cadd8e3346f8 Reviewed-on: https://chromium-review.googlesource.com/1216026Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#589929}
-
Peng Huang authored
Chrome will use Skia instead of using Vulkan API directly. So some code will not be used anymore, so remove them. Bug: 876825 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia572cfa0937a3d09e139f88df22cff85cfb67abb Reviewed-on: https://chromium-review.googlesource.com/1204921 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589928}
-
Boris Sazonov authored
This CL moves the sync error card shown in "Sync and Google services" out of "Sync and personalization" section. It also removes a redundant key attribute from a divider in sync_and_services_preferences.xml. Bug: 882455 Change-Id: I2721bf8964fbb78f1e103df5e249e540113fe200 Reviewed-on: https://chromium-review.googlesource.com/1216070Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#589927}
-
Sam Maier authored
We aren't removing the third_party/ copy yet to avoid a breakage downstream. Once downstream is updated, we will move all usages over and remove the third_party/ folder. Bug: 825947 Change-Id: I392779043cc3f3d971df86ebeef4144a0c9cc5dc Reviewed-on: https://chromium-review.googlesource.com/1213534Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#589926}
-
Matthew Jones authored
Instead of adjusting the padding for the whole NTP view, this patch only changes the margin on the logo (if it exists). This causes the most visited icons to be in the correct position when the omnibox is focused (with and without logo) and fixes an accessibility focus highlight bug. Bug: 879485, 876542, 881993 Change-Id: If8df92af096a44a18dea83fdaa49a0776f5296c5 Reviewed-on: https://chromium-review.googlesource.com/1214219Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#589925}
-
David Davidović authored
When deriving keys using PBKDF2 in Nigori, previously, a |hostname| and |username| parameter were accepted via the KeyDerivationParams struct. They were used to derive the per-user key derivation salt. However, at all call sites, hardcoded strings "localhost" and "dummy" were always passed, resulting in a constant salt for all users. Furthermore, we were computing a value that never changes, which was not needed. Remove |hostname| and |username| as configurable parameters, and instead hardcode the constant salt derived from them directly in Nigori. Add a test to Nigori to ensure that the derived keys stay the same. Remove |hostname| and |username| from KeyDerivationParams altogether and update all call sites to not pass the hardcoded "localhost" and "dummy" strings. In Nigori unit tests, update hardcoded test vectors because they all used different hostname and username parameters than "localhost" and "dummy", and so were no longer correct. (Note that the salt cannot be changed due to backwards-compatibility reasons. To remedy the weakness of this encryption, a new key derivation method (scrypt) which uses a random salt has been recently introduced.) TBR=sdefresne@chromium.org Bug: 880535 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I93e9a0f69684f2e29ba48321efb01016761f424d Reviewed-on: https://chromium-review.googlesource.com/1205031 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589924}
-
Stephane Zermatten authored
This is a reland of 5bf6f1b1 Original change's description: > [Autofill Assistant] Bind the script tracker with the controller. > > With this change, the controller tells the script tracker to run checks > when necessary, calls the UI controller to choose a script to run and > run the script that was chosen. The implementation of the UI controller > for choosing the script is not included into this change. > > Integration is preliminary, just to get something to get started until > we have a usable UI to try it out. The UI part, implementing script > selection, is missing from this change. > > Change-Id: I867bec0e554dfdd87fc2f95e7c9088391621c5c9 > Bug: 806868 > Reviewed-on: https://chromium-review.googlesource.com/1194034 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589135} Bug: 806868 Change-Id: I40b66adca74162a1a41a47f1e065d2bf3aa225ed Reviewed-on: https://chromium-review.googlesource.com/1209709 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589923}
-
Nicolas Ouellet-Payeur authored
BrowserSwitcherService is a per-BrowserContext class that manages resources that should be shared between tabs in the same BrowserContext: for now, the sitelist and browser launcher objects. The BrowserSwitcherServiceFactory lets us easily create only one BrowserSwitcherService per BrowserContext. Bug: 876803 Change-Id: I6eb4c235143cfe38a077141b62e9332ed0f30a05 Reviewed-on: https://chromium-review.googlesource.com/1206698Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#589922}
-
Yao Xiao authored
Indicating whether the page called window.open() from an ad subframe and/or with an ad script in the stack. Bug: 880923 Change-Id: Ia64fea4f32bc62c3ee5aceb3731a236b88b1c807 Reviewed-on: https://chromium-review.googlesource.com/1206676 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589921}
-
Egor Pasko authored
This should help triage cases when library prefetching takes too long or too little. Bug: 881384 Change-Id: I315020758bb702578237fae6de5c776e27c367d4 Reviewed-on: https://chromium-review.googlesource.com/1215802Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589920}
-
kylechar authored
Remove the ability to access RenderingWindowManager on any thread and remove locks. Make RegisterChild() PostTask back to the UI thread if necessary so it can still be called anywhere. There is already a PostTask before ::SetParent() gets called, so this shouldn't add much extra latency before things show up on screen. Also move the checks that parent HWND was registered and child HWND was created by expected process id to happen immediately before calling ::SetParent(). This ensures that child HWND belongs to the right process. We don't need to check the parent HWND process because we check it registered by the browser process. This also fixes a race with OOP-D where RegisterChild() can get called more than once due to races between different message pipes. Bug: 791660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If8e98bd974dbc77e1be21252d3aa1682f3e6e016 Reviewed-on: https://chromium-review.googlesource.com/1194580 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#589919}
-
Eric Seckler authored
Add the dependencies of the invoker target to the generated nocompile targets. This should address the flakiness issues of building content_nocompile_tests. Bug: 882234 Change-Id: Ic7f7a07d3a6567202b3a0da8800228c7329f119d Reviewed-on: https://chromium-review.googlesource.com/1215964Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#589918}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/40a68547dcda..f62d7978fc50 git log 40a68547dcda..f62d7978fc50 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 31666470+s-perron@users.noreply.github.com Add validation check for arrays of void type. (#1880) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f62d7978fc50 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I929e9b642f90e6e540e83c2ad3dea737493bf571 Reviewed-on: https://chromium-review.googlesource.com/1216105Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589917}
-
Peng Huang authored
This change also fixes the synchronization problem. Bug: 878011 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I15f73c32b76fdf9456e26e811d36b9d8dcfe35d6 Reviewed-on: https://chromium-review.googlesource.com/1195661 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589916}
-
Kevin McNee authored
Currently, all of the <webview> public api methods forward to WebViewImpl. We now implement methods that don't involve internal details of WebViewImpl on the <webview> element itself. For methods that do require details of WebViewImpl or WebViewInternal, we forward the calls as needed. Bug: 793935, 867831 Change-Id: Iad6a1a1b27c9351e7f7edeaa246b26e799be697d Reviewed-on: https://chromium-review.googlesource.com/1188868 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589915}
-
Stephen McGruer authored
This was inadvertantly added in http://crrev.com/39254f02 and breaks fetch of the code for new checkouts. Bug: None Change-Id: Icc6c0fa436b474cc3dd5d05fbc552a5a3df5402a TBR=sky@chromium.org Change-Id: Icc6c0fa436b474cc3dd5d05fbc552a5a3df5402a Reviewed-on: https://chromium-review.googlesource.com/1216442Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589914}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I6fbce5c5159625c331b5387a34670c39013495f9 Reviewed-on: https://chromium-review.googlesource.com/1195622 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#589913}
-
Byoungkown authored
Using "use_jumbo_build=true" args in GN, speed up builds in components/feature_engagement. Bug: None Change-Id: Ibcb25fa9c6d42ed8e6ce5935409a77c4beb73d34 Reviewed-on: https://chromium-review.googlesource.com/1195295 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589912}
-
Marina Ciocea authored
Bug: 832666 Change-Id: Ic64a983498156bba73c458f2abc872db337d1999 Reviewed-on: https://chromium-review.googlesource.com/1216142Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589911}
-
Harald Alvestrand authored
This CL makes the Blink layer keep a copy of the tone buffer and update it on insertDTMF and ontonechange events only; this makes it possible to expose the state of the tone buffer at the time the event is fired to the Javascript callback. It removes a queueing step inside the DTMF sender, because that queueing step destroyed the consistency. Bug: chromium:816475 Change-Id: I5aa68396299a67d6cea1e8a17d364f553514c291 Reviewed-on: https://chromium-review.googlesource.com/1213084Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#589910}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c55b114a75a0..43b882bceda7 git log c55b114a75a0..43b882bceda7 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 bsalomon@google.com Remove purging of GPU resources based on flush counts. Created with: gclient setdep -r src/third_party/skia@43b882bceda7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I9088e1680d5e725a37b8246a2fe5f796ce7cf3fc Reviewed-on: https://chromium-review.googlesource.com/1216102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589909}
-
Benjamin Ackerman authored
Use a placeholder icon for the favicon on the chrome-extension:// pages when the extension does not provide one. Bug: 668148 Change-Id: I3a523d459053aa956145839abee25c699f74f1c4 Reviewed-on: https://chromium-review.googlesource.com/1163292 Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589908}
-
Julian Pastarmov authored
Otherwise no sync happens on browser startup and changes made on other computers only become visible after some syncable event is committed to the sync local backend. BUG=816379 Change-Id: I60c0fc8e67edd104fdc1a636abad2e829baf4f99 Reviewed-on: https://chromium-review.googlesource.com/1209622Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#589907}
-
Xiyuan Xia authored
Just moving code around w/o functionality change. This is to prepare to run TestWindowService from content_browsertests in a way similar to AshService to support both in-process and out-of-process mode. Standalone test_ws will be kept around since it is still used by some tests. Bug: 874089 Change-Id: I3324ffdab7126155f9355ee9b2b9aa6d8818da19 Reviewed-on: https://chromium-review.googlesource.com/1213560Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589906}
-
Max Morin authored
The APM expects data in the range [-1, 1] only. This CL also avoids sending bitstream stuff to snoopers, since they would misunderstand it anyways. The sanitation is only carried out when using the APM, to ensure that ordinary playback isn't impacted. Bug: 851959, 882360 Change-Id: I8b51af68f3a3e53383eb6630f73b88205faac887 Reviewed-on: https://chromium-review.googlesource.com/1215865Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589905}
-
Anders Hartvoll Ruud authored
This is needed to implement correct list behavior for interpolation of custom property lists. R=flackr@chromium.org Bug: 868959 Change-Id: I04a28307e4a4a0bdcc262fd289ec12be7bf40a50 Reviewed-on: https://chromium-review.googlesource.com/1212724 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589904}
-
Olga Sharonova authored
We'll be moving ForwardingAudioStreamFactory and stream brokers to IO thread. Simplifying dependencies now. Bug: 866440,852880,866442 Change-Id: Icf1634916ccb60c67f5b85f017328dcfa89947e7 Reviewed-on: https://chromium-review.googlesource.com/1215963 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589903}
-
Luke Sorenson authored
This reflects non-forwards / non-backwards compatible changes to the Video Capture Service mojom APIs, which ship with Chrome. Bug: 881398 Change-Id: Ia5833b63097035346bc388564b9bb6545ffa0c84 Reviewed-on: https://chromium-review.googlesource.com/1211082Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#589902}
-