- 18 Jun, 2019 40 commits
-
-
Rakina Zata Amni authored
Previously the IDL definition for toggleAttribute doesn't have those modifiers, so they behave differently than setAttribute when called on custom elements (it won't fire attributeChangedCallback, etc) Bug: 976177 Change-Id: I7d8107db8d07a2e2ec856305c56a178339c5e05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663881 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#670060}
-
Boris Sazonov authored
Bug: 975910 Change-Id: Ic03fafecfa7498888aa92bc7bb1f36ef7bc7661d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664137 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670059}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c6628127dc30..578c8ee0760e git log c6628127dc30..578c8ee0760e --date=short --no-merges --format='%ad %ae %s' 2019-06-18 robertphillips@google.com Suppress Valgrind test Created with: gclient setdep -r src/third_party/skia@578c8ee0760e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I1d4feb870ee6326cb5e9bde943147a55f10fb99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670058}
-
Maksim Ivanov authored
Store in the Local State (as a known_user preference) the boolean flag whether the SAML Credentials Passing API (a.k.a. the principals API) was used during the authentication of this user. Bug: 971795 Test: browser_tests --gtest_filter="SamlTest.*:OobeTest.*" Change-Id: I92a7e2c9c029cb02df8b51e581cb6e0f34e3e6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662552 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#670057}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/396982cd6b1e..8887979bb95f git log 396982cd6b1e..8887979bb95f --date=short --no-merges --format='%ad %ae %s' 2019-06-18 hjd@google.com Fix Bazel include of zlib Created with: gclient setdep -r src/third_party/perfetto@8887979bb95f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I82162842c2a144639b6da0f29215765a3be66668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664273Reviewed-by:
-
Dominick Ng authored
BUG=None Change-Id: I8c2d7e60c88c066d0fa0900b14703322a7aec353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663883 Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670055}
-
Balazs Engedy authored
The hashing function changed in M68, add hash -> interface name mappings based on the new hashing function, and also add mappings for new Mojo interfaces. Bug: None Change-Id: Ie4ecba77367b555dd3e4ecf8110ac60162856358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664077Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670054}
-
Evan Shrubsole authored
* Refactors the callback check out of EndTest Bug: 974078 Change-Id: Ie34b18d9ea09a0b5039acf74f32d24de98efa784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663415Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#670053}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67fa42fa225f..8b612d5f8850 Created with: gclient setdep -r src-internal@8b612d5f8850 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: Ife4e283cecb6dc2727912d253c0eeedfa7db8e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663467Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670052}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1c8dbf3fad8..2d223552e3fe git log b1c8dbf3fad8..2d223552e3fe --date=short --no-merges --format='%ad %ae %s' 2019-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src def9662348b0..11805e41d992 (5 commits) Created with: gclient setdep -r src/third_party/angle@2d223552e3fe The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I02e1906ef225595950c5f7eab7e7059b7dbc68f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663899Reviewed-by:
-
Raphael Kubo da Costa authored
Address a few nitpicks raised by engedy@ in https://chromium-review.googlesource.com/c/chromium/src/+/1652939. Bug: 967669 Change-Id: I71abcb6a81b839b5d842dadc6199009378e30295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664074 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#670050}
-
Koji Ishii authored
This patch fixes |NGLineBoxFragmentBuilder::Reset()| to reset unpositioned list marker. Bug: 967997 Change-Id: Ic776ac0881db2261da8e9a443c251c42554a39cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662984 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#670049}
-
Jiawei Shao authored
This patch defines 'angle_root' in //build_overrides/angle.gni so that the hard-coded assignment of 'angle_root' in the GN file of ANGLE (//third_party/angle/gni/angle.gni) can be removed in the following CL: https://chromium-review.googlesource.com/c/angle/angle/+/1522912 Bug: angleproject:3263 Change-Id: Ifc35dcc7782f84ebc1b9fb53f8f77c468bddc80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663737Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#670048}
-
Himanshu Jaju authored
Bug: 966039 Change-Id: I8186dc6af2ced82b1d8bd8519af71e8ff0f7c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635678 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#670047}
-
Pâris MEULEMAN authored
This CL extends the java |SigninManagerDelegate| interface and its android implementation |ChromeSigninManagerDelegate| with |getManagementDomain|, which will later use the Delegate native interface to access gaia utilities. Bug: 963400 Change-Id: Ie02eee1fdadda2193adb0624ea9eedf3840407e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617493 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670046}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves APIs which access to |token_cache_| in OAuth2AccessTokenManager to OAuth2AccessTokenManager from OAuth2TokenService. Bug: 967598 Change-Id: If07c87263571871ab380feb8e1be2975c2133f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663932 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#670045}
-
Boris Sazonov authored
A follow-up to https://crrev.com/c/1658572. Bug: 971393, b/133516269 Change-Id: I8ad3f3a5faf33ff1aae391e29b7e3de5e4024429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660497 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
When a user hovers over the first suggestion, the entire suggestion is read once. When a user hovers over the second suggestion, the first suggestion is read again and the second suggestion is then read. We send a selection event when the first suggestion becomes unselected. One solution is to send a selection event only when a suggestion was unselected and becomes selected. Video of the problem (Googlers only): go/autofill-chromevox-double-suggestions-read You can read the text that is read at the top of the screen. Pay attention to what is read when hover changes from the first suggestion to the second, from the second suggestion to the footer (Manager addresses...), etc. Video of the fix (Googlers only): go/autofill-chromevox-double-suggestions-read-fix Bug: 973441 Change-Id: Ic4686109aa77f3a84cbd6609d665d6c9d06873c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655908 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#670043}
-
Henrique Ferreiro authored
The new flow for Chrome OS involves calling PrimaryAccountMutator::SetPrimaryAccountAndUpdateAccountInfo(). This is part of a series of CLs to port ChromeOS to use PrimaryAccountMutator, to unify its behaviour with the other platforms, as described in https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto Bug: 814787 Change-Id: Ic60c721e094ca42093a4e636e9eec4c38a180d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652935 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/576af29d..37ed7df2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76ebe06ba2def3f4cb7ff8f7106a1a1b4262b2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663461Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670041}
-
Jiajie Hu authored
The method is quite similar to dispatchCompute(), except the number of work groups will be given by a pre-filled GPU buffer. Bug: 859249 Change-Id: I874759e1dca75613f1e638c104d186f3090c4b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651492Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajie Hu <jiajie.hu@intel.com> Cr-Commit-Position: refs/heads/master@{#670040}
-
Christian Dullweber authored
Record the number of exceptions where cookies are allowed for all third party requests on a specific domain. Bug: 967668 Change-Id: Iedd8a9f859c884c24b416be6997089c002c9086d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660495Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c9a952c8f7d..8159063989c4 git log 0c9a952c8f7d..8159063989c4 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 perezju@chromium.org [Telemetry] Remove value.HistogramValue Created with: gclient setdep -r src/third_party/catapult@8159063989c4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921616 TBR=eyaich@google.com Change-Id: Ia6a3edc25d1cbd29bbac7559918c25e493bea50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663895Reviewed-by:
-
Mohamed Abdelhalim authored
This change removes |net_error_code_| from NavigationHandleImpl, and uses |net_error_| inside NavigationRequest instead. Bug: 916537 Change-Id: I23762da074f355fee44d47e47e1b4d300f10e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662452 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#670037}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a9b00ac5d588..f9d08a25fbe1 git log a9b00ac5d588..f9d08a25fbe1 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 johnkslang@users.noreply.github.com Merge pull request #1804 from KhronosGroup/fix-930-subgroup--mask-ops 2019-06-18 cepheus@frii.com Bump revision. Created with: gclient setdep -r src/third_party/glslang/src@f9d08a25fbe1 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I6a8dae9a867293ab98c416c0ea19362dc098b632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664037Reviewed-by:
-
Jan Krcal authored
This reverts commit 5a3884b6. Reason for revert: Causes flakiness in ChromeLauncherControllerWithArcTest.Arc* unit-tests Original change's description: > [Sync] Use forwarding delegate for PRINTERS sync > > Printers sync runs on the UI thread but so far uses a proxy delegate > that posts tasks from UI thread to UI thread. > > This CL simplifies that and employs a forwarding delegate that runs > tasks synchronously. After this CL, all data types running on the UI > thread will have forwarding delegates. > > Bug: 867801 > Change-Id: I08e261323a9caa816899dd924f09ecdee69ec936 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621907 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661732} TBR=jkrcal@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 867801 Change-Id: Id0e4aab7bd4aca4c697fcfaa213cea8ef809f3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663496Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#670035}
-
Sylvain Defresne authored
The sole reason for this property to exists is to prevent fetching the list of accounts from SSO library before the primary account has been set. However, current design is that we want to load all accounts from the SSO library before setting the primary account, so remove this member variable whose purpose is no lost. See design at: https://docs.google.com/document/d/1_NknywZB7UCQdCiCxEPQU85lXouid_aMxdzujEJSiEM/view Bug: 957887 Change-Id: If0411f36a30c845951a75be745da3dd93e296050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662548 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#670034}
-
Lei Zhang authored
Also remove out of date owners. Change-Id: Ief360ae234c7977d86c364155a6d6fcaf3b35b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643657 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#670033}
-
Sergio Villar Senin authored
As part of the wtf/time.h removal we're removing all the WTF wrappers for the base::Time types. In order to keep the change under control we're migrating them all in smaller parts. The first step is to migrate blink/renderer/platform. Bug: 919383 Change-Id: I5a99f6212eb64db2f1497eff6062717ce41d9664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660855Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#670032}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e7f8c34384ed..c6628127dc30 git log e7f8c34384ed..c6628127dc30 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 bungeman@google.com Correctly call SkFontMgr_DirectWrite constructor. Created with: gclient setdep -r src/third_party/skia@c6628127dc30 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973361 TBR=bsalomon@google.com Change-Id: I6091d4032834ac5a7acb16ed17c7fc86202e4e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664035Reviewed-by:
-
Clemens Arbesser authored
Also, a small refactoring to allow code reuse between infobox-tests and details-tests. Bug: b/133725664 Change-Id: Ia241cb3bfdae69533a12f1c88fe466deefabef61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658021 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#670030}
-
Raymes Khoury authored
Change-Id: I72d2811487ad68ac26d645693ae07a5eed721376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653751Reviewed-by:
-
Lowell Manners authored
Bug: 786836 Change-Id: I9c867685877bb7bbf3786677d9dbace61f4f9df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634879 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670028}
-
Fredrik Söderquist authored
KURL::SetPort("") will yield a port of "0", use ḰURL::RemovePort instead which does the equivalent of what the spec says: "2. If the given value is the empty string, then set context object’s url’s port to null." https://url.spec.whatwg.org/#dom-url-port Bug: 971684 Change-Id: I68b218f5e7a596a54944be05a51a32fd93fbf677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658153Reviewed-by: -
Adam Rice authored
In order to prevent a fetch's body from being garbage collected while it was being read, BodyStreamBuffer's HasPendingActivity() method was made to return true when the ReadableStream was locked. With unified GC, this is no longer necessary, and is a source of bugs. Remove the functionality from UnderlyingSourceBase to track when the ReadableStream wrapping it is locked. Also clear the |controller_| member in ReadableStreamDefaultControllerNative::Close() and Error(). This is no longer functionally important but can aid earlier garbage collection. BUG=902633 Change-Id: If6150e26697f68f984fd05484169709bc165663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662255Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#670026}
-
Pâris MEULEMAN authored
This CL extends the java |SigninManagerDelegate| interface and its android implementation |ChromeSigninManagerDelegate| with |isUserManaged|, which will later use the Delegate native interface to access the user profile. This CL also renames isUserManaged to isAccountManaged as discussed with bsazonov@. Bug: 963400 Change-Id: I5e926a8d77902ef7b91e0e2879ecbd72b331de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617349 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
The embedding LayoutObjects intrinsic size may be left as the old stale size if the new dimensions are not fully defined - which means that it qualifies as having a size and and aspect ratio (where having the former implies having the latter in most cases). Call IntrinsicSizeChanged() instead of just SetNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(...), since the former also resets the intrinsic size to 300x150 (incorporating zoom). Clean up HTMLPlugInElement::GetLayoutEmbeddedObject a little bit while at it. Bug: 971647 Change-Id: I5c165d1ae18888b6368c9011bc6752b599629118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660341 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
- RendererScheduler.TasksWithSafepoints.SafepointCount - RendererScheduler.TasksWithSafepoints.TaskSliceTime - RendererScheduler.TasksWithSafepoints.TaskTime Bug: 804661 Change-Id: Ib4a5fbdca90caddc8b6820216e86333f1316b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578720Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#670023}
-
Evan Shrubsole authored
Bug: 945486 Change-Id: I6adac460304d7477c548bc5efc062e147cdc99f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660650 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
-
Takashi Sakamoto authored
Bug: 953194 Change-Id: I5c9d409288eb2f84d43a373d11170b5c70dd81e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662104Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#670021}
-
